chore: migrate in-tree callers off deprecated bigSegmentStatus APIs

Author: beekld

libs/common/include/launchdarkly/data/evaluation_reason.hpp

@@ -190,6 +190,9 @@ class EvaluationReason {
     friend std::ostream& operator<<(std::ostream& out,
                                     EvaluationReason const& reason);
 
+    friend bool operator==(EvaluationReason const& lhs,
+                           EvaluationReason const& rhs);
+
    private:
     enum Kind kind_;
     std::optional<enum ErrorKind> error_kind_;

libs/common/src/data/evaluation_reason.cpp

@@ -164,7 +164,7 @@ bool operator==(EvaluationReason const& lhs, EvaluationReason const& rhs) {
     return lhs.Kind() == rhs.Kind() && lhs.ErrorKind() == rhs.ErrorKind() &&
            lhs.InExperiment() == rhs.InExperiment() &&
            lhs.BigSegmentsStatus() == rhs.BigSegmentsStatus() &&
-           lhs.BigSegmentStatus() == rhs.BigSegmentStatus() &&
+           lhs.big_segment_status_ == rhs.big_segment_status_ &&
            lhs.PrerequisiteKey() == rhs.PrerequisiteKey() &&
            lhs.RuleId() == rhs.RuleId() && lhs.RuleIndex() == rhs.RuleIndex();
 }

libs/common/tests/bindings/evaluation_detail_test.cpp

@@ -22,8 +22,12 @@ TEST(EvaluationDetailBindings, EvaluationReasonError) {
 
 TEST(EvaluationDetailBindings, EvaluationReasonFallthrough) {
     auto reason = EvaluationReason(EvaluationReason::Kind::kFallthrough,
-                                   std::nullopt, std::nullopt, std::nullopt,
-                                   std::nullopt, true, std::nullopt);
+                                   /* error_kind= */ std::nullopt,
+                                   /* rule_index= */ std::nullopt,
+                                   /* rule_id= */ std::nullopt,
+                                   /* prerequisite_key= */ std::nullopt,
+                                   /* in_experiment= */ true,
+                                   EvaluationReason::BigSegmentsStatus::kNone);
     auto ld_reason = reinterpret_cast<LDEvalReason>(&reason);
 
     ASSERT_EQ(LDEvalReason_Kind(ld_reason), LD_EVALREASON_FALLTHROUGH);
@@ -52,9 +56,13 @@ TEST(EvaluationDetailBindings, EvaluationDetailError) {
 TEST(EvaluationDetailBindings, EvaluationDetailSuccess) {
     auto detail = CEvaluationDetail(EvaluationDetail<bool>(
         true, 42,
-        EvaluationReason(EvaluationReason::Kind::kFallthrough, std::nullopt,
-                         std::nullopt, std::nullopt, std::nullopt, true,
-                         std::nullopt)));
+        EvaluationReason(EvaluationReason::Kind::kFallthrough,
+                         /* error_kind= */ std::nullopt,
+                         /* rule_index= */ std::nullopt,
+                         /* rule_id= */ std::nullopt,
+                         /* prerequisite_key= */ std::nullopt,
+                         /* in_experiment= */ true,
+                         EvaluationReason::BigSegmentsStatus::kNone)));
 
     auto ld_detail = reinterpret_cast<LDEvalDetail>(&detail);
 

libs/internal/tests/event_summarizer_test.cpp

@@ -124,8 +124,13 @@ static FeatureEventParams FeatureEventFromParams(EvaluationParams params,
         params.feature_version,
         params.feature_variation,
         launchdarkly::EvaluationReason(
-            launchdarkly::EvaluationReason::Kind::kFallthrough, std::nullopt,
-            std::nullopt, std::nullopt, std::nullopt, false, std::nullopt),
+            launchdarkly::EvaluationReason::Kind::kFallthrough,
+            /* error_kind= */ std::nullopt,
+            /* rule_index= */ std::nullopt,
+            /* rule_id= */ std::nullopt,
+            /* prerequisite_key= */ std::nullopt,
+            /* in_experiment= */ false,
+            launchdarkly::EvaluationReason::BigSegmentsStatus::kNone),
         false,
         std::nullopt,
     };
@@ -356,8 +361,11 @@ TEST(SummarizerTests, MissingFlagCreatesCounterUsingDefaultValue) {
 
         EvaluationReason(EvaluationReason::Kind::kError,
                          EvaluationReason::ErrorKind::kFlagNotFound,
-                         std::nullopt, std::nullopt, std::nullopt, false,
-                         std::nullopt),
+                         /* rule_index= */ std::nullopt,
+                         /* rule_id= */ std::nullopt,
+                         /* prerequisite_key= */ std::nullopt,
+                         /* in_experiment= */ false,
+                         EvaluationReason::BigSegmentsStatus::kNone),
 
         false,
         std::nullopt,