fix: stop emitting kOff status from FDv2DataSystem destructor

Author: beekld

libs/server-sdk/src/data_systems/fdv2/fdv2_data_system.cpp

@@ -68,7 +68,6 @@ void FDv2DataSystem::Close() {
     if (active_conditions_) {
         active_conditions_->Close();
     }
-    status_manager_->SetState(DataSourceStatus::DataSourceState::kOff);
 }
 
 std::shared_ptr<data_model::FlagDescriptor> FDv2DataSystem::GetFlag(

libs/server-sdk/src/data_systems/fdv2/fdv2_data_system.hpp

@@ -51,9 +51,8 @@ namespace launchdarkly::server_side::data_systems {
  * Destruction protocol:
  *
  *   The destructor cancels in-flight orchestration (closes the active
- *   source, emits status kOff), but does NOT block to drain executor
- *   callbacks that may already be queued. Before destroying, the caller
- *   must ensure both of:
+ *   source) but does NOT block to drain executor callbacks that may
+ *   already be queued. Before destroying, the caller must ensure both of:
  *
  *     1. The executor that orchestration callbacks run on has been stopped
  *        AND any thread running it has been joined. Otherwise a previously-
@@ -120,8 +119,6 @@ namespace launchdarkly::server_side::data_systems {
  *               v
  *     [Done; final status preserved]
  *
- *     Calling the destructor at any time -> [Closed; status kOff].
- *
  * Status transitions:
  *
  *   kInitializing (initial) -> kValid on first successful ChangeSet apply.
@@ -130,11 +127,10 @@ namespace launchdarkly::server_side::data_systems {
  *                              the initializer phase if not yet Valid).
  *                              kOff if all initializers exhaust without data
  *                              and no synchronizers are configured.
- *   kValid                  -> kInterrupted on errors; kOff in destructor or
- *                              when synchronizers cycle through and exhaust.
+ *   kValid                  -> kInterrupted on errors; kOff when
+ *                              synchronizers cycle through and exhaust.
  *   kInterrupted            -> kValid on next successful ChangeSet apply;
- *                              kOff in destructor or on synchronizer
- *                              exhaustion.
+ *                              kOff on synchronizer exhaustion.
  *   kOff                    -> terminal.
  */
 class FDv2DataSystem final : public data_interfaces::IDataSystem {

libs/server-sdk/tests/fdv2_data_system_test.cpp

@@ -272,25 +272,6 @@ TEST(FDv2DataSystemTest, OfflineMode_NoFactories_StatusValid) {
     EXPECT_FALSE(ds.Initialized());
 }
 
-TEST(FDv2DataSystemTest, Destructor_TransitionsStatusToOff) {
-    auto logger = MakeNullLogger();
-    boost::asio::io_context ioc;
-    data_components::DataSourceStatusManager status_manager;
-
-    {
-        FDv2DataSystem ds({}, {}, /*fallback_condition_factory=*/nullptr,
-                          /*recovery_condition_factory=*/nullptr,
-                          ioc.get_executor(), &status_manager, logger);
-        ds.Initialize();
-        ASSERT_EQ(status_manager.Status().State(),
-                  DataSourceStatus::DataSourceState::kValid);
-    }
-
-    // After ~FDv2DataSystem, status is Off.
-    EXPECT_EQ(status_manager.Status().State(),
-              DataSourceStatus::DataSourceState::kOff);
-}
-
 // ============================================================================
 // Initializer phase
 // ============================================================================
@@ -1227,14 +1208,13 @@ TEST(FDv2DataSystemTest, InitializerFdv1FlagSwitchesToFdv1Adapter) {
 // ============================================================================
 //
 // The destructor contract (fdv2_data_system.hpp) requires the destructor to
-// cancel in-flight orchestration (close the active source, transition status
-// to kOff) without firing any continuation against the destroyed object. The
-// caller's responsibility is to ensure the executor is no longer running by
-// the time destruction begins; the orchestrator's responsibility is to leave
-// nothing dangling. These two tests pin that contract for both phases.
+// cancel in-flight orchestration (close the active source) without firing
+// any continuation against the destroyed object. The caller's responsibility
+// is to ensure the executor is no longer running by the time destruction
+// begins; the orchestrator's responsibility is to leave nothing dangling.
+// These two tests pin that contract for both phases.
 
-TEST(FDv2DataSystemTest,
-     Destructor_WithInFlightInitializer_ClosesSourceAndStatusOff) {
+TEST(FDv2DataSystemTest, Destructor_WithInFlightInitializer_ClosesSource) {
     auto logger = MakeNullLogger();
     boost::asio::io_context ioc;
     data_components::DataSourceStatusManager status_manager;
@@ -1261,12 +1241,9 @@ TEST(FDv2DataSystemTest,
     // ~FDv2DataSystem ran with the initializer's Future still unresolved.
 
     EXPECT_TRUE(initializer_closed);
-    EXPECT_EQ(status_manager.Status().State(),
-              DataSourceStatus::DataSourceState::kOff);
 }
 
-TEST(FDv2DataSystemTest,
-     Destructor_WithInFlightSynchronizer_ClosesSourceAndStatusOff) {
+TEST(FDv2DataSystemTest, Destructor_WithInFlightSynchronizer_ClosesSource) {
     auto logger = MakeNullLogger();
     boost::asio::io_context ioc;
     data_components::DataSourceStatusManager status_manager;
@@ -1292,6 +1269,4 @@ TEST(FDv2DataSystemTest,
     }
 
     EXPECT_TRUE(synchronizer_closed);
-    EXPECT_EQ(status_manager.Status().State(),
-              DataSourceStatus::DataSourceState::kOff);
 }