Skip to content

Commit b741911

Browse files
kinyokliondevin-ai-integration[bot]
kinyoklion
and
devin-ai-integration[bot]
authored
chore: use @launchdarkly scoped names in package.json files (#518)
## Summary Updates all 8 `package.json` files to use `@launchdarkly/`-scoped package names (e.g. `@launchdarkly/cpp-client` instead of `launchdarkly-cpp-client`). These `package.json` files are not published npm packages — they exist solely to model the inter-package dependency graph for release-please's `node-workspace` plugin. To prevent the name change from altering git tag format (release-please strips the `@scope/` prefix by default, which would change tags from `launchdarkly-cpp-client-v3.11.1` to `cpp-client-v3.11.1`), explicit `"component"` overrides have been added to each package in `release-please-config.json`. This preserves the existing `launchdarkly-cpp-*-v<version>` tag format. No changes to versions, dependency graph structure, CMake targets, build scripts, CI workflows, or workflow outputs. ## Review & Testing Checklist for Human - [ ] **Verify `component` + `node-workspace` interaction**: Confirm that release-please respects the `"component"` field when the `node-workspace` plugin is active with scoped package names. This cannot be tested locally — it only runs on push to `main`. Consider doing a dry run or checking release-please source/docs for confirmation. - [ ] **Verify dependency graph is fully updated**: Every `dependencies` reference across all 8 `package.json` files should use the new `@launchdarkly/` prefix. A stale reference would break the `node-workspace` plugin's graph resolution. - [ ] **Spot-check component values match old names**: Each `"component"` value in `release-please-config.json` should exactly match the previous `"name"` from the corresponding `package.json` (e.g. `libs/server-sent-events` had name `launchdarkly-cpp-sse-client`, and the component is `launchdarkly-cpp-sse-client`). ### Notes - The `js-core` repo already uses `@launchdarkly/`-scoped names with the `node-workspace` plugin successfully, which gives some confidence this pattern works. However, `js-core` does not use explicit `component` overrides — its tags use the stripped names (e.g. `js-client-sdk-v4.4.1`). So the combination of scoped names + component overrides in `node-workspace` is the novel part here. - Recommended test plan: After merge, monitor the next release-please PR to confirm it generates correct tag names and updates dependency versions as expected. Link to Devin session: https://app.devin.ai/sessions/37efb8037fa940deb4938b906a1a42ad Requested by: @kinyoklion <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: only updates release-please/node-workspace metadata (package names and dependency references) without touching runtime code. Main risk is misconfiguration causing incorrect tag naming or dependency graph resolution in the release process. > > **Overview** > Updates the workspace `package.json` metadata to use `@launchdarkly/`-scoped names and updates all inter-package `dependencies` to reference the scoped packages. > > Adjusts `release-please-config.json` to add explicit `component` values for each package so release-please continues generating the existing `launchdarkly-cpp-*-v<version>` tag/component names despite the new scoped package names. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 5db44f1. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
1 parent 884b394 commit b741911

9 files changed

Lines changed: 35 additions & 23 deletions

File tree

‎libs/client-sdk/package.json‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
{
2-
"name": "launchdarkly-cpp-client",
2+
"name": "@launchdarkly/cpp-client",
33
"description": "This package.json exists for modeling dependencies for the release process.",
44
"version": "3.11.1",
55
"private": true,
66
"dependencies": {
7-
"launchdarkly-cpp-internal": "0.13.0",
8-
"launchdarkly-cpp-common": "1.11.0",
9-
"launchdarkly-cpp-sse-client": "0.6.1"
7+
"@launchdarkly/cpp-internal": "0.13.0",
8+
"@launchdarkly/cpp-common": "1.11.0",
9+
"@launchdarkly/cpp-sse-client": "0.6.1"
1010
}
1111
}

‎libs/common/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "launchdarkly-cpp-common",
2+
"name": "@launchdarkly/cpp-common",
33
"description": "This package.json exists for modeling dependencies for the release process.",
44
"version": "1.11.0",
55
"private": true

‎libs/internal/package.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
{
2-
"name": "launchdarkly-cpp-internal",
2+
"name": "@launchdarkly/cpp-internal",
33
"description": "This package.json exists for modeling dependencies for the release process.",
44
"version": "0.13.0",
55
"private": true,
66
"dependencies": {
7-
"launchdarkly-cpp-common": "1.11.0",
8-
"launchdarkly-cpp-networking": "0.2.0"
7+
"@launchdarkly/cpp-common": "1.11.0",
8+
"@launchdarkly/cpp-networking": "0.2.0"
99
}
1010
}

‎libs/networking/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "launchdarkly-cpp-networking",
2+
"name": "@launchdarkly/cpp-networking",
33
"description": "This package.json exists for modeling dependencies for the release process.",
44
"version": "0.2.0",
55
"private": true

‎libs/server-sdk-otel/package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
{
2-
"name": "launchdarkly-cpp-server-otel",
2+
"name": "@launchdarkly/cpp-server-otel",
33
"description": "This package.json exists for modeling dependencies for the release process.",
44
"version": "0.1.1",
55
"private": true,
66
"dependencies": {
7-
"launchdarkly-cpp-server": "3.10.1"
7+
"@launchdarkly/cpp-server": "3.10.1"
88
}
99
}

‎libs/server-sdk-redis-source/package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
{
2-
"name": "launchdarkly-cpp-server-redis-source",
2+
"name": "@launchdarkly/cpp-server-redis-source",
33
"description": "This package.json exists for modeling dependencies for the release process.",
44
"version": "2.2.2",
55
"private": true,
66
"dependencies": {
7-
"launchdarkly-cpp-server": "3.10.1"
7+
"@launchdarkly/cpp-server": "3.10.1"
88
}
99
}

‎libs/server-sdk/package.json‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
{
2-
"name": "launchdarkly-cpp-server",
2+
"name": "@launchdarkly/cpp-server",
33
"description": "This package.json exists for modeling dependencies for the release process.",
44
"version": "3.10.1",
55
"private": true,
66
"dependencies": {
7-
"launchdarkly-cpp-internal": "0.13.0",
8-
"launchdarkly-cpp-common": "1.11.0",
9-
"launchdarkly-cpp-sse-client": "0.6.1"
7+
"@launchdarkly/cpp-internal": "0.13.0",
8+
"@launchdarkly/cpp-common": "1.11.0",
9+
"@launchdarkly/cpp-sse-client": "0.6.1"
1010
}
1111
}

‎libs/server-sent-events/package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
{
2-
"name": "launchdarkly-cpp-sse-client",
2+
"name": "@launchdarkly/cpp-sse-client",
33
"description": "This package.json exists for modeling dependencies for the release process.",
44
"private": true,
55
"version": "0.6.1",
66
"dependencies": {
7-
"launchdarkly-cpp-networking": "0.2.0"
7+
"@launchdarkly/cpp-networking": "0.2.0"
88
}
99
}

‎release-please-config.json‎

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
],
55
"packages": {
66
"libs/client-sdk": {
7+
"component": "launchdarkly-cpp-client",
78
"extra-files": [
89
"include/launchdarkly/client_side/client.hpp",
910
"tests/client_c_bindings_test.cpp",
@@ -12,6 +13,7 @@
1213
]
1314
},
1415
"libs/server-sdk": {
16+
"component": "launchdarkly-cpp-server",
1517
"extra-files": [
1618
"include/launchdarkly/server_side/client.hpp",
1719
"tests/server_c_bindings_test.cpp",
@@ -20,19 +22,29 @@
2022
]
2123
},
2224
"libs/server-sdk-redis-source": {
25+
"component": "launchdarkly-cpp-server-redis-source",
2326
"extra-files": [
2427
"CMakeLists.txt"
2528
]
2629
},
2730
"libs/server-sdk-otel": {
31+
"component": "launchdarkly-cpp-server-otel",
2832
"bump-minor-pre-major": true,
2933
"extra-files": [
3034
"CMakeLists.txt"
3135
]
3236
},
33-
"libs/server-sent-events": {},
34-
"libs/common": {},
35-
"libs/internal": {},
36-
"libs/networking": {}
37+
"libs/server-sent-events": {
38+
"component": "launchdarkly-cpp-sse-client"
39+
},
40+
"libs/common": {
41+
"component": "launchdarkly-cpp-common"
42+
},
43+
"libs/internal": {
44+
"component": "launchdarkly-cpp-internal"
45+
},
46+
"libs/networking": {
47+
"component": "launchdarkly-cpp-networking"
48+
}
3749
}
3850
}

0 commit comments

Comments
 (0)