Skip to content

Commit f99f1ad

Browse files
committed
chore: distinguish engaged vs. unconfigured FDv1 fallback in logs
1 parent 5a2a9bc commit f99f1ad

1 file changed

Lines changed: 18 additions & 4 deletions

File tree

libs/server-sdk/src/data_systems/fdv2/fdv2_data_system.cpp

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -191,9 +191,16 @@ void FDv2DataSystem::OnInitializerResult(
191191
return;
192192
}
193193
if (result.fdv1_fallback) {
194-
LD_LOG(logger_, LogLevel::kInfo)
195-
<< Identity() << ": FDv1 fallback engaged";
196194
source_manager_.SwitchToFDv1Fallback();
195+
if (source_manager_.AvailableSynchronizerCount() > 0) {
196+
LD_LOG(logger_, LogLevel::kInfo)
197+
<< Identity() << ": FDv1 fallback engaged";
198+
} else {
199+
LD_LOG(logger_, LogLevel::kWarn)
200+
<< Identity()
201+
<< ": FDv1 fallback directive received; no FDv1 "
202+
"fallback synchronizer configured";
203+
}
197204
got_basis = true;
198205
}
199206
}
@@ -369,9 +376,16 @@ void FDv2DataSystem::OnSynchronizerResult(
369376
return;
370377
}
371378
if (result.fdv1_fallback) {
372-
LD_LOG(logger_, LogLevel::kInfo)
373-
<< Identity() << ": FDv1 fallback engaged";
374379
source_manager_.SwitchToFDv1Fallback();
380+
if (source_manager_.AvailableSynchronizerCount() > 0) {
381+
LD_LOG(logger_, LogLevel::kInfo)
382+
<< Identity() << ": FDv1 fallback engaged";
383+
} else {
384+
LD_LOG(logger_, LogLevel::kWarn)
385+
<< Identity()
386+
<< ": FDv1 fallback directive received; no FDv1 "
387+
"fallback synchronizer configured";
388+
}
375389
active_synchronizer_.reset();
376390
active_conditions_.reset();
377391
advance = true;

0 commit comments

Comments
 (0)