ci: Enable dynamodb-source releases via release-please#568
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5c34904. Configure here.
| OPENSSL_ROOT_DIR: ${{ steps.install-openssl.outputs.OPENSSL_ROOT_DIR }} | ||
| # aws-sdk-cpp (dynamodb-source) calls find_package(CURL) on Linux/macOS, regardless of LD_CURL_NETWORKING. | ||
| CURL_ROOT: ${{ steps.install-curl.outputs.CURL_ROOT }} | ||
| CMAKE_PREFIX_PATH: ${{ steps.install-curl.outputs.CURL_ROOT }} |
There was a problem hiding this comment.
Windows Beast build missing CURL
High Severity
This PR wires DynamoDB into sdk-release and adds CURL_ROOT / CMAKE_PREFIX_PATH only on Linux and macOS Boost.Beast builds, but the new release-server-dynamodb matrix still runs on windows-2022. For launchdarkly-cpp-server-dynamodb-source, build-release-windows.sh turns on DynamoDB/aws-sdk at configure even without --with-curl, while the Windows Boost.Beast step still omits those env vars—unlike server-dynamodb.yml, which passes them for the same simulated release path.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 5c34904. Configure here.
There was a problem hiding this comment.
This was intentional, because the dynamodb windows build doesn't seem to need CURL. But maybe it would be better to keep it consistent with the CI build...
There was a problem hiding this comment.
I'll leave it unless a reviewer objects. I don't feel strongly either way.
There was a problem hiding this comment.
Interesting. Seems good the way it is. Just coincidental that CURL is a dependency.
3 participants
Summary
Wires
libs/server-sdk-dynamodb-sourceinto the release-please draft + publish flow so its releases cut and un-draft automatically, same as client/server/redis."draft": trueinrelease-please-config.jsonfor dynamodb.release-server-dynamodb(matrix) +-mac-arm64+publish-release-server-dynamodbjobs inrelease-please.yml. Mirrors the redis pattern.sdk-releaseaction passesCURL_ROOTandCMAKE_PREFIX_PATHto its Linux and macOS Boost.Beast build steps. aws-sdk-cpp callsfind_package(CURL)on Linux/macOS regardless ofLD_CURL_NETWORKING; on macOS the hint is needed because homebrew's curl isn't in cmake's default search path. Windows uses WinHTTP, so aws-sdk-cpp doesn't need libcurl there and the env isn't passed.The dynamodb release path has never been cut end-to-end. Per-package CI builds dynamodb daily, but the
sdk-releasecomposite action hasn't been run against it -- the first real release may surface latent issues.