Skip to content

ci: Fix Windows release attestation by writing CRLF checksums#571

Open
beekld wants to merge 2 commits into
mainfrom
beeklimt/fix-windows-attest-line-endings
Open

ci: Fix Windows release attestation by writing CRLF checksums#571
beekld wants to merge 2 commits into
mainfrom
beeklimt/fix-windows-attest-line-endings

Conversation

@beekld

@beekld beekld commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Windows release jobs fail at actions/attest: its parser splits checksums.txt on os.EOL ('\r\n' on Windows), but the Generate-checksums step writes LF-only. The whole file becomes a single record whose subject name exceeds 256 chars.

Pipe through sed 's/$/\r/' on the Windows branch to produce CRLF. Linux and macOS unchanged.

Confirmed on a Windows runner: sha256sum on Git Bash writes LF only, the base64 round-trip preserves it, and Node os.EOL on the runner is "\r\n".


Note

Low Risk
CI-only line-ending tweak on the Windows checksum branch; no runtime SDK or security logic changes.

Overview
Fixes Windows release jobs failing at actions/attest when parsing checksums.txt.

On the Windows matrix leg, the Generate checksums file step now pipes decoded hashes through sed 's/$/\r/' so each line ends with CRLF, matching how actions/attest splits on os.EOL (\r\n) on Windows. LF-only output was treated as one record and blew past subject name limits. Linux and macOS checksum generation is unchanged.

The same one-line change is applied everywhere that Windows hash output is written: manual-sdk-release-artifacts.yml and four release jobs in release-please.yml (client, server, redis, dynamodb).

Reviewed by Cursor Bugbot for commit 840d153. Bugbot is set up for automated code reviews on this repo. Configure here.

@beekld beekld requested a review from a team as a code owner June 30, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant