fix: exclude documentation files from NuGet package builds#263
Merged
Conversation
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
kinyoklion
changed the title
gao-artur
reviewed
May 24, 2026
… page Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b53259a. Configure here.
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
jsonbailey
approved these changes
May 27, 2026
This was referenced May 27, 2026
kinyoklion
pushed a commit
that referenced
this pull request
May 27, 2026
🤖 I have created a release *beep* *boop* --- ## [5.7.3](LaunchDarkly.ClientSdk-v5.7.2...LaunchDarkly.ClientSdk-v5.7.3) (2026-05-27) ### Bug Fixes * exclude documentation files from NuGet package builds ([#263](#263)) ([cc86ad6](cc86ad6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Release-metadata-only PR with no application or SDK runtime code changes in the diff. > > **Overview** > Release Please bumps **LaunchDarkly.ClientSdk** from **5.7.2** to **5.7.3** across the release manifest, `LaunchDarkly.ClientSdk.csproj`, `PROVENANCE.md`, and `CHANGELOG.md`. > > The release notes document a **patch** fix from [#263](#263): documentation files are excluded from NuGet package builds. This PR does not include that packaging change—only the version and release metadata updates. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 633c2d3. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
kinyoklion
pushed a commit
that referenced
this pull request
May 27, 2026
🤖 I have created a release *beep* *boop* --- ## [8.12.2](LaunchDarkly.ServerSdk-v8.12.1...LaunchDarkly.ServerSdk-v8.12.2) (2026-05-27) ### Bug Fixes * exclude documentation files from NuGet package builds ([#263](#263)) ([cc86ad6](cc86ad6)) * use basis query param for FDv2 polling selector ([#260](#260)) ([abaee9d](abaee9d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Automated version and changelog updates only; functional fixes are described in the changelog but not introduced in this diff. > > **Overview** > Release Please bumps **LaunchDarkly.ServerSdk** from **8.12.1** to **8.12.2** across the manifest, `LaunchDarkly.ServerSdk.csproj`, `PROVENANCE.md`, and a new **CHANGELOG** section dated 2026-05-27. > > The release notes two bug fixes already landed on main: **NuGet** builds no longer pack repo documentation files (`Pack>false` on doc assets in the csproj), and **FDv2** polling uses the **`basis`** query parameter on the polling selector (see `FDv2PollingRequestor`). This PR does not change SDK source beyond the version string. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 0e2a793. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
kinyoklion
pushed a commit
that referenced
this pull request
May 27, 2026
🤖 I have created a release *beep* *boop* --- ## [5.0.1](LaunchDarkly.ServerSdk.DynamoDB-v5.0.0...LaunchDarkly.ServerSdk.DynamoDB-v5.0.1) (2026-05-27) ### Bug Fixes * exclude documentation files from NuGet package builds ([#263](#263)) ([cc86ad6](cc86ad6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Version and release-metadata only; no application or SDK behavior changes in this diff. > > **Overview** > This PR is a **Release Please** cut that publishes **`LaunchDarkly.ServerSdk.DynamoDB` 5.0.1** by bumping the package version everywhere release automation expects it. > > The diff updates `.release-please-manifest.json`, the `<Version>` in `LaunchDarkly.ServerSdk.DynamoDB.csproj`, the new **5.0.1** section in `CHANGELOG.md`, and the `SDK_VERSION` example in `PROVENANCE.md`. There is **no runtime or integration logic** in the diff itself; the changelog notes the release includes the fix from [#263](#263) to **exclude documentation files from NuGet package builds** (already landed on the branch this release tags). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 06128e7. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
kinyoklion
pushed a commit
that referenced
this pull request
May 27, 2026
🤖 I have created a release *beep* *boop* --- ## [0.9.4](LaunchDarkly.ServerSdk.Ai-v0.9.3...LaunchDarkly.ServerSdk.Ai-v0.9.4) (2026-05-27) ### Bug Fixes * exclude documentation files from NuGet package builds ([#263](#263)) ([cc86ad6](cc86ad6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Mechanical version and changelog updates from Release Please; no application logic changes in this diff. > > **Overview** > **Release Please** cuts **LaunchDarkly.ServerSdk.Ai** from **0.9.3** to **0.9.4** by updating `.release-please-manifest.json`, `LaunchDarkly.ServerSdk.Ai.csproj`, `SdkInfo.Version`, `PROVENANCE.md`, and a new **CHANGELOG** section. > > The release notes attribute the version to a **bug fix** (already landed on main): **documentation and doc-build files are no longer packed into the NuGet** (e.g. `Pack=false` on changelog/contributing/docfx paths in the csproj, per [#263](#263)). This PR does not change runtime SDK behavior—only release metadata and published package contents for the next NuGet publish. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 642f092. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
kinyoklion
pushed a commit
that referenced
this pull request
May 27, 2026
🤖 I have created a release *beep* *boop* --- ## [5.1.1](LaunchDarkly.ServerSdk.Redis-v5.1.0...LaunchDarkly.ServerSdk.Redis-v5.1.1) (2026-05-27) ### Bug Fixes * exclude documentation files from NuGet package builds ([#263](#263)) ([cc86ad6](cc86ad6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Automated version and documentation updates with no runtime or API changes in the diff. > > **Overview** > **Release Please** bumps **LaunchDarkly.ServerSdk.Redis** from **5.1.0** to **5.1.1** in `.release-please-manifest.json`, `LaunchDarkly.ServerSdk.Redis.csproj`, `PROVENANCE.md`, and adds a **5.1.1** changelog entry. > > The noted fix is excluding documentation files from NuGet package builds ([#263]); this PR does not change project or packaging logic—only version and release metadata. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit dd28f4c. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
kinyoklion
pushed a commit
that referenced
this pull request
May 27, 2026
🤖 I have created a release *beep* *boop* --- ## [1.5.1](LaunchDarkly.ServerSdk.Telemetry-v1.5.0...LaunchDarkly.ServerSdk.Telemetry-v1.5.1) (2026-05-27) ### Bug Fixes * exclude documentation files from NuGet package builds ([#263](#263)) ([cc86ad6](cc86ad6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Version and release-metadata only; no runtime or API changes in this diff. > > **Overview** > **Release Please** bumps **LaunchDarkly.ServerSdk.Telemetry** from **1.5.0** to **1.5.1** across the manifest, `LaunchDarkly.ServerSdk.Telemetry.csproj`, `PROVENANCE.md`, and a new **CHANGELOG** entry. > > The release documents the bug fix from [#263](#263): documentation assets (e.g. `CHANGELOG.md`, `docfx.json`, `index.md`) are no longer included in the NuGet package—only `README.md` remains packed for consumers. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 6a9d0f2. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
kinyoklion
pushed a commit
that referenced
this pull request
May 27, 2026
🤖 I have created a release *beep* *boop* --- ## [5.0.1](LaunchDarkly.ServerSdk.Consul-v5.0.0...LaunchDarkly.ServerSdk.Consul-v5.0.1) (2026-05-27) ### Bug Fixes * exclude documentation files from NuGet package builds ([#263](#263)) ([cc86ad6](cc86ad6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Version and release-metadata updates only; no runtime or API changes in this diff. > > **Overview** > **Release 5.0.1** for `LaunchDarkly.ServerSdk.Consul` bumps the package version everywhere Release Please tracks it: `.release-please-manifest.json`, `LaunchDarkly.ServerSdk.Consul.csproj`, `CHANGELOG.md`, and `PROVENANCE.md` verification examples. > > The changelog records a **patch** fix from [#263](#263): documentation files are excluded from NuGet package builds. This PR does not include that packaging change—only the automated version and release notes for the already-merged fix. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 9812e8f. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
abelonogov-ld
added a commit
that referenced
this pull request
May 27, 2026
…y/dotnet-core into andrey/register-plugin * 'andrey/register-plugin' of ssh://github.com/launchdarkly/dotnet-core: chore(main): release LaunchDarkly.ServerSdk 8.13.0 (#273) chore(main): release LaunchDarkly.ServerSdk.Consul 5.0.1 (#270) chore(main): release LaunchDarkly.ServerSdk.Telemetry 1.5.1 (#268) chore(main): release LaunchDarkly.ServerSdk.Redis 5.1.1 (#267) feat: add X-LaunchDarkly-Instance-Id header (#258) chore(main): release LaunchDarkly.ServerSdk.Ai 0.9.4 (#271) chore(main): release LaunchDarkly.ServerSdk.DynamoDB 5.0.1 (#269) chore(main): release LaunchDarkly.ServerSdk 8.12.2 (#262) chore(main): release LaunchDarkly.ClientSdk 5.7.3 (#272) fix: exclude documentation files from NuGet package builds (#263)
evgenygunko
pushed a commit
to evgenygunko/CopyWordsDA
that referenced
this pull request
May 28, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [LaunchDarkly.ClientSdk](https://github.com/launchdarkly/dotnet-core) | `5.7.2` → `5.8.0` |  |  | --- ### Release Notes <details> <summary>launchdarkly/dotnet-core (LaunchDarkly.ClientSdk)</summary> ### [`v5.8.0`](https://github.com/launchdarkly/dotnet-core/releases/tag/LaunchDarkly.ClientSdk-v5.8.0): LaunchDarkly.ClientSdk: v5.8.0 [Compare Source](launchdarkly/dotnet-core@LaunchDarkly.ClientSdk-v5.7.3...LaunchDarkly.ClientSdk-v5.8.0) ##### Features - Allow register plugins dynamically ([#​266](launchdarkly/dotnet-core#266)) ([547e518](launchdarkly/dotnet-core@547e518)) *** This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> ### [`v5.7.3`](https://github.com/launchdarkly/dotnet-core/releases/tag/LaunchDarkly.ClientSdk-v5.7.3): LaunchDarkly.ClientSdk: v5.7.3 [Compare Source](launchdarkly/dotnet-core@LaunchDarkly.ClientSdk-v5.7.2...LaunchDarkly.ClientSdk-v5.7.3) ##### Bug Fixes - exclude documentation files from NuGet package builds ([#​263](launchdarkly/dotnet-core#263)) ([cc86ad6](launchdarkly/dotnet-core@cc86ad6)) *** This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or PR is renamed to start with "rebase!". 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
evgenygunko
pushed a commit
to evgenygunko/Translations
that referenced
this pull request
May 28, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [LaunchDarkly.ServerSdk](https://github.com/launchdarkly/dotnet-core) | `8.12.1` → `8.13.0` |  |  | --- ### Release Notes <details> <summary>launchdarkly/dotnet-core (LaunchDarkly.ServerSdk)</summary> ### [`v8.13.0`](https://github.com/launchdarkly/dotnet-core/releases/tag/LaunchDarkly.ServerSdk-v8.13.0): LaunchDarkly.ServerSdk: v8.13.0 [Compare Source](launchdarkly/dotnet-core@LaunchDarkly.ServerSdk-v8.12.2...LaunchDarkly.ServerSdk-v8.13.0) ##### Features - add X-LaunchDarkly-Instance-Id header ([#​258](launchdarkly/dotnet-core#258)) ([3c03ec4](launchdarkly/dotnet-core@3c03ec4)) *** This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> ### [`v8.12.2`](https://github.com/launchdarkly/dotnet-core/releases/tag/LaunchDarkly.ServerSdk-v8.12.2): LaunchDarkly.ServerSdk: v8.12.2 [Compare Source](launchdarkly/dotnet-core@LaunchDarkly.ServerSdk-v8.12.1...LaunchDarkly.ServerSdk-v8.12.2) ##### Bug Fixes - exclude documentation files from NuGet package builds ([#​263](launchdarkly/dotnet-core#263)) ([cc86ad6](launchdarkly/dotnet-core@cc86ad6)) - use basis query param for FDv2 polling selector ([#​260](launchdarkly/dotnet-core#260)) ([abaee9d](launchdarkly/dotnet-core@abaee9d)) *** This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or PR is renamed to start with "rebase!". 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Closes #261
Describe the solution you've provided
<Content>to<None>in all package.csprojfiles so they are not copied to consuming project bin folders.README.mdinto each NuGet package (with<PackageReadmeFile>and<PackagePath>\</PackagePath>) so it renders on the NuGet.org package page.<Pack>false</Pack>to exclude them from packages.README.mdfor the Telemetry package (which previously had none).Describe alternatives you've considered
Originally used
<Content>with<Pack>false</Pack>, but switched to<None>per NuGet best practices to avoid files being copied to consuming projects.Additional context
Reference: https://devblogs.microsoft.com/dotnet/add-a-readme-to-your-nuget-package/
Link to Devin session: https://app.devin.ai/sessions/9ab235b0b6af4361a2b4e9cec502b3f5
Requested by: @kinyoklion
Note
Low Risk
MSBuild/NuGet packaging-only changes; no SDK runtime, auth, or public API behavior is modified.
Overview
Across LaunchDarkly .NET SDK and integration packages, linked repo docs (
CHANGELOG,CONTRIBUTING,docfx.json,index.md, etc.) move from<Content>to<None>with<Pack>false</Pack>so they stay in the solution without being copied into consuming apps’ output or bundled into the.nupkg.README is wired for NuGet.org via
<PackageReadmeFile>README.md</PackageReadmeFile>plus a packedREADME.mdat the package root (<Pack>true</Pack>,<PackagePath>\</PackagePath>). Integration packages (Consul, DynamoDB, Redis) and Telemetry follow the same pattern; Telemetry also gains a newpkgs/telemetry/README.mdand packs it inLaunchDarkly.ServerSdk.Telemetry.csproj.Client SDK additionally stops packing
toc.yml(explicit<Pack>false</Pack>). No runtime or API code changes—only packaging metadata.Reviewed by Cursor Bugbot for commit cf34018. Bugbot is set up for automated code reviews on this repo. Configure here.