Skip to content

Commit 6ac887a

Browse files
authored
bump go to 1.24 (#166)
#159 is complaining about Go version used to build golangci-lint doesn't match target version. That PR updates the toolchain to use Go 1.24.1, but I believe golangci-lint is being built with one of the versions [here](https://github.com/actions/runner-images/blob/ubuntu24/20250427.1/images/ubuntu/Ubuntu2404-Readme.md#go) (likely `1.23.8`, based on the error message) which are included with the `ubuntu-latest` image we're [using](https://github.com/launchdarkly/find-code-references-in-pull-request/blob/main/.github/workflows/main.yml#L10). The `Set up Go` job pulls the Go version from our go.mod file, so I'm hoping moving that step above the pre-commit step will resolve this for us. Note: Also bumping to Go 1.24 here
1 parent 962b0be commit 6ac887a

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

.github/workflows/main.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,11 @@ jobs:
2525
with:
2626
python-version: '3.x'
2727

28+
- name: Set up Go
29+
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5
30+
with:
31+
go-version-file: go.mod
32+
2833
- name: Install pre-commit
2934
run: |
3035
python -m pip install --upgrade pip
@@ -33,11 +38,6 @@ jobs:
3338
- name: Run pre-commit hooks
3439
run: pre-commit run --all-files
3540

36-
- name: Set up Go
37-
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5
38-
with:
39-
go-version-file: go.mod
40-
4141
- name: Install dependencies
4242
run: go mod tidy
4343

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/launchdarkly/find-code-references-in-pull-request
22

3-
go 1.23.0
3+
go 1.24
44

55
require (
66
github.com/Masterminds/sprig/v3 v3.3.0

0 commit comments

Comments
 (0)