chore(deps): bump github.com/spf13/viper from 1.19.0 to 1.20.1#159
Closed
dependabot[bot] wants to merge 3 commits intomainfrom
Closed
chore(deps): bump github.com/spf13/viper from 1.19.0 to 1.20.1#159dependabot[bot] wants to merge 3 commits intomainfrom
dependabot[bot] wants to merge 3 commits intomainfrom
Conversation
Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.19.0 to 1.20.1. - [Release notes](https://github.com/spf13/viper/releases) - [Commits](spf13/viper@v1.19.0...v1.20.1) --- updated-dependencies: - dependency-name: github.com/spf13/viper dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
This was referenced May 13, 2025
Merged
blaqbern
added a commit
that referenced
this pull request
May 13, 2025
#159 is complaining about Go version used to build golangci-lint doesn't match target version. That PR updates the toolchain to use Go 1.24.1, but I believe golangci-lint is being built with one of the versions [here](https://github.com/actions/runner-images/blob/ubuntu24/20250427.1/images/ubuntu/Ubuntu2404-Readme.md#go) (likely `1.23.8`, based on the error message) which are included with the `ubuntu-latest` image we're [using](https://github.com/launchdarkly/find-code-references-in-pull-request/blob/main/.github/workflows/main.yml#L10). The `Set up Go` job pulls the Go version from our go.mod file, so I'm hoping moving that step above the pre-commit step will resolve this for us. Note: Also bumping to Go 1.24 here
blaqbern
added a commit
that referenced
this pull request
May 14, 2025
#159 attempts to bump `spf13/viper` from `1.19.0` to `1.20.1`, but there is a failing GHA because the `e2e-tests` job gets the diff of the PR from the GitHub API, and the diff is so huge that it exceeds the max number of lines that can be returned from the GET pull request endpoint (ripping out a bunch of unneeded code). So this PR bumps the version incrementally to `1.20.0-alpha.1` which accounts for roughly half the changes, and passes the `e2e-tests` job. We can then immediately upgrade from `1.20.0-alpha.1` to `1.20.1` and I believe that diff should be small enough as well. This means we'd be on an alpha version for a brief time, which is a bit dicey, but I think acceptable. In any event, I'm not sure how else we're going to get around this issue, unless we want to dig into what the test is doing and try to come up with an acceptable substitute, but that feels substantially riskier, actually. Thoughts?
Contributor
Contributor
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
Bot
deleted the
dependabot/go_modules/github.com/spf13/viper-1.20.1
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps github.com/spf13/viper from 1.19.0 to 1.20.1.
Release notes
Sourced from github.com/spf13/viper's releases.
... (truncated)
Commits
9568cfcfix: config type check when loading any configfd05140fix(config): get config type from v.configType or config file extc038295docs: add update instructions for 1.209c07e0fbuild: disable unused linters48112d6ci: add Go 1.24 to the test matrix66e3e28build(deps): bump github.com/spf13/pflag from 1.0.5 to 1.0.617b96acNew Logo8b223a4build(deps): bump github.com/spf13/cast from 1.7.0 to 1.7.191fd363chore: update aferoe75c48fFix issues reported by testifylintYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)