[REL-5292] Cblackburn/rel 5292/handle large diffs#172
Merged
Conversation
launchdarkly-upra
Bot
changed the title
monsagri
reviewed
Jun 9, 2025
monsagri
left a comment
monsagri
left a comment
Contributor
There was a problem hiding this comment.
This looks good in principle, but looks like you might need to update the docker image for the e2e-test action
> [8/8] RUN go build .:
0.664 main.go:5:2: package exec is not in std (/usr/local/go/src/exec)
monsagri
approved these changes
Jun 9, 2025
monsagri
left a comment
monsagri
left a comment
Contributor
There was a problem hiding this comment.
tests pass and it looks like it makes sense so lgtm!
This reverts commit 10722af.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fallback to normal
git diffif we get a 406 from the github api for too large a diff. I made a change that I know will result in a large diff to test that the test passes. I'll revert this once we're sure the fallback works.Related Jira issue: REL-5292: Code-Refs GHA should support large diffs