docs(readme): add note in README about creating the "ld-flags" label first#173
Closed
kallevmercury wants to merge 4 commits intolaunchdarkly:mainfrom
Closed
docs(readme): add note in README about creating the "ld-flags" label first#173kallevmercury wants to merge 4 commits intolaunchdarkly:mainfrom
kallevmercury wants to merge 4 commits intolaunchdarkly:mainfrom
Conversation
sloloris
approved these changes
Aug 19, 2025
Member
sloloris
left a comment
sloloris
left a comment
There was a problem hiding this comment.
Thank you so much @kallevmercury !
Contributor
|
I had to cherry-pick the commit to appease the end-to-end tests in #188. Thanks again for the contribution @kallevmercury and apologies for the delay in getting it merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor gotcha, but if you try to run the example Github action, it will break with "ld-flags does not exist" errors unless the Github label is created first.