fix: make LRUCache thread safe#26
Draft
honzap wants to merge 1 commit into
Draft
Conversation
Contributor
|
Hello @honzap, I saw @keelerm84 already replied to you in the GitHub issue, and he can help in looking at this contribution. Filed Internally as SDK-1099 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Describe the solution you've provided
We put LD libraries under the heavy load in production (>500M requests/24h) and the LRU cache starts panics, because it's not thread safe.
We're using the older version of library but the same code is there since a while.
Stack trace (at the bottom, there is a line 32 of lru_cache.go which produces a problem)
We think, there should be a
RWMutexaround that to avoid accessing invalid memory.Describe alternatives you've considered
No other options.
Additional context