ci: fix build by adding pod install and pipefail#61
Open
kinyoklion wants to merge 2 commits into
Open
Conversation
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
keelerm84
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CI build was silently failing for two reasons:
Missing
pod install: When the vendoredPods/directory was removed (commit 9a0eedb), apod installstep was never added to CI. The xcworkspace referencesPods/Pods.xcodeprojwhich doesn't exist without it.Missing
pipefail: Pipingxcodebuildtoxcprettywithoutset -o pipefailmeant the pipeline exit code came fromxcpretty(always 0), masking the build failure.Fixes both issues so CI correctly installs dependencies and reports failures.
Link to Devin session: https://app.devin.ai/sessions/5b1fe090ca3247c9a9e594a426c3a8ef
Requested by: @kinyoklion