refactor: address PR #173 review feedback (AIC-2663)

- Return the caller's default config (not a hard-disabled config) on AI Config
  mode mismatch, per the recent spec change; drop the now-unused disabledConfig
  helper and update the LDAIClient docs/test accordingly.
- Remove the unnecessary try/catch around the SDK-info trackMetric call in the
  constructor (the call cannot throw) and the test that only passed via a
  throwing mock.
- Use release-please block markers on the AISdkInfo VERSION line and register
  AISdkInfo.java in the package's extra-files so the version is actually bumped.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: ctawiah

lib/sdk/server-ai/src/main/java/com/launchdarkly/sdk/server/ai/LDAIClient.java

@@ -14,10 +14,10 @@
  * variables (and the evaluation context, exposed to templates as {@code ldctx}), and returns a
  * strongly-typed config.
  * <p>
- * When the flag is absent or cannot be evaluated, the caller-supplied default is returned as the
- * corresponding config type. When the variation's mode does not match the requested kind, a
- * disabled config of the requested type is returned and a warning is logged; a config is never
- * returned in a state that would force the caller into a {@code NullPointerException}.
+ * When the flag is absent, cannot be evaluated, or its mode does not match the requested kind, the
+ * caller-supplied default is returned as the corresponding config type (a warning is logged on a
+ * mode mismatch); a config is never returned in a state that would force the caller into a
+ * {@code NullPointerException}.
  * <p>
  * Implementations are thread-safe.
  */

lib/sdk/server-ai/src/main/java/com/launchdarkly/sdk/server/ai/LDAIClientImpl.java

@@ -78,18 +78,12 @@ public LDAIClientImpl(LDClientInterface client, LDLogger logger) {
     this.logger = Objects.requireNonNull(logger, "logger");
     this.interpolator = new Interpolator();
 
-    // Report SDK info once. Guard it: if the base client is not yet fully initialized, a track call
-    // must never propagate an exception out of this constructor.
-    try {
-      LDValue info = LDValue.buildObject()
-          .put("aiSdkName", AISdkInfo.NAME)
-          .put("aiSdkVersion", AISdkInfo.VERSION)
-          .put("aiSdkLanguage", AISdkInfo.LANGUAGE)
-          .build();
-      client.trackMetric(TRACK_SDK_INFO, INIT_TRACK_CONTEXT, info, 1);
-    } catch (Exception e) {
-      this.logger.warn("Unable to record AI SDK info event: {}", e.toString());
-    }
+    LDValue info = LDValue.buildObject()
+        .put("aiSdkName", AISdkInfo.NAME)
+        .put("aiSdkVersion", AISdkInfo.VERSION)
+        .put("aiSdkLanguage", AISdkInfo.LANGUAGE)
+        .build();
+    client.trackMetric(TRACK_SDK_INFO, INIT_TRACK_CONTEXT, info, 1);
   }
 
   @Override
@@ -178,9 +172,9 @@ private AIConfig evaluate(
     Mode flagMode = parsed.getMode() != null ? parsed.getMode() : Mode.COMPLETION;
     if (flagMode != mode) {
       logger.warn(
-          "AI Config mode mismatch for {}: expected {}, got {}. Returning disabled config.",
+          "AI Config mode mismatch for {}: expected {}, got {}. Returning default config.",
           key, mode.getWireValue(), flagMode.getWireValue());
-      return disabledConfig(key, mode);
+      return buildConfigFromDefault(key, mode, defaultValue, context, variables);
     }
 
     return buildConfig(key, mode, parsed, context, variables);
@@ -276,18 +270,6 @@ private AIConfig buildConfigFromDefault(
     }
   }
 
-  private AIConfig disabledConfig(String key, Mode mode) {
-    switch (mode) {
-      case AGENT:
-        return new AIAgentConfig(key, false, null, null, null, null, null, TRACKER_FACTORY);
-      case JUDGE:
-        return new AIJudgeConfig(key, false, null, null, null, null, TRACKER_FACTORY);
-      case COMPLETION:
-      default:
-        return new AICompletionConfig(key, false, null, null, null, null, null, TRACKER_FACTORY);
-    }
-  }
-
   private List<Message> interpolateMessages(
       List<Message> messages, Map<String, Object> variables, LDContext context) {
     if (messages == null) {

lib/sdk/server-ai/src/main/java/com/launchdarkly/sdk/server/ai/internal/AISdkInfo.java

@@ -25,8 +25,9 @@ public final class AISdkInfo {
    * lookup so that it resolves correctly in unit tests and when the classes are used outside the
    * packaged jar.
    */
-  // x-release-please-version
+  // x-release-please-start-version
   public static final String VERSION = "0.1.0";
+  // x-release-please-end
 
   private AISdkInfo() {
   }

lib/sdk/server-ai/src/test/java/com/launchdarkly/sdk/server/ai/LDAIClientImplTest.java

@@ -71,15 +71,6 @@ public void constructorEmitsSdkInfoEvent() {
     verify(client).trackMetric(eq("$ld:ai:sdk:info"), any(LDContext.class), eq(expected), eq(1.0));
   }
 
-  @Test
-  public void constructorDoesNotThrowWhenSdkInfoTrackingFails() {
-    LDClientInterface throwingClient = mock(LDClientInterface.class);
-    org.mockito.Mockito.doThrow(new RuntimeException("not initialized"))
-        .when(throwingClient).trackMetric(eq("$ld:ai:sdk:info"), any(), any(), eq(1.0));
-    // Must not propagate out of the constructor.
-    new LDAIClientImpl(throwingClient, logger);
-  }
-
   // ---- Usage events ---------------------------------------------------------
 
   @Test
@@ -174,18 +165,27 @@ public void judgeConfigResolvesFirstNonBlankEvaluationMetricKey() {
   // ---- Mode validation ------------------------------------------------------
 
   @Test
-  public void modeMismatchReturnsDisabledConfigAndWarnsOnce() {
+  public void modeMismatchReturnsDefaultConfigAndWarnsOnce() {
     String agentJson = "{\"_ldMeta\":{\"enabled\":true,\"mode\":\"agent\"},"
         + "\"instructions\":\"hi\"}";
     when(client.jsonValueVariation(anyString(), any(), any())).thenReturn(LDValue.parse(agentJson));
 
-    // Requesting a completion config against an agent-mode flag.
-    AICompletionConfig config = ai.completionConfig("key", context, null, null);
+    // Requesting a completion config against an agent-mode flag returns the caller's default.
+    AICompletionConfigDefault dflt = AICompletionConfigDefault.builder()
+        .enabled(true)
+        .model(Model.builder("default-model").build())
+        .messages(Arrays.asList(new Message(Message.Role.SYSTEM, "default {{x}}")))
+        .build();
+    Map<String, Object> variables = new HashMap<>();
+    variables.put("x", "value");
+
+    AICompletionConfig config = ai.completionConfig("key", context, dflt, variables);
 
     assertThat(config, is(notNullValue()));
-    assertThat(config.isEnabled(), is(false));
-    assertThat(config.getMessages(), is(nullValue()));
     assertThat(config.getMode(), is(Mode.COMPLETION));
+    assertThat(config.isEnabled(), is(true));
+    assertThat(config.getModel().getName(), is("default-model"));
+    assertThat(config.getMessages().get(0).getContent(), is("default value"));
     assertThat(warnings(), hasSize(1));
     assertThat(warnings().get(0), containsString("mode mismatch"));
   }