Skip to content

Commit 47d55c3

Browse files
committed
More PR feedback.
1 parent bc10b18 commit 47d55c3

3 files changed

Lines changed: 5 additions & 3 deletions

File tree

lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/DefaultFDv2Requestor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ public void onResponse(@Nonnull Call call, @Nonnull Response response) {
144144
FDv2PayloadResponse pollingResponse = new FDv2PayloadResponse(events, response.headers());
145145
future.complete(pollingResponse);
146146

147-
} catch (IOException | SerializationException e) {
147+
} catch (Exception e) {
148148
future.completeExceptionally(e);
149149
} finally {
150150
response.close();

lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/FDv2DataSource.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,9 +146,12 @@ private void runSynchronizers() {
146146
// TODO: We may need logging or to do a little more.
147147
return;
148148
case TERMINAL_ERROR:
149-
case GOODBYE:
149+
availableSynchronizer.block();
150150
running = false;
151151
break;
152+
case GOODBYE:
153+
// We let the synchronizer handle this internally.
154+
break;
152155
}
153156
break;
154157
}

lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/PollingSynchronizerImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ public PollingSynchronizerImpl(
3838
private void doPoll() {
3939
try {
4040
FDv2SourceResult res = poll(selectorSource.getSelector(), false).get();
41-
boolean shouldSignalShutDown = false;
4241
switch(res.getResultType()) {
4342
case CHANGE_SET:
4443
break;

0 commit comments

Comments
 (0)