ci: separating args for v3 from v2 contract tests (#139)

<!-- CURSOR_SUMMARY -->
> [!NOTE]
> **Low Risk**
> CI/Makefile wiring change only; main risk is misconfigured parameters
causing contract tests to run with missing/incorrect flags.
> 
> **Overview**
> Splits contract-test harness CLI arguments into **separate v2 and v3
inputs/vars** so v3-only flags don’t get passed to v2.
> 
> Updates the composite `contract-tests` GitHub Action and
`lib/sdk/server/Makefile` to use `TEST_HARNESS_PARAMS_V2` and
`TEST_HARNESS_PARAMS_V3`, and adjusts the nightly workflow to pass the
long-running flag only to v3.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
8fdee1d. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: tanderson-ld

.github/actions/contract-tests/action.yml

@@ -8,8 +8,12 @@ inputs:
     description: 'Github token, used for contract tests'
     required: false
     default: ''
-  test_harness_params:
-    description: 'Optional extra parameters for the SDK test harness (e.g. -enable-long-running-tests). Passed as TEST_HARNESS_PARAMS to make.'
+  test_harness_params_v2:
+    description: 'Optional extra parameters for the SDK test harness v2. Passed as TEST_HARNESS_PARAMS_V2 to make.'
+    required: false
+    default: ''
+  test_harness_params_v3:
+    description: 'Optional extra parameters for the SDK test harness v3 (e.g. -enable-long-running-tests). Passed as TEST_HARNESS_PARAMS_V3 to make.'
     required: false
     default: ''
 
@@ -18,4 +22,4 @@ runs:
   steps:
     - name: Run contract tests
       shell: bash
-      run: make contract-tests -C ${{ inputs.workspace_path }} TEST_HARNESS_PARAMS="${{ inputs.test_harness_params }}"
+      run: make contract-tests -C ${{ inputs.workspace_path }} TEST_HARNESS_PARAMS_V2="${{ inputs.test_harness_params_v2 }}" TEST_HARNESS_PARAMS_V3="${{ inputs.test_harness_params_v3 }}"

.github/workflows/nightly-contract-tests.yml

@@ -34,7 +34,7 @@ jobs:
         with:
           workspace_path: 'lib/sdk/server'
           token: ${{ secrets.GITHUB_TOKEN }}
-          test_harness_params: '-enable-long-running-tests'
+          test_harness_params_v3: '-enable-long-running-tests'
 
   notify-slack-on-failure:
     runs-on: ubuntu-latest

lib/sdk/server/Makefile

@@ -14,8 +14,9 @@ SUPPRESSION_FILE=contract-tests/test-suppressions.txt
 SUPPRESSION_FILE_FDV2=contract-tests/test-suppressions-fdv2.txt
 
 # Add any extra sdk-test-harness parameters here, such as -skip for tests that are
-# temporarily not working.
-TEST_HARNESS_PARAMS=
+# v2 and v3 params are separated because v3 supports additional parameters that v2 does not.
+TEST_HARNESS_PARAMS_V2=
+TEST_HARNESS_PARAMS_V3=
 
 build-contract-tests:
 	@cd contract-tests && ../gradlew installDist
@@ -30,10 +31,10 @@ start-contract-test-service-bg:
 run-contract-tests:
 	@echo "Running SDK contract test v2..."
 	@curl -s https://raw.githubusercontent.com/launchdarkly/sdk-test-harness/v2/downloader/run.sh \
-      | VERSION=v2 PARAMS="-url http://localhost:$(TEST_SERVICE_PORT) -debug -skip-from=$(SUPPRESSION_FILE) $(TEST_HARNESS_PARAMS)" sh
-	@echo "Running SDK contract test v3.0.0-alpha.1..."
+      | VERSION=v2 PARAMS="-url http://localhost:$(TEST_SERVICE_PORT) -debug -skip-from=$(SUPPRESSION_FILE) $(TEST_HARNESS_PARAMS_V2)" sh
+	@echo "Running SDK contract test v3..."
 	@curl -s https://raw.githubusercontent.com/launchdarkly/sdk-test-harness/v3.0.0-alpha.3/downloader/run.sh \
-      | VERSION=v3.0.0-alpha.3 PARAMS="-url http://localhost:$(TEST_SERVICE_PORT) -debug -stop-service-at-end -skip-from=$(SUPPRESSION_FILE_FDV2) $(TEST_HARNESS_PARAMS)" sh
+      | VERSION=v3.0.0-alpha.3 PARAMS="-url http://localhost:$(TEST_SERVICE_PORT) -debug -stop-service-at-end -skip-from=$(SUPPRESSION_FILE_FDV2) $(TEST_HARNESS_PARAMS_V3)" sh
 
 contract-tests: build-contract-tests start-contract-test-service-bg run-contract-tests