Skip to content

Commit a14beb9

Browse files
authored
feat: commonizes several FDv2 related types in Internal (#141)
Moves Selector into Common and updates a couple imports to use it. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Upgrades `launchdarkly-java-sdk-common` and relocates the FDv2 `Selector` type, which can cause compile-time breaks for any code still importing the internal package and may subtly change semantics via the common implementation. > > **Overview** > FDv2 now uses the shared `com.launchdarkly.sdk.fdv2.Selector` type: internal FDv2 sources (`FDv2ChangeSet`, `FDv2ProtocolHandler`) update imports accordingly and the old `internal.fdv2.sources.Selector` class is removed. > > Also bumps the `launchdarkly-java-sdk-common` dependency from `2.1.2` to `2.4.0` to supply the commonized FDv2 types. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit f478282. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> BEGIN_COMMIT_OVERRIDE feat: commonizes several FDv2 related types END_COMMIT_OVERRIDE
1 parent 73af552 commit a14beb9

4 files changed

Lines changed: 3 additions & 66 deletions

File tree

lib/shared/internal/buildSrc/src/main/kotlin/Dependencies.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
object Versions {
66
const val gson = "2.13.1"
7-
const val launchdarklyJavaSdkCommon = "2.1.2"
7+
const val launchdarklyJavaSdkCommon = "2.4.0"
88
const val launchdarklyLogging = "1.1.1"
99
const val okhttp = "4.12.0"
1010
const val testHelpers = "1.2.0"

lib/shared/internal/src/main/java/com/launchdarkly/sdk/internal/fdv2/sources/FDv2ChangeSet.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.launchdarkly.sdk.internal.fdv2.sources;
22

33
import com.google.gson.JsonElement;
4+
import com.launchdarkly.sdk.fdv2.Selector;
45

56
import java.util.Collections;
67
import java.util.List;

lib/shared/internal/src/main/java/com/launchdarkly/sdk/internal/fdv2/sources/FDv2ProtocolHandler.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.launchdarkly.sdk.internal.fdv2.sources;
22

3+
import com.launchdarkly.sdk.fdv2.Selector;
34
import com.launchdarkly.sdk.internal.fdv2.payloads.DeleteObject;
45
import com.launchdarkly.sdk.internal.fdv2.payloads.Error;
56
import com.launchdarkly.sdk.internal.fdv2.payloads.FDv2Event;

lib/shared/internal/src/main/java/com/launchdarkly/sdk/internal/fdv2/sources/Selector.java

Lines changed: 0 additions & 65 deletions
This file was deleted.

0 commit comments

Comments
 (0)