Skip to content

Commit b20c621

Browse files
committed
Cleanup
1 parent bd15015 commit b20c621

2 files changed

Lines changed: 1 addition & 7 deletions

File tree

lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/DefaultFDv2Requestor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ public void onFailure(@Nonnull Call call, @Nonnull IOException e) {
111111
@Override
112112
public void onResponse(@Nonnull Call call, @Nonnull Response response) {
113113
try {
114-
// Handle 304 Not Modified - no new data, but return response with headers
114+
// Handle 304 Not Modified - no new data
115115
if (response.code() == 304) {
116116
logger.debug("FDv2 polling request returned 304: not modified");
117117
future.complete(FDv2PayloadResponse.none(response.code()));

lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/PollingBase.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import com.launchdarkly.sdk.internal.fdv2.payloads.FDv2Event;
55
import com.launchdarkly.sdk.internal.fdv2.sources.FDv2ProtocolHandler;
66
import com.launchdarkly.sdk.internal.fdv2.sources.Selector;
7-
import com.launchdarkly.sdk.internal.http.HttpErrors;
87
import com.launchdarkly.sdk.server.datasources.FDv2SourceResult;
98
import com.launchdarkly.sdk.server.interfaces.DataSourceStatusProvider;
109
import com.launchdarkly.sdk.server.subsystems.DataStoreTypes;
@@ -34,11 +33,6 @@ private static boolean getFallback(FDv2Requestor.FDv2PayloadResponse response) {
3433
String headerValue = response.getHeaders().get(HeaderConstants.FDV1_FALLBACK.getHeaderName());
3534
return headerValue != null && headerValue.equalsIgnoreCase("true");
3635
}
37-
// if(ex != null) {
38-
// if(ex instanceof HttpErrorException) {
39-
// ((HttpErrors.HttpErrorException) ex).
40-
// }
41-
// }
4236

4337
return false;
4438
}

0 commit comments

Comments
 (0)