Commit d4faba1
authored
feat: expose sslSocketFactory, sslParameters, and hostnameVerifier on RedisStoreBuilder (#182)
**Expose SSL configuration options on RedisStoreBuilder**
The JedisPool constructor accepts sslSocketFactory, sslParameters, and
hostnameVerifier for customizing TLS behaviour, but all three were
hardcoded to null in RedisStoreImplBase, making them unreachable by
callers.
This PR exposes all three as builder options on RedisStoreBuilder.
**Changes**
- Added sslSocketFactory(SSLSocketFactory),
sslParameters(SSLParameters), and hostnameVerifier(HostnameVerifier)
methods to RedisStoreBuilder
- Wired the new fields through to the JedisPool constructor in
RedisStoreImplBase
- All three are no-ops when TLS is not enabled
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Changes affect how TLS Redis connections are established;
misconfigured custom SSL or hostname verification could weaken security,
though behavior is unchanged unless callers opt in.
>
> **Overview**
> **RedisStoreBuilder** now lets callers pass **SSLSocketFactory**,
**SSLParameters**, and **HostnameVerifier** for TLS Redis connections,
matching what **JedisPool** already supports.
>
> Previously **RedisStoreImplBase** always passed `null` for those three
constructor arguments, so custom trust stores, cipher suites, or
hostname checks were impossible without forking. The new builder fields
are forwarded into **JedisPool**; when TLS is off they are documented as
ignored, and unset values still defer to JVM defaults.
>
> Unit tests cover default nulls and that each setter stores the
configured instance.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
86fa0cb. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 9a9941b commit d4faba1
3 files changed
Lines changed: 87 additions & 5 deletions
File tree
- lib/java-server-sdk-redis-store/src
- main/java/com/launchdarkly/sdk/server/integrations
- test/java/com/launchdarkly/sdk/server/integrations
Lines changed: 54 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
14 | 18 | | |
15 | 19 | | |
16 | 20 | | |
| |||
56 | 60 | | |
57 | 61 | | |
58 | 62 | | |
59 | | - | |
| 63 | + | |
60 | 64 | | |
61 | 65 | | |
62 | 66 | | |
| |||
80 | 84 | | |
81 | 85 | | |
82 | 86 | | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
83 | 90 | | |
84 | 91 | | |
85 | 92 | | |
| |||
146 | 153 | | |
147 | 154 | | |
148 | 155 | | |
149 | | - | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
150 | 202 | | |
151 | 203 | | |
152 | 204 | | |
| |||
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
| |||
50 | 51 | | |
51 | 52 | | |
52 | 53 | | |
53 | | - | |
54 | | - | |
55 | | - | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
56 | 57 | | |
57 | 58 | | |
58 | 59 | | |
| |||
Lines changed: 29 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
14 | 19 | | |
15 | 20 | | |
16 | 21 | | |
| |||
23 | 28 | | |
24 | 29 | | |
25 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
26 | 34 | | |
27 | 35 | | |
28 | 36 | | |
| |||
53 | 61 | | |
54 | 62 | | |
55 | 63 | | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
56 | 85 | | |
57 | 86 | | |
58 | 87 | | |
| |||
0 commit comments