Skip to content

chore: Add support for FDv2 fallback and recovery. #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kinyoklion merged 19 commits into from
Jan 27, 2026
Merged

chore: Add support for FDv2 fallback and recovery. #113

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
08abc7e
chore: Pipe headers through data sources.
kinyoklion Jan 21, 2026
bd15015
Merge branch 'main' into rlamb/connect-headers-to-data-sources
kinyoklion Jan 21, 2026
b20c621
Cleanup
kinyoklion Jan 21, 2026
b46ac5e
chore: Add fallback and recovery support for FDv2.
kinyoklion Jan 23, 2026
fba5aa2
Extract conditions from FDv2DataSource.
kinyoklion Jan 23, 2026
472a1d2
Extract synchronizer state management from the FDv2DataSource.
kinyoklion Jan 23, 2026
0c150a1
Add recovery condition tests.
kinyoklion Jan 23, 2026
5888761
Merge branch 'main' into rlamb/fallback-and-recovery
kinyoklion Jan 26, 2026
9e79c00
Merge branch 'rlamb/fallback-and-recovery' of github.com:launchdarkly…
kinyoklion Jan 26, 2026
33fa6c5
Closeable synchronizer state manager.
kinyoklion Jan 26, 2026
ec0d0ec
More clean shutdown model.
kinyoklion Jan 26, 2026
5b62238
SynchronizerStateManager tests.
kinyoklion Jan 26, 2026
53ea319
FDv2DataSource tests.
kinyoklion Jan 26, 2026
147556d
Add documentation to long-running test.
kinyoklion Jan 26, 2026
321fb4f
Fix test expectations.
kinyoklion Jan 26, 2026
1234bc9
Remove un-needed synchronizer.
kinyoklion Jan 27, 2026
10cab33
Correct lock on getNextAvailableSynchronizer.
kinyoklion Jan 27, 2026
382246d
PR Feedback.
kinyoklion Jan 27, 2026
e6b032e
Correct prime synchronizer logic.
kinyoklion Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/sdk/server/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ ext.versions = [
"launchdarklyJavaSdkInternal": "1.6.1",
"launchdarklyLogging": "1.1.0",
"okhttp": "4.12.0", // specify this for the SDK build instead of relying on the transitive dependency from okhttp-eventsource
"okhttpEventsource": "4.1.0",
"okhttpEventsource": "4.2.0",
"reactorCore":"3.3.22.RELEASE",
"slf4j": "1.7.36",
"snakeyaml": "2.4",
Expand Down
10 changes: 3 additions & 7 deletions lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/DefaultFDv2Requestor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,8 @@
import com.launchdarkly.logging.LDLogger;
import com.launchdarkly.sdk.internal.fdv2.payloads.FDv2Event;
import com.launchdarkly.sdk.internal.fdv2.sources.Selector;
import com.launchdarkly.sdk.internal.http.HttpErrors;
import com.launchdarkly.sdk.internal.http.HttpHelpers;
import com.launchdarkly.sdk.internal.http.HttpProperties;
import com.launchdarkly.sdk.json.SerializationException;

import okhttp3.Call;
import okhttp3.Callback;
Expand Down Expand Up @@ -116,14 +114,12 @@ public void onResponse(@Nonnull Call call, @Nonnull Response response) {
// Handle 304 Not Modified - no new data
if (response.code() == 304) {
logger.debug("FDv2 polling request returned 304: not modified");
future.complete(null);
future.complete(FDv2PayloadResponse.none(response.code()));
return;
}

if (!response.isSuccessful()) {
future.completeExceptionally(
new HttpErrors.HttpErrorException(response.code())
);
future.complete(FDv2PayloadResponse.failure(response.code(), response.headers()));
return;
}

Expand All @@ -145,7 +141,7 @@ public void onResponse(@Nonnull Call call, @Nonnull Response response) {
List<FDv2Event> events = FDv2Event.parseEventsArray(responseBody);

// Create and return the response
FDv2PayloadResponse pollingResponse = new FDv2PayloadResponse(events, response.headers());
FDv2PayloadResponse pollingResponse = FDv2PayloadResponse.success(events, response.headers(), response.code());
future.complete(pollingResponse);

} catch (Exception e) {
Expand Down
Loading