chore: PR comments

Author: joker23

packages/sdk/browser/__tests__/BrowserClient.test.ts

@@ -246,31 +246,6 @@ describe('given a mock platform for a BrowserClient', () => {
     expect(client.getContext()).toEqual({ kind: 'user', key: 'bob' });
   });
 
-  it('parses bootstrap data when start is called with bootstrap', async () => {
-    const client = makeClient(
-      'client-side-id',
-      { kind: 'user', key: 'bob' },
-      AutoEnvAttributes.Disabled,
-      {
-        streaming: false,
-        logger,
-        diagnosticOptOut: true,
-      },
-      platform,
-    );
-
-    await client.start({
-      identifyOptions: {
-        bootstrap: goodBootstrapDataWithReasons,
-      },
-    });
-
-    // Verify that bootstrap data was parsed and flags are available.
-    expect(client.allFlags().killswitch).toBe(true);
-    expect(client.allFlags()['string-flag']).toBe('is bob');
-    expect(client.allFlags().cat).toBe(false);
-  });
-
   it('uses the latest bootstrap data when identify is called with new bootstrap data', async () => {
     const initialBootstrapData = {
       'string-flag': 'is bob',

packages/shared/sdk-client/__tests__/LDClientImpl.start.test.ts

@@ -1,6 +1,7 @@
 import { AutoEnvAttributes, clone, Hasher, LDLogger } from '@launchdarkly/js-sdk-common';
 
 import { LDContext } from '../src/api/LDContext';
+import * as bootstrapModule from '../src/flag-manager/bootstrap';
 import LDClientImpl from '../src/LDClientImpl';
 import { Flags } from '../src/types';
 import { createBasicPlatform } from './createBasicPlatform';
@@ -223,6 +224,26 @@ describe('LDClientImpl.start()', () => {
       expect(flags['other-flag']).toBe(true);
       expect(flags.killswitch).toBeUndefined();
     });
+
+    it('parses bootstrap data only once when using start()', async () => {
+      const readFlagsFromBootstrapSpy = jest.spyOn(bootstrapModule, 'readFlagsFromBootstrap');
+
+      const mockPlatform = createBasicPlatform();
+      const { ldc } = setupClient(mockPlatform, { disableNetwork: true });
+      ldc.setInitialContext(context);
+
+      await ldc.start({
+        identifyOptions: { bootstrap: goodBootstrapDataWithReasons },
+      });
+
+      expect(readFlagsFromBootstrapSpy).toHaveBeenCalledTimes(1);
+      expect(readFlagsFromBootstrapSpy).toHaveBeenCalledWith(
+        expect.anything(),
+        goodBootstrapDataWithReasons,
+      );
+
+      readFlagsFromBootstrapSpy.mockRestore();
+    });
   });
 
   describe('requiresStart guard', () => {