chore: reverting sheddable defaults

Author: joker23

packages/sdk/browser/src/BrowserClient.ts

@@ -238,7 +238,11 @@ class BrowserClientImpl extends LDClientImpl {
     context: LDContext,
     identifyOptions?: LDIdentifyOptions,
   ): Promise<LDIdentifyResult> {
-    const res = await super.identifyResult(context, identifyOptions);
+    const options =
+      identifyOptions?.sheddable === undefined
+        ? { ...identifyOptions, sheddable: true }
+        : identifyOptions;
+    const res = await super.identifyResult(context, options);
     // Ensure that we do not start the goal manager if start() is not called.
     if (this.startPromise) {
       this._goalManager?.startTracking();

packages/sdk/electron/src/ElectronClient.ts

@@ -17,6 +17,7 @@ import {
   LDFlagValue,
   LDHeaders,
   LDIdentifyOptions,
+  LDIdentifyResult,
   LDPluginEnvironmentMetadata,
   LDWaitForInitializationOptions,
   LDWaitForInitializationResult,
@@ -136,6 +137,17 @@ export class ElectronClient extends LDClientImpl {
     internal.safeRegisterPlugins(this.logger, this.environmentMetadata, client, this._plugins);
   }
 
+  override async identifyResult(
+    context: LDContext,
+    identifyOptions?: LDIdentifyOptions,
+  ): Promise<LDIdentifyResult> {
+    const options =
+      identifyOptions?.sheddable === undefined
+        ? { ...identifyOptions, sheddable: true }
+        : identifyOptions;
+    return super.identifyResult(context, options);
+  }
+
   async setConnectionMode(mode: ConnectionMode): Promise<void> {
     if (mode === 'offline') {
       this.setEventSendingEnabled(false, true);

packages/shared/sdk-client/__tests__/LDClientImpl.start.test.ts

@@ -275,7 +275,7 @@ describe('LDClientImpl.start()', () => {
       expect(result.status).toBe('completed');
     });
 
-    it('defaults sheddable to true for post-start identifies when requiresStart is true', async () => {
+    it('defaults sheddable to false for identifies in the base class', async () => {
       const mockPlatform = setupStreamingPlatform();
       const { ldc } = setupClient(mockPlatform, { requiresStart: true, initialContext: context });
 
@@ -292,21 +292,6 @@ describe('LDClientImpl.start()', () => {
       ]);
 
       expect(startResult.status).toBe('complete');
-      expect(result1.status).toBe('shed');
-      expect(result2.status).toBe('shed');
-      expect(result3.status).toBe('completed');
-    });
-
-    it('does not default sheddable when requiresStart is false', async () => {
-      const mockPlatform = setupStreamingPlatform();
-      const { ldc } = setupClient(mockPlatform, { requiresStart: false });
-
-      const promise1 = ldc.identifyResult({ kind: 'user', key: 'user-1' });
-      const promise2 = ldc.identifyResult({ kind: 'user', key: 'user-2' });
-      const promise3 = ldc.identifyResult({ kind: 'user', key: 'user-3' });
-
-      const [result1, result2, result3] = await Promise.all([promise1, promise2, promise3]);
-
       expect(result1.status).toBe('completed');
       expect(result2.status).toBe('completed');
       expect(result3.status).toBe('completed');

packages/shared/sdk-client/src/LDClientImpl.ts

@@ -381,14 +381,8 @@ export default class LDClientImpl implements LDClient, LDClientIdentifyResult {
       return { status: 'error', error: new Error('Identify called before start') };
     }
 
-    let effectiveOptions = identifyOptions;
-    if (this._requiresStart && identifyOptions?.sheddable === undefined) {
-      effectiveOptions = { ...identifyOptions, sheddable: true };
-    }
-
-    const identifyTimeout = effectiveOptions?.timeout ?? DEFAULT_IDENTIFY_TIMEOUT_SECONDS;
-    const noTimeout =
-      effectiveOptions?.timeout === undefined && effectiveOptions?.noTimeout === true;
+    const identifyTimeout = identifyOptions?.timeout ?? DEFAULT_IDENTIFY_TIMEOUT_SECONDS;
+    const noTimeout = identifyOptions?.timeout === undefined && identifyOptions?.noTimeout === true;
 
     // When noTimeout is specified, and a timeout is not specified, then this condition cannot
     // be encountered. (Our default would need to be greater)
@@ -410,7 +404,7 @@ export default class LDClientImpl implements LDClient, LDClientIdentifyResult {
             }
             const checkedContext = Context.fromLDContext(context);
             if (checkedContext.valid) {
-              const afterIdentify = this._hookRunner.identify(context, effectiveOptions?.timeout);
+              const afterIdentify = this._hookRunner.identify(context, identifyOptions?.timeout);
               return {
                 context,
                 checkedContext,
@@ -443,7 +437,7 @@ export default class LDClientImpl implements LDClient, LDClientIdentifyResult {
               identifyResolve,
               identifyReject,
               checkedContext,
-              effectiveOptions,
+              identifyOptions,
             );
 
             return identifyPromise;
@@ -458,7 +452,7 @@ export default class LDClientImpl implements LDClient, LDClientIdentifyResult {
             }
           },
         },
-        effectiveOptions?.sheddable ?? false,
+        identifyOptions?.sheddable ?? false,
       )
       .then((res) => {
         if (res.status === 'error') {