fix: Accept eventsUri option in Fastly SDK init() (#1791)

Author: keelerm84

packages/sdk/fastly/__tests__/index.test.ts

@@ -39,6 +39,19 @@ describe('init', () => {
     ldClient.close();
   });
 
+  it('does not throw when initialized with a custom eventsUri', () => {
+    let client: LDClient | undefined;
+    expect(() => {
+      client = init(sdkKey, mockKVStore, {
+        eventsUri: 'https://custom-events.example.com',
+        eventsBackendName: 'custom-backend',
+      });
+    }).not.toThrow();
+    // Close the client so its event processor's flush timer does not keep the
+    // runtime (and the jest process) alive.
+    client?.close();
+  });
+
   describe('flag tests', () => {
     it('evaluates a boolean flag with a variation call', async () => {
       const value = await ldClient.variation(flagKey1, context, false);

packages/sdk/fastly/__tests__/utils/validateOptions.test.ts

@@ -32,6 +32,18 @@ describe('validateOptions', () => {
     ).toBeTruthy();
   });
 
+  test('success with eventsUri and eventsBackendName', () => {
+    expect(
+      validateOptions('test-sdk-key', {
+        featureStore: mockFeatureStore,
+        logger: BasicLogger.get(),
+        sendEvents: true,
+        eventsUri: 'https://custom-events.example.com',
+        eventsBackendName: 'custom-backend',
+      }),
+    ).toBeTruthy();
+  });
+
   test('throws with invalid options', () => {
     expect(() => {
       validateOptions('test-sdk-key', {

packages/sdk/fastly/src/utils/validateOptions.ts

@@ -24,7 +24,7 @@ const validators = {
 };
 
 const validateOptions = (clientSideId: string, options: LDOptionsInternal) => {
-  const { eventsBackendName, featureStore, logger, sendEvents, ...rest } = options;
+  const { eventsBackendName, eventsUri, featureStore, logger, sendEvents, ...rest } = options;
   if (!clientSideId || !validators.clientSideId.is(clientSideId)) {
     throw new Error('You must configure the client with a client-side id');
   }
@@ -37,8 +37,9 @@ const validateOptions = (clientSideId: string, options: LDOptionsInternal) => {
     throw new Error('You must configure the client with a logger');
   }
 
-  if (JSON.stringify(rest) !== '{}') {
-    throw new Error(`Invalid configuration: ${Object.keys(rest).toString()} not supported`);
+  const unsupported = Object.keys(rest);
+  if (unsupported.length !== 0) {
+    throw new Error(`Invalid configuration: ${unsupported.toString()} not supported`);
   }
 
   return true;