Skip to content

Commit 1aa98fc

Browse files
committed
ci: consolidate test harness adapter server
1 parent b39f048 commit 1aa98fc

21 files changed

Lines changed: 117 additions & 222 deletions

File tree

.github/workflows/browser.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ jobs:
5151
run: yarn workspace browser-contract-test-service install-playwright-browsers
5252

5353
- name: Build shared contract test utils
54-
run: yarn workspace @launchdarkly/js-contract-test-utils build:client
54+
run: yarn workspace @launchdarkly/js-contract-test-utils build
5555

5656
- name: Build contract test adapter
5757
run: yarn workspace browser-contract-test-adapter run build
@@ -130,7 +130,7 @@ jobs:
130130
[ -f /tmp/adapter.pid ] && kill $(cat /tmp/adapter.pid) || true
131131
pkill -f "playwright" || true
132132
pkill -f "http-server" || true
133-
pkill -f "browser-contract-test-adapter" || true
133+
pkill -f "sdk-testharness-server" || true
134134
135135
run-example:
136136
runs-on: ubuntu-latest

.github/workflows/react-native-contract-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
run: yarn workspaces foreach -pR --topological-dev --from '@launchdarkly/react-native-client-sdk' run build
3535

3636
- name: Build shared contract test utils
37-
run: yarn workspace @launchdarkly/js-contract-test-utils build:client
37+
run: yarn workspace @launchdarkly/js-contract-test-utils build
3838

3939
- name: Build contract test adapter
4040
run: yarn workspace react-native-contract-test-adapter run build

packages/sdk/browser/contract-tests/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ This directory contains the contract test implementation for the LaunchDarkly Br
66

77
The browser contract tests consist of three components:
88

9-
1. **Adapter** (`adapter/`): A Node.js server that:
9+
1. **Adapter** (`adapter/`): A thin wrapper that delegates to the `sdk-testharness-server adapter` CLI from `@launchdarkly/js-contract-test-utils`. The adapter:
1010
- Exposes a REST API on port 8000 for the test harness
1111
- Runs a WebSocket server on port 8001 for browser communication
1212
- Translates REST commands to WebSocket messages
Lines changed: 6 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,13 @@
11
{
22
"name": "browser-contract-test-adapter",
33
"version": "1.0.0",
4-
"description": "Adapts REST interface to a websocket for use in browsers.",
5-
"main": "dist/index.js",
6-
"scripts": {
7-
"build": "tsc",
8-
"start": "yarn build && node dist/index.js",
9-
"lint": "eslint ./src",
10-
"prettier": "prettier --write '**/*.@(js|ts|tsx|json|css)' --ignore-path ../../../../.prettierignore"
11-
},
12-
"author": "",
13-
"license": "UNLICENSED",
4+
"private": true,
5+
"description": "Starts the contract test adapter for browser/react.",
146
"dependencies": {
15-
"body-parser": "^1.20.3",
16-
"cors": "^2.8.5",
17-
"express": "^4.21.0",
18-
"ws": "^8.18.0"
7+
"@launchdarkly/js-contract-test-utils": "workspace:^"
198
},
20-
"devDependencies": {
21-
"@eslint/js": "^9.10.0",
22-
"@trivago/prettier-plugin-sort-imports": "^4.1.1",
23-
"@types/cors": "^2.8.17",
24-
"@types/express": "^4.17.21",
25-
"@types/ws": "^8.5.12",
26-
"@typescript-eslint/eslint-plugin": "^6.20.0",
27-
"@typescript-eslint/parser": "^6.20.0",
28-
"eslint": "^8.45.0",
29-
"eslint-config-airbnb-base": "^15.0.0",
30-
"eslint-config-airbnb-typescript": "^17.1.0",
31-
"eslint-config-prettier": "^8.8.0",
32-
"eslint-plugin-import": "^2.27.5",
33-
"eslint-plugin-jest": "^27.6.3",
34-
"eslint-plugin-prettier": "^5.0.0",
35-
"globals": "^15.9.0",
36-
"prettier": "^3.0.0",
37-
"typescript": "^5.6.2",
38-
"typescript-eslint": "^8.5.0"
9+
"scripts": {
10+
"build": "echo 'no-op'",
11+
"start": "sdk-testharness-server adapter"
3912
}
4013
}

packages/sdk/browser/contract-tests/adapter/tsconfig.eslint.json

Lines changed: 0 additions & 5 deletions
This file was deleted.

packages/sdk/browser/contract-tests/adapter/tsconfig.json

Lines changed: 0 additions & 15 deletions
This file was deleted.

packages/sdk/browser/contract-tests/adapter/tsconfig.ref.json

Lines changed: 0 additions & 7 deletions
This file was deleted.
Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,13 @@
11
{
22
"name": "react-native-contract-test-adapter",
33
"version": "1.0.0",
4-
"description": "Adapts REST interface to a websocket for use in React Native.",
5-
"main": "dist/index.js",
6-
"scripts": {
7-
"build": "tsc",
8-
"start": "yarn build && node dist/index.js"
9-
},
10-
"author": "",
11-
"license": "UNLICENSED",
4+
"private": true,
5+
"description": "Starts the contract test adapter for React Native.",
126
"dependencies": {
13-
"body-parser": "^1.20.3",
14-
"cors": "^2.8.5",
15-
"express": "^4.21.0",
16-
"ws": "^8.18.0"
7+
"@launchdarkly/js-contract-test-utils": "workspace:^"
178
},
18-
"devDependencies": {
19-
"@types/cors": "^2.8.17",
20-
"@types/express": "^4.17.21",
21-
"@types/ws": "^8.5.12",
22-
"typescript": "^5.6.2"
9+
"scripts": {
10+
"build": "echo 'no-op'",
11+
"start": "sdk-testharness-server adapter"
2312
}
2413
}

packages/sdk/react-native/contract-tests/adapter/src/index.ts

Lines changed: 0 additions & 112 deletions
This file was deleted.

packages/sdk/react-native/contract-tests/adapter/tsconfig.json

Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
 (0)