Skip to content

Commit 40c36f5

Browse files
authored
fix(electron): correcting package.json versions (#1267)
<!-- CURSOR_SUMMARY --> > [!NOTE] > **Medium Risk** > Adjusts `peerDependencies` for Electron packages, which can change install-time compatibility for consumers using older Electron versions. No runtime logic changes, but dependency resolution/build pipelines may be affected. > > **Overview** > Updates Electron package manifests to better reflect supported Electron versions. > > `@launchdarkly/electron-client-sdk` now declares an Electron peer requirement of `>=34.5.6` (instead of `*`), and the `example` and `contract-tests` packages add explicit `peerDependencies` matching their Electron devDependency versions. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 6e1f307. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 584e461 commit 40c36f5

3 files changed

Lines changed: 7 additions & 1 deletion

File tree

packages/sdk/electron/contract-tests/entity/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@
3131
"typescript": "~4.5.4",
3232
"vite": "^5.4.21"
3333
},
34+
"peerDependencies": {
35+
"electron": "^40.2.1"
36+
},
3437
"dependencies": {
3538
"@launchdarkly/js-contract-test-utils": "workspace:^",
3639
"body-parser": "^2.2.2",

packages/sdk/electron/example/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@
3434
"typescript": "~4.5.4",
3535
"vite": "^5.4.21"
3636
},
37+
"peerDependencies": {
38+
"electron": "^40.4.1"
39+
},
3740
"dependencies": {
3841
"@launchdarkly/electron-client-sdk": "0.0.1",
3942
"electron-squirrel-startup": "^1.0.1"

packages/sdk/electron/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
"test": "jest"
5050
},
5151
"peerDependencies": {
52-
"electron": "*"
52+
"electron": ">=34.5.6"
5353
},
5454
"dependencies": {
5555
"@launchdarkly/js-client-sdk-common": "workspace:^",

0 commit comments

Comments
 (0)