chore: remove stale eslint-disable comments

joker23 · claude · joker23 · commit 5526f0a275d4 · 2026-04-21T11:53:42.000-05:00
Remove ~65 eslint-disable comments for rules that no longer exist after
replacing eslint-config-airbnb-base with eslint:recommended:

- no-param-reassign (43 comments)
- no-bitwise (10 comments)
- no-restricted-syntax for ForOfStatement (11 comments)
- no-plusplus (4 comments)
- no-continue (1 comment)

Retains a targeted no-restricted-syntax disable in vendor TraceKit.ts
for a legitimate for...in loop.

No functional code changes.

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/packages/sdk/browser/__tests__/platform/randomUuidV4.test.ts b/packages/sdk/browser/__tests__/platform/randomUuidV4.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-bitwise */
 import { fallbackUuidV4, formatDataAsUuidV4 } from '../../src/platform/randomUuidV4';
 
 it('formats conformant UUID', () => {
diff --git a/packages/sdk/browser/tsup.config.ts b/packages/sdk/browser/tsup.config.ts
@@ -20,7 +20,6 @@ export default defineConfig({
     // So start of line followed by a character that isn't followed by m or underscore, but we
     // want other things that do start with m, so we need to progressively handle more characters
     // of meta with exclusions.
-    // eslint-disable-next-line no-param-reassign
     opts.mangleProps = /^_([^m|_]|m[^e]|me[^t]|met[^a])/;
   },
 });
diff --git a/packages/sdk/combined-browser/tsup.config.ts b/packages/sdk/combined-browser/tsup.config.ts
@@ -26,7 +26,6 @@ export default defineConfig({
     // So start of line followed by a character that isn't followed by m or underscore, but we
     // want other things that do start with m, so we need to progressively handle more characters
     // of meta with exclusions.
-    // eslint-disable-next-line no-param-reassign
     opts.mangleProps = /^_([^m|_]|m[^e]|me[^t]|met[^a])/;
   },
 });
diff --git a/packages/sdk/electron/__tests__/platform/HeaderWrapper.test.ts b/packages/sdk/electron/__tests__/platform/HeaderWrapper.test.ts
@@ -1,5 +1,3 @@
-/* eslint-disable no-restricted-syntax */
-// The header interface uses generators, so we are using restricted-syntax.
 import * as http from 'http';
 
 import HeaderWrapper from '../../src/platform/HeaderWrapper';
diff --git a/packages/sdk/electron/src/ElectronClient.ts b/packages/sdk/electron/src/ElectronClient.ts
@@ -201,24 +201,20 @@ export class ElectronClient extends LDClientImpl {
     );
 
     ipcMain.on(getIPCChannelName(namespace, 'allFlags'), (event) => {
-      // eslint-disable-next-line no-param-reassign
       event.returnValue = this.allFlags();
     });
 
     ipcMain.on(getIPCChannelName(namespace, 'boolVariation'), (event, key, defaultValue) => {
-      // eslint-disable-next-line no-param-reassign
       event.returnValue = this.boolVariation(key, defaultValue);
     });
 
     ipcMain.on(getIPCChannelName(namespace, 'boolVariationDetail'), (event, key, defaultValue) => {
-      // eslint-disable-next-line no-param-reassign
       event.returnValue = this.boolVariationDetail(key, defaultValue);
     });
 
     ipcMain.handle(getIPCChannelName(namespace, 'flush'), (_event) => this.flush());
 
     ipcMain.on(getIPCChannelName(namespace, 'getContext'), (event) => {
-      // eslint-disable-next-line no-param-reassign
       event.returnValue = this.getContext();
     });
 
@@ -233,53 +229,44 @@ export class ElectronClient extends LDClientImpl {
     });
 
     ipcMain.on(getIPCChannelName(namespace, 'jsonVariation'), (event, key, defaultValue) => {
-      // eslint-disable-next-line no-param-reassign
       event.returnValue = this.jsonVariation(key, defaultValue);
     });
 
     ipcMain.on(getIPCChannelName(namespace, 'jsonVariationDetail'), (event, key, defaultValue) => {
-      // eslint-disable-next-line no-param-reassign
       event.returnValue = this.jsonVariationDetail(key, defaultValue);
     });
 
     ipcMain.on(getIPCChannelName(namespace, 'numberVariation'), (event, key, defaultValue) => {
-      // eslint-disable-next-line no-param-reassign
       event.returnValue = this.numberVariation(key, defaultValue);
     });
 
     ipcMain.on(
       getIPCChannelName(namespace, 'numberVariationDetail'),
       (event, key, defaultValue) => {
-        // eslint-disable-next-line no-param-reassign
         event.returnValue = this.numberVariationDetail(key, defaultValue);
       },
     );
 
     ipcMain.on(getIPCChannelName(namespace, 'stringVariation'), (event, key, defaultValue) => {
-      // eslint-disable-next-line no-param-reassign
       event.returnValue = this.stringVariation(key, defaultValue);
     });
 
     ipcMain.on(
       getIPCChannelName(namespace, 'stringVariationDetail'),
       (event, key, defaultValue) => {
-        // eslint-disable-next-line no-param-reassign
         event.returnValue = this.stringVariationDetail(key, defaultValue);
       },
     );
 
     ipcMain.on(getIPCChannelName(namespace, 'track'), (event, key, data, metricValue) => {
-      // eslint-disable-next-line no-param-reassign
       event.returnValue = this.track(key, data, metricValue);
     });
 
     ipcMain.on(getIPCChannelName(namespace, 'variation'), (event, key, defaultValue) => {
-      // eslint-disable-next-line no-param-reassign
       event.returnValue = this.variation(key, defaultValue);
     });
 
     ipcMain.on(getIPCChannelName(namespace, 'variationDetail'), (event, key, defaultValue) => {
-      // eslint-disable-next-line no-param-reassign
       event.returnValue = this.variationDetail(key, defaultValue);
     });
 
@@ -288,12 +275,10 @@ export class ElectronClient extends LDClientImpl {
     );
 
     ipcMain.on(getIPCChannelName(namespace, 'getConnectionMode'), (event) => {
-      // eslint-disable-next-line no-param-reassign
       event.returnValue = this.getConnectionMode();
     });
 
     ipcMain.on(getIPCChannelName(namespace, 'isOffline'), (event) => {
-      // eslint-disable-next-line no-param-reassign
       event.returnValue = this.isOffline();
     });
   }
@@ -343,14 +328,12 @@ export class ElectronClient extends LDClientImpl {
   private _applyRemove(event: IpcMainEvent, callbackId: string): void {
     const eventName = this._ipcCallbackIdToEventName!.get(callbackId);
     if (!eventName) {
-      // eslint-disable-next-line no-param-reassign
       event.returnValue = false;
       return;
     }
     const entry = this._ipcEventSubscriptions!.get(eventName);
     const port = entry?.ports.get(callbackId);
     if (!entry || !port) {
-      // eslint-disable-next-line no-param-reassign
       event.returnValue = false;
       return;
     }
@@ -361,7 +344,6 @@ export class ElectronClient extends LDClientImpl {
       this.off(eventName, entry.broadcastCallback);
       this._ipcEventSubscriptions!.delete(eventName);
     }
-    // eslint-disable-next-line no-param-reassign
     event.returnValue = true;
   }
 
diff --git a/packages/sdk/electron/src/platform/HeaderWrapper.ts b/packages/sdk/electron/src/platform/HeaderWrapper.ts
@@ -35,7 +35,6 @@ export default class HeaderWrapper implements platform.Headers {
   // We want to use generators here for the simplicity of maintaining
   // this interface. Also they aren't expected to be high frequency usage.
   *values(): Iterable<string> {
-    // eslint-disable-next-line no-restricted-syntax
     for (const key of this.keys()) {
       const val = this.get(key);
       if (val !== null) {
@@ -45,7 +44,6 @@ export default class HeaderWrapper implements platform.Headers {
   }
 
   *entries(): Iterable<[string, string]> {
-    // eslint-disable-next-line no-restricted-syntax
     for (const key of this.keys()) {
       const val = this.get(key);
       if (val !== null) {
diff --git a/packages/sdk/electron/tsup.config.js b/packages/sdk/electron/tsup.config.js
@@ -21,7 +21,6 @@ export default defineConfig([
     // So start of line followed by a character that isn't followed by m or underscore, but we
     // want other things that do start with m, so we need to progressively handle more characters
     // of meta with exclusions.
-    // eslint-disable-next-line no-param-reassign
     opts.mangleProps = /^_([^m|_]|m[^e]|me[^t]|met[^a])/;
   },
 }]);
diff --git a/packages/sdk/fastly/tsup.config.ts b/packages/sdk/fastly/tsup.config.ts
@@ -20,7 +20,6 @@ export default defineConfig({
     // So start of line followed by a character that isn't followed by m or underscore, but we
     // want other things that do start with m, so we need to progressively handle more characters
     // of meta with exclusions.
-    // eslint-disable-next-line no-param-reassign
     opts.mangleProps = /^_([^m|_]|m[^e]|me[^t]|met[^a])/;
   },
 });
diff --git a/packages/sdk/react-native/src/fromExternal/react-native-sse/EventSource.ts b/packages/sdk/react-native/src/fromExternal/react-native-sse/EventSource.ts
@@ -278,7 +278,6 @@ export default class EventSource<E extends string = never> {
     let retry = 0;
     let line = '';
 
-    // eslint-disable-next-line no-plusplus
     for (let i = 0; i < parts.length; i++) {
       line = parts[i].replace(/^(\s|\u00A0)+|(\s|\u00A0)+$/g, '');
       if (line.indexOf('event') === 0) {
diff --git a/packages/sdk/react-native/src/platform/crypto/index.ts b/packages/sdk/react-native/src/platform/crypto/index.ts
@@ -3,7 +3,6 @@ import type { Crypto, Hmac } from '@launchdarkly/js-client-sdk-common';
 import PlatformHasher from './PlatformHasher';
 import { SupportedHashAlgorithm } from './types';
 
-/* eslint-disable no-bitwise */
 /**
  * To avoid dependencies on uuid, this is good enough for now.
  * Ripped from the react-native repo:
diff --git a/packages/sdk/react-native/src/polyfills/btoa.ts b/packages/sdk/react-native/src/polyfills/btoa.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-bitwise */
 import { fromByteArray } from 'base64-js';
 
 import toUtf8Array from './toUtf8Array';
diff --git a/packages/sdk/react-native/src/polyfills/toUtf8Array.ts b/packages/sdk/react-native/src/polyfills/toUtf8Array.ts
@@ -1,6 +1,3 @@
-/* eslint-disable no-plusplus */
-/* eslint-disable no-bitwise */
-
 // Originally from: https://github.com/google/closure-library/blob/a1f5a029c1b32eb4793a2d920aa52abc085e1bf7/closure/goog/crypt/crypt.js
 
 // Once React Native versions uniformly support TextEncoder this code can be removed.
diff --git a/packages/sdk/react-native/src/polyfills/uuid.ts b/packages/sdk/react-native/src/polyfills/uuid.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-bitwise */
 /**
  * To avoid dependencies on uuid, this is good enough for now.
  * Ripped from the react-native repo:
diff --git a/packages/sdk/react/tsup.config.js b/packages/sdk/react/tsup.config.js
@@ -21,7 +21,6 @@ const mangleProps = (opts) => {
   // So start of line followed by a character that isn't followed by m or underscore, but we
   // want other things that do start with m, so we need to progressively handle more characters
   // of meta with exclusions.
-  // eslint-disable-next-line no-param-reassign
   opts.mangleProps = /^_([^m|_]|m[^e]|me[^t]|met[^a])/;
 };
 
diff --git a/packages/sdk/server-ai/examples/vercel-ai/src/index.ts b/packages/sdk/server-ai/examples/vercel-ai/src/index.ts
@@ -106,7 +106,6 @@ async function main() {
     );
 
     // Consume the stream immediately - no await needed before this!
-    // eslint-disable-next-line no-restricted-syntax
     for await (const textPart of streamResult.textStream) {
       process.stdout.write(textPart);
     }
diff --git a/packages/sdk/server-ai/src/api/providers/AIProviderFactory.ts b/packages/sdk/server-ai/src/api/providers/AIProviderFactory.ts
@@ -41,7 +41,6 @@ export class AIProviderFactory {
     const providersToTry = this._getProvidersToTry(defaultAiProvider, providerName);
 
     // Try each provider in order
-    // eslint-disable-next-line no-restricted-syntax
     for (const providerType of providersToTry) {
       logger?.debug(
         `Attempting to create AIProvider for: ${aiConfig.provider?.name} with provider type: ${providerType}`,
diff --git a/packages/sdk/server-node/__tests__/platform/HeaderWrapper.test.ts b/packages/sdk/server-node/__tests__/platform/HeaderWrapper.test.ts
@@ -1,5 +1,3 @@
-/* eslint-disable no-restricted-syntax */
-// The header interface uses generators, so we are using restricted-syntax.
 import * as http from 'http';
 
 import HeaderWrapper from '../../src/platform/HeaderWrapper';
diff --git a/packages/sdk/server-node/src/platform/HeaderWrapper.ts b/packages/sdk/server-node/src/platform/HeaderWrapper.ts
@@ -35,7 +35,6 @@ export default class HeaderWrapper implements platform.Headers {
   // We want to use generators here for the simplicity of maintaining
   // this interface. Also they aren't expected to be high frequency usage.
   *values(): Iterable<string> {
-    // eslint-disable-next-line no-restricted-syntax
     for (const key of this.keys()) {
       const val = this.get(key);
       if (val !== null) {
@@ -45,7 +44,6 @@ export default class HeaderWrapper implements platform.Headers {
   }
 
   *entries(): Iterable<[string, string]> {
-    // eslint-disable-next-line no-restricted-syntax
     for (const key of this.keys()) {
       const val = this.get(key);
       if (val !== null) {
diff --git a/packages/sdk/shopify-oxygen/contract-tests/tsup.config.ts b/packages/sdk/shopify-oxygen/contract-tests/tsup.config.ts
@@ -21,7 +21,6 @@ export default defineConfig({
     // So start of line followed by a character that isn't followed by m or underscore, but we
     // want other things that do start with m, so we need to progressively handle more characters
     // of meta with exclusions.
-    // eslint-disable-next-line no-param-reassign
     opts.mangleProps = /^_([^m|_]|m[^e]|me[^t]|met[^a])/;
   },
 });
diff --git a/packages/sdk/shopify-oxygen/tsup.config.ts b/packages/sdk/shopify-oxygen/tsup.config.ts
@@ -21,7 +21,6 @@ export default defineConfig({
     // So start of line followed by a character that isn't followed by m or underscore, but we
     // want other things that do start with m, so we need to progressively handle more characters
     // of meta with exclusions.
-    // eslint-disable-next-line no-param-reassign
     opts.mangleProps = /^_([^m|_]|m[^e]|me[^t]|met[^a])/;
   },
 });
diff --git a/packages/shared/sdk-client/src/context/ensureKey.ts b/packages/shared/sdk-client/src/context/ensureKey.ts
@@ -33,7 +33,6 @@ const ensureKeyCommon = async (kind: string, c: LDContextCommon, platform: Platf
   if (anonymous && !key) {
     const storageKey = await namespaceForAnonymousGeneratedContextKey(kind);
     // This mutates a cloned copy of the original context from ensureyKey so this is safe.
-    // eslint-disable-next-line no-param-reassign
     c.key = await getOrGenerateKey(storageKey, platform);
   }
 };
diff --git a/packages/shared/sdk-client/src/datasource/fdv2/SourceManager.ts b/packages/shared/sdk-client/src/datasource/fdv2/SourceManager.ts
@@ -179,7 +179,6 @@ export function createSourceManager(
 
     blockCurrentSynchronizer() {
       if (synchronizerIndex >= 0 && synchronizerIndex < synchronizerSlots.length) {
-        // eslint-disable-next-line no-param-reassign
         synchronizerSlots[synchronizerIndex].state = 'blocked';
       }
     },
@@ -190,7 +189,6 @@ export function createSourceManager(
 
     fdv1Fallback() {
       synchronizerSlots.forEach((slot) => {
-        // eslint-disable-next-line no-param-reassign
         slot.state = slot.isFDv1Fallback ? 'available' : 'blocked';
       });
       synchronizerIndex = -1;
diff --git a/packages/shared/sdk-server/src/evaluation/Evaluator.ts b/packages/shared/sdk-server/src/evaluation/Evaluator.ts
@@ -266,10 +266,8 @@ export default class Evaluator {
             state,
             updatedVisitedFlags,
             (res) => {
-              // eslint-disable-next-line no-param-reassign
               state.events ??= [];
               if (topLevel) {
-                // eslint-disable-next-line no-param-reassign
                 state.prerequisites ??= [];
 
                 state.prerequisites.push(prereqFlag.key);
@@ -624,7 +622,6 @@ export default class Evaluator {
       // that probably means the data store was populated by an older SDK that doesn't know
       // about the generation property and therefore dropped it from the JSON data. We'll treat
       // that as a "not configured" condition.
-      // eslint-disable-next-line no-param-reassign
       state.bigSegmentsStatus = computeUpdatedBigSegmentsStatus(
         state.bigSegmentsStatus,
         'NOT_CONFIGURED',
@@ -649,25 +646,20 @@ export default class Evaluator {
     }
 
     this._queries.getBigSegmentsMembership(keyForBigSegment).then((result) => {
-      // eslint-disable-next-line no-param-reassign
       state.bigSegmentsMembership = state.bigSegmentsMembership || {};
       if (result) {
         const [membership, status] = result;
-        // eslint-disable-next-line no-param-reassign
         state.bigSegmentsMembership[keyForBigSegment] = membership;
-        // eslint-disable-next-line no-param-reassign
         state.bigSegmentsStatus = computeUpdatedBigSegmentsStatus(
           state.bigSegmentsStatus,
           status as BigSegmentStoreStatusString,
         );
       } else {
-        // eslint-disable-next-line no-param-reassign
         state.bigSegmentsStatus = computeUpdatedBigSegmentsStatus(
           state.bigSegmentsStatus,
           'NOT_CONFIGURED',
         );
       }
-      /* eslint-enable no-param-reassign */
       this.bigSegmentMatchContext(
         state.bigSegmentsMembership[keyForBigSegment],
         segment,
diff --git a/packages/shared/sdk-server/src/options/Configuration.ts b/packages/shared/sdk-server/src/options/Configuration.ts
@@ -356,7 +356,6 @@ export default class Configuration {
   constructor(options: LDOptions = {}, internalOptions: ServerInternalOptions = {}) {
     // The default will handle undefined, but not null.
     // Because we can be called from JS we need to be extra defensive.
-    // eslint-disable-next-line no-param-reassign
     options = options || {};
     // If there isn't a valid logger from the platform, then logs would go nowhere.
     this.logger = options.logger;
diff --git a/packages/shared/sdk-server/src/store/serialization.ts b/packages/shared/sdk-server/src/store/serialization.ts
@@ -1,7 +1,3 @@
-// The deserialization will be updating parameter values, so we don't need this
-// warning in this file.
-
-/* eslint-disable no-param-reassign */
 import { AttributeReference } from '@launchdarkly/js-sdk-common';
 
 import { VersionedData } from '../api/interfaces';
diff --git a/packages/store/node-server-sdk-dynamodb/__tests__/clearPrefix.ts b/packages/store/node-server-sdk-dynamodb/__tests__/clearPrefix.ts
@@ -16,7 +16,6 @@ export default async function clearPrefix(table: string, prefix?: string) {
   const deleteOps: WriteRequest[] = [];
 
   // Using a generator here is a substantial ergonomic improvement and this is a test file.
-  // eslint-disable-next-line no-restricted-syntax
   for await (const page of paginateScan(
     { client },
     {
diff --git a/packages/store/node-server-sdk-dynamodb/src/DynamoDBClientState.ts b/packages/store/node-server-sdk-dynamodb/src/DynamoDBClientState.ts
@@ -64,7 +64,6 @@ export default class DynamoDBClientState {
   async query(params: QueryCommandInput): Promise<Record<string, AttributeValue>[]> {
     const records: Record<string, AttributeValue>[] = [];
     // Using a generator here is a substantial ergonomic improvement.
-    // eslint-disable-next-line no-restricted-syntax
     for await (const page of paginateQuery({ client: this._client }, params)) {
       if (page.Items) {
         records.push(...page.Items);
diff --git a/packages/telemetry/browser-telemetry/__tests__/randomUuidV4.test.ts b/packages/telemetry/browser-telemetry/__tests__/randomUuidV4.test.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-bitwise */
 import { fallbackUuidV4, formatDataAsUuidV4 } from '../src/randomUuidV4';
 
 it('formats conformant UUID', () => {
diff --git a/packages/telemetry/browser-telemetry/__tests__/vendor/TraceKit/computeStackTrace.test.ts b/packages/telemetry/browser-telemetry/__tests__/vendor/TraceKit/computeStackTrace.test.ts
@@ -6,7 +6,6 @@
 import { getTraceKit } from '../../../src/vendor/TraceKit';
 import * as CapturedExceptions from './CapturedExceptions';
 
-/* eslint-disable no-plusplus */
 /* eslint-disable no-useless-escape */
 /* eslint-disable @typescript-eslint/no-use-before-define */
 
diff --git a/packages/telemetry/browser-telemetry/src/filters/filterHttpBreadcrumb.ts b/packages/telemetry/browser-telemetry/src/filters/filterHttpBreadcrumb.ts
@@ -14,7 +14,6 @@ export default function filterHttpBreadcrumb(
   if (crumb.data?.url) {
     // Re-assigning for performance. The contract of the function is clear that the input
     // data is modified.
-    // eslint-disable-next-line no-param-reassign
     crumb.data.url = filterUrl(options.urlFilters, crumb.data.url);
   }
 }
diff --git a/packages/telemetry/browser-telemetry/src/vendor/TraceKit.ts b/packages/telemetry/browser-telemetry/src/vendor/TraceKit.ts

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-/* eslint-disable no-bitwise */`
`2`	`1`	`import { fallbackUuidV4, formatDataAsUuidV4 } from '../../src/platform/randomUuidV4';`
`3`	`2`
`4`	`3`	`it('formats conformant UUID', () => {`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-/* eslint-disable no-restricted-syntax */`
`2`		`-// The header interface uses generators, so we are using restricted-syntax.`
`3`	`1`	`import * as http from 'http';`
`4`	`2`
`5`	`3`	`import HeaderWrapper from '../../src/platform/HeaderWrapper';`