refactor: revert lint fixes (isolated to PR #1316)

joker23 · claude · joker23 · commit 68e8a580a2c7 · 2026-04-24T10:38:54.000-05:00
Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/packages/sdk/browser/contract-tests/entity/src/main.ts b/packages/sdk/browser/contract-tests/entity/src/main.ts
@@ -1,3 +1,4 @@
+// eslint-disable-next-line prettier/prettier
 import './style.css';
 import TestHarnessWebSocket from './TestHarnessWebSocket';
 
diff --git a/packages/shared/common/__tests__/internal/events/EventSender.test.ts b/packages/shared/common/__tests__/internal/events/EventSender.test.ts
@@ -218,7 +218,7 @@ describe('given an event sender', () => {
       eventSender.sendEventData(LDEventType.AnalyticsEvents, testEventData1),
     );
 
-    const errorMessage = 'Received error 413 for event posting - giving up permanently';
+    const errorMessage = `Received error 413 for event posting - giving up permanently`;
 
     const { status, error } = eventSenderResult;
 
diff --git a/packages/shared/common/__tests__/subsystem/DataSystem/CompositeDataSource.test.ts b/packages/shared/common/__tests__/subsystem/DataSystem/CompositeDataSource.test.ts
@@ -409,7 +409,7 @@ it('falls back to FDv1 synchronizers when FDv1 fallback error is reported', asyn
             DataSourceState.Closed,
             new LDFlagDeliveryFallbackError(
               DataSourceErrorKind.ErrorResponse,
-              'Response header indicates to fallback to FDv1',
+              `Response header indicates to fallback to FDv1`,
               403,
             ),
           );
@@ -656,7 +656,7 @@ it('it reports DataSourceState Closed when all synchronizers report Closed with
   expect(statusCallback).toHaveBeenNthCalledWith(5, DataSourceState.Interrupted, expect.anything()); // sync2 closed with unrecoverable error
   expect(statusCallback).toHaveBeenNthCalledWith(6, DataSourceState.Closed, {
     name: 'ExhaustedDataSources',
-    message: 'CompositeDataSource has exhausted all configured initializers and synchronizers.',
+    message: `CompositeDataSource has exhausted all configured initializers and synchronizers.`,
   });
 });
 
diff --git a/packages/shared/common/src/AttributeReference.ts b/packages/shared/common/src/AttributeReference.ts
@@ -110,13 +110,13 @@ export default class AttributeReference {
     for (let index = 0; index < components.length; index += 1) {
       const component = components[index];
       if (
-        current !== null
-        && current !== undefined
+        current !== null &&
+        current !== undefined &&
         // See https://eslint.org/docs/rules/no-prototype-builtins
-        && Object.prototype.hasOwnProperty.call(current, component)
-        && typeof current === 'object'
+        Object.prototype.hasOwnProperty.call(current, component) &&
+        typeof current === 'object' &&
         // We do not want to allow indexing into an array.
-        && !Array.isArray(current)
+        !Array.isArray(current)
       ) {
         current = current[component];
       } else {
@@ -140,8 +140,8 @@ export default class AttributeReference {
 
   public compare(other: AttributeReference) {
     return (
-      this.depth === other.depth
-      && this._components.every((value, index) => value === other.getComponent(index))
+      this.depth === other.depth &&
+      this._components.every((value, index) => value === other.getComponent(index))
     );
   }
 
diff --git a/packages/shared/common/src/ContextFilter.ts b/packages/shared/common/src/ContextFilter.ts
@@ -141,8 +141,8 @@ export default class ContextFilter {
     kind: string,
     redactAnonymousAttributes: boolean,
   ): any {
-    const redactAllAttributes
-      = this._allAttributesPrivate || (redactAnonymousAttributes && single.anonymous === true);
+    const redactAllAttributes =
+      this._allAttributesPrivate || (redactAnonymousAttributes && single.anonymous === true);
     const { cloned, excluded } = cloneWithRedactions(
       single,
       this._getAttributesToFilter(context, single, kind, redactAllAttributes),
diff --git a/packages/shared/common/src/api/context/index.ts b/packages/shared/common/src/api/context/index.ts
@@ -1,6 +1,6 @@
-export * from './LDContext';
 export * from './LDContextCommon';
 export * from './LDContextMeta';
 export * from './LDMultiKindContext';
 export * from './LDSingleKindContext';
 export * from './LDUser';
+export * from './LDContext';
diff --git a/packages/shared/common/src/api/index.ts b/packages/shared/common/src/api/index.ts
@@ -1,7 +1,7 @@
 export * from './context';
-export * from './data';
-export * from './integrations';
 export * from './logging';
+export * from './data';
 export * from './options';
 export * from './platform';
 export * as subsystem from './subsystem';
+export * from './integrations';
diff --git a/packages/shared/common/src/api/subsystem/index.ts b/packages/shared/common/src/api/subsystem/index.ts
@@ -7,12 +7,12 @@ import { LDStreamProcessor } from './LDStreamProcessor';
 export {
   DataSource,
   DataSourceState,
-  LDContextDeduplicator,
   LDDataSourceFactory,
-  LDDeliveryStatus,
   LDEventProcessor,
+  LDContextDeduplicator,
   LDEventSender,
-  LDEventSenderResult,
+  LDDeliveryStatus,
   LDEventType,
+  LDEventSenderResult,
   LDStreamProcessor,
 };
diff --git a/packages/shared/common/src/datasource/Backoff.ts b/packages/shared/common/src/datasource/Backoff.ts
@@ -68,8 +68,8 @@ export class DefaultBackoff {
     // If the last successful connection was active for more than the RESET_INTERVAL, then we
     // return to the initial retry delay.
     if (
-      this._activeSince !== undefined
-      && timeStampMs - this._activeSince > this._retryResetIntervalMillis
+      this._activeSince !== undefined &&
+      timeStampMs - this._activeSince > this._retryResetIntervalMillis
     ) {
       this._retryCount = 0;
     }
diff --git a/packages/shared/common/src/datasource/CompositeDataSource.ts b/packages/shared/common/src/datasource/CompositeDataSource.ts
@@ -147,7 +147,7 @@ export class CompositeDataSource implements DataSource {
 
                   // this error indicates we should fallback to only using FDv1 synchronizers
                   if (err instanceof LDFlagDeliveryFallbackError) {
-                    this._logger?.debug('Falling back to FDv1');
+                    this._logger?.debug(`Falling back to FDv1`);
                     this._syncFactories = this._fdv1Synchronizers;
                   }
                 }
@@ -190,7 +190,7 @@ export class CompositeDataSource implements DataSource {
             transition: 'stop',
             err: {
               name: 'ExhaustedDataSources',
-              message: 'CompositeDataSource has exhausted all configured initializers and synchronizers.',
+              message: `CompositeDataSource has exhausted all configured initializers and synchronizers.`,
             },
           });
         }
diff --git a/packages/shared/common/src/datasource/index.ts b/packages/shared/common/src/datasource/index.ts
@@ -12,8 +12,8 @@ import {
 export {
   Backoff,
   CompositeDataSource,
-  DataSourceErrorKind,
   DefaultBackoff,
+  DataSourceErrorKind,
   LDFileDataSourceError,
   LDFlagDeliveryFallbackError,
   LDPollingError,
diff --git a/packages/shared/common/src/index.ts b/packages/shared/common/src/index.ts
@@ -14,24 +14,25 @@ import {
 } from './datasource';
 
 export * from './api';
-export * from './errors';
-export * as internal from './internal';
+export * from './validators';
 export * from './logging';
 export * from './options';
 export * from './utils';
-export * from './validators';
+
+export * as internal from './internal';
+export * from './errors';
 
 export {
   AttributeReference,
-  Backoff,
-  CompositeDataSource,
   Context,
   ContextFilter,
+  CompositeDataSource,
   DataSourceErrorKind,
+  Backoff,
   DefaultBackoff,
-  LDFileDataSourceError,
-  LDFlagDeliveryFallbackError,
   LDPollingError,
   LDStreamingError,
   StreamingErrorHandler,
+  LDFileDataSourceError,
+  LDFlagDeliveryFallbackError,
 };
diff --git a/packages/shared/common/src/internal/events/ClientMessages.ts b/packages/shared/common/src/internal/events/ClientMessages.ts
@@ -2,13 +2,13 @@
  * Messages for issues which can be encountered processing client requests.
  */
 export default class ClientMessages {
-  static readonly MissingContextKeyNoEvent
-    = 'Context was unspecified or had no key; event will not be sent';
+  static readonly MissingContextKeyNoEvent =
+    'Context was unspecified or had no key; event will not be sent';
 
   static invalidMetricValue(badType: string) {
     return (
-      'The track function was called with a non-numeric "metricValue"'
-      + ` (${badType}), only numeric metric values are supported.`
+      'The track function was called with a non-numeric "metricValue"' +
+      ` (${badType}), only numeric metric values are supported.`
     );
   }
 }
diff --git a/packages/shared/common/src/internal/events/EventProcessor.ts b/packages/shared/common/src/internal/events/EventProcessor.ts
@@ -218,9 +218,9 @@ export default class EventProcessor implements LDEventProcessor {
   async flush(): Promise<void> {
     if (this._shutdown) {
       throw new LDInvalidSDKKeyError(
-        'Events cannot be posted because a permanent error has been encountered. '
-        + 'This is most likely an invalid SDK key. The specific error information '
-        + 'is logged independently.',
+        'Events cannot be posted because a permanent error has been encountered. ' +
+          'This is most likely an invalid SDK key. The specific error information ' +
+          'is logged independently.',
       );
     }
 
@@ -423,10 +423,10 @@ export default class EventProcessor implements LDEventProcessor {
 
   private _shouldDebugEvent(event: InputEvent) {
     return (
-      isFeature(event)
-      && event.debugEventsUntilDate
-      && event.debugEventsUntilDate > this._lastKnownPastTime
-      && event.debugEventsUntilDate > Date.now()
+      isFeature(event) &&
+      event.debugEventsUntilDate &&
+      event.debugEventsUntilDate > this._lastKnownPastTime &&
+      event.debugEventsUntilDate > Date.now()
     );
   }
 
diff --git a/packages/shared/common/src/internal/events/EventSender.ts b/packages/shared/common/src/internal/events/EventSender.ts
@@ -18,7 +18,6 @@ export default class EventSender implements LDEventSender {
   private _defaultHeaders: {
     [key: string]: string;
   };
-
   private _diagnosticEventsUri: string;
   private _eventsUri: string;
   private _requests: Requests;
diff --git a/packages/shared/common/src/internal/events/MultiEventSummarizer.ts b/packages/shared/common/src/internal/events/MultiEventSummarizer.ts
@@ -10,7 +10,6 @@ export default class MultiEventSummarizer implements LDMultiEventSummarizer {
     private readonly _contextFilter: ContextFilter,
     private readonly _logger?: LDLogger,
   ) {}
-
   private _summarizers: Record<string, EventSummarizer> = {};
 
   summarizeEvent(event: InputEvent) {
diff --git a/packages/shared/common/src/internal/events/index.ts b/packages/shared/common/src/internal/events/index.ts
@@ -11,14 +11,14 @@ import shouldSample from './sampling';
 
 export {
   ClientMessages,
-  EventProcessor,
-  EventProcessorOptions,
   InputCustomEvent,
   InputEvalEvent,
   InputEvent,
   InputIdentifyEvent,
   InputMigrationEvent,
-  LDInternalOptions,
-  NullEventProcessor,
+  EventProcessor,
+  EventProcessorOptions,
   shouldSample,
+  NullEventProcessor,
+  LDInternalOptions,
 };
diff --git a/packages/shared/common/src/internal/fdv2/index.ts b/packages/shared/common/src/internal/fdv2/index.ts
@@ -2,6 +2,7 @@ import { fdv1PayloadAdaptor as FDv1PayloadAdaptor } from './FDv1PayloadAdaptor';
 import { PayloadProcessor } from './payloadProcessor';
 import { PayloadStreamReader } from './payloadStreamReader';
 import type { FDv2Event, FDv2EventsCollection } from './proto';
+import { createProtocolHandler } from './protocolHandler';
 import type {
   ObjProcessors,
   Payload,
@@ -13,7 +14,6 @@ import type {
   ProtocolState,
   Update,
 } from './protocolHandler';
-import { createProtocolHandler } from './protocolHandler';
 
 export { createProtocolHandler, FDv1PayloadAdaptor, PayloadProcessor, PayloadStreamReader };
 
diff --git a/packages/shared/common/src/internal/index.ts b/packages/shared/common/src/internal/index.ts
@@ -3,6 +3,6 @@ export * from './diagnostics';
 export * from './evaluation';
 export * from './events';
 export * from './fdv2';
-export * from './json';
 export * from './metadata';
 export * from './plugins';
+export * from './json';
diff --git a/packages/shared/common/src/internal/plugins/safeGetName.ts b/packages/shared/common/src/internal/plugins/safeGetName.ts
@@ -10,7 +10,7 @@ export function safeGetName<TClient, THook>(
   try {
     return plugin.getMetadata().name || UNKNOWN_PLUGIN_NAME;
   } catch {
-    logger.error('Exception thrown getting metadata for plugin. Unable to get plugin name.');
+    logger.error(`Exception thrown getting metadata for plugin. Unable to get plugin name.`);
     return UNKNOWN_PLUGIN_NAME;
   }
 }
diff --git a/packages/shared/common/src/logging/index.ts b/packages/shared/common/src/logging/index.ts
@@ -2,4 +2,4 @@ import BasicLogger from './BasicLogger';
 import createSafeLogger from './createSafeLogger';
 import SafeLogger from './SafeLogger';
 
-export { BasicLogger, createSafeLogger, SafeLogger };
+export { BasicLogger, SafeLogger, createSafeLogger };
diff --git a/packages/shared/common/src/options/ApplicationTags.ts b/packages/shared/common/src/options/ApplicationTags.ts
@@ -43,7 +43,7 @@ export default class ApplicationTags {
           if (!valid) {
             logger?.warn(message);
           } else if (key === 'versionName') {
-            tags['application-version-name'] = [value];
+            tags[`application-version-name`] = [value];
           } else {
             tags[`application-${key}`] = [value];
           }
diff --git a/packages/shared/common/src/options/index.ts b/packages/shared/common/src/options/index.ts
@@ -5,10 +5,10 @@ import ServiceEndpoints, { getEventsUri, getPollingUri, getStreamingUri } from '
 
 export {
   ApplicationTags,
-  ClientContext,
-  getEventsUri,
-  getPollingUri,
-  getStreamingUri,
   OptionMessages,
   ServiceEndpoints,
+  ClientContext,
+  getStreamingUri,
+  getPollingUri,
+  getEventsUri,
 };
diff --git a/packages/shared/common/src/utils/index.ts b/packages/shared/common/src/utils/index.ts
@@ -12,19 +12,19 @@ import { VoidFunction } from './VoidFunction';
 
 export {
   base64UrlEncode,
-  cancelableTimedPromise,
-  type CancelableTimeout,
   clone,
   debounce,
   deepCompact,
   defaultHeaders,
   fastDeepEqual,
   httpErrorMessage,
-  LDHeaders,
   noop,
-  secondsToMillis,
+  LDHeaders,
   shouldRetry,
+  secondsToMillis,
   sleep,
   timedPromise,
   VoidFunction,
+  type CancelableTimeout,
+  cancelableTimedPromise,
 };

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+// eslint-disable-next-line prettier/prettier`
`1`	`2`	`import './style.css';`
`2`	`3`	`import TestHarnessWebSocket from './TestHarnessWebSocket';`
`3`	`4`
Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@ export class CompositeDataSource implements DataSource {`
`147`	`147`
`148`	`148`	`// this error indicates we should fallback to only using FDv1 synchronizers`
`149`	`149`	`if (err instanceof LDFlagDeliveryFallbackError) {`
`150`		`- this._logger?.debug('Falling back to FDv1');`
	`150`	+ this._logger?.debug(`Falling back to FDv1`);
`151`	`151`	`this._syncFactories = this._fdv1Synchronizers;`
`152`	`152`	`}`
`153`	`153`	`}`
`@@ -190,7 +190,7 @@ export class CompositeDataSource implements DataSource {`
`190`	`190`	`transition: 'stop',`
`191`	`191`	`err: {`
`192`	`192`	`name: 'ExhaustedDataSources',`
`193`		`- message: 'CompositeDataSource has exhausted all configured initializers and synchronizers.',`
	`193`	+ message: `CompositeDataSource has exhausted all configured initializers and synchronizers.`,
`194`	`194`	`},`
`195`	`195`	`});`
`196`	`196`	`}`