Skip to content

Commit 69f4790

Browse files
authored
feat: pre-release of @launchdarkly/react-sdk (#1201)
<!-- CURSOR_SUMMARY --> > [!NOTE] > **Medium Risk** > Medium risk because it changes automated release conditions and dependency resolution for a new package, which could unintentionally publish or pull incorrect versions if misconfigured. > > **Overview** > Adds `@launchdarkly/react-sdk` to the monorepo’s release and documentation surface area. > > Updates `release-please` config/manifest to version and bootstrap `packages/sdk/react`, and enables the `release-react` job to run when `package-sdk-react-released` is true. > > Adjusts the React SDK package to depend on published `@launchdarkly/js-client-sdk`/`@launchdarkly/js-server-sdk-common` versions (instead of workspace links), and updates `README.md`/`CONTRIBUTING.md` plus the React workflow to reflect the new package and examples. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit b6c58ad. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> <!-- devin-review-badge-begin --> --- <a href="https://app.devin.ai/review/launchdarkly/js-core/pull/1201" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open with Devin"> </picture> </a> <!-- devin-review-badge-end -->
1 parent c51db83 commit 69f4790

7 files changed

Lines changed: 21 additions & 12 deletions

File tree

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,5 +110,3 @@ jobs:
110110
workspace_name: '@internal/react-sdk-example-server-only'
111111
aws_assume_role: ${{ vars.AWS_ROLE_ARN }}
112112
before_test: 'yarn workspace @internal/react-sdk-example-server-only playwright install --with-deps chromium'
113-
114-
# TODO: Add contract tests

.github/workflows/release-please.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -524,9 +524,7 @@ jobs:
524524
permissions:
525525
id-token: write
526526
contents: write
527-
# if: ${{ always() && !failure() && !cancelled() && needs.release-please.outputs.package-sdk-react-released == 'true'}}
528-
# TODO: Uncomment this when the package is ready to be released.
529-
if: false
527+
if: ${{ always() && !failure() && !cancelled() && needs.release-please.outputs.package-sdk-react-released == 'true'}}
530528
steps:
531529
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
532530
- id: release-react

.release-please-manifest.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,6 @@
2222
"packages/telemetry/browser-telemetry": "1.0.28",
2323
"packages/telemetry/node-server-sdk-otel": "1.3.9",
2424
"packages/tooling/jest": "1.0.7",
25-
"packages/sdk/shopify-oxygen": "0.1.6"
25+
"packages/sdk/shopify-oxygen": "0.1.6",
26+
"packages/sdk/react": "0.0.1"
2627
}

CONTRIBUTING.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ flowchart LR
165165
akamai-base[sdk/akamai-base]
166166
akamai-edgekv[sdk/akamai-edgekv]
167167
server-ai[sdk/server-ai]
168-
svelte[sdk/svelte]
168+
react[sdk/react]
169169
shopify-oxygen[sdk/shopify-oxygen]
170170

171171
%% Store packages
@@ -189,7 +189,8 @@ flowchart LR
189189
%% Dependencies for SDK packages
190190
sdk-client --> browser
191191
sdk-client --> react-native
192-
sdk-client --> svelte
192+
browser --> react
193+
sdk-server --> react
193194

194195
sdk-server --> server-node
195196
sdk-server --> server-ai
@@ -214,7 +215,7 @@ flowchart LR
214215
react-native -.-> jest
215216

216217
class common,sdk-client,sdk-server,sdk-server-edge,akamai-edgeworker shared
217-
class server-node,cloudflare,fastly,react-native,browser,vercel,akamai-base,akamai-edgekv,server-ai,svelte sdk
218+
class server-node,cloudflare,fastly,react-native,browser,vercel,akamai-base,akamai-edgekv,server-ai,react,shopify-oxygen sdk
218219
class redis,dynamodb store
219220
class node-otel,browser-telemetry telemetry
220221
class jest tooling

README.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ This includes shared libraries, used by SDKs and other tools, as well as SDKs.
1717
| [@launchdarkly/js-client-sdk](packages/sdk/browser/README.md) | [![NPM][sdk-browser-npm-badge]][sdk-browser-npm-link] | [Browser][package-sdk-browser-issues] | [![Actions Status][sdk-browser-ci-badge]][sdk-browser-ci] |
1818
| [@launchdarkly/server-sdk-ai](packages/sdk/server-ai/README.md) | [![NPM][sdk-server-ai-npm-badge]][sdk-server-ai-npm-link] | [server-ai][package-sdk-server-ai-issues] | [![Actions Status][sdk-server-ai-ci-badge]][sdk-server-ai-ci] |
1919
| [@launchdarkly/shopify-oxygen-sdk](packages/sdk/shopify-oxygen/README.md) | [![NPM][sdk-shopify-oxygen-npm-badge]][sdk-shopify-oxygen-npm-link] | [Shopify Oxygen][package-sdk-shopify-oxygen-issues] | [![Actions Status][sdk-shopify-oxygen-ci-badge]][sdk-shopify-oxygen-ci] |
20+
| [@launchdarkly/react-sdk](packages/sdk/react/README.md) | [![NPM][sdk-react-npm-badge]][sdk-react-npm-link] | [React][package-sdk-react-issues] | [![Actions Status][sdk-react-ci-badge]][sdk-react-ci] |
2021
<!--| [@launchdarkly/browser](packages/sdk/combined-browser/README.md) | [![NPM][sdk-combined-browser-npm-badge]][sdk-browser-npm-link] | [Combined Browser][package-sdk-combined-browser-issues] | [![Actions Status][sdk-combined-browser-ci-badge]][sdk-combined-browser-ci] |-->
2122

2223
| Shared packages | npm | issues | tests |
@@ -250,4 +251,10 @@ We encourage pull requests and other contributions from the community. Check out
250251
[sdk-shopify-oxygen-ci]: https://github.com/launchdarkly/js-core/actions/workflows/shopify-oxygen.yml
251252
[sdk-shopify-oxygen-npm-badge]: https://img.shields.io/npm/v/@launchdarkly/shopify-oxygen-sdk.svg?style=flat-square
252253
[sdk-shopify-oxygen-npm-link]: https://www.npmjs.com/package/@launchdarkly/shopify-oxygen-sdk
253-
[package-sdk-shopify-oxygen-issues]: https://github.com/launchdarkly/js-core/issues?q=is%3Aissue+is%3Aopen+label%3A%22package%3A+sdk%2Fshopify-oxygen%22+
254+
[package-sdk-shopify-oxygen-issues]: https://github.com/launchdarkly/js-core/issues?q=is%3Aissue+is%3Aopen+label%3A%22package%3A+sdk%2Fshopify-oxygen%22+
255+
[//]: # 'sdk/react'
256+
[sdk-react-ci-badge]: https://github.com/launchdarkly/js-core/actions/workflows/react.yml/badge.svg
257+
[sdk-react-ci]: https://github.com/launchdarkly/js-core/actions/workflows/react.yml
258+
[sdk-react-npm-badge]: https://img.shields.io/npm/v/@launchdarkly/react-sdk.svg?style=flat-square
259+
[sdk-react-npm-link]: https://www.npmjs.com/package/@launchdarkly/react-sdk
260+
[package-sdk-react-issues]: https://github.com/launchdarkly/js-core/issues?q=is%3Aissue+is%3Aopen+label%3A%22package%3A+sdk%2Freact%22+

packages/sdk/react/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@
6868
"typescript": "5.1.6"
6969
},
7070
"dependencies": {
71-
"@launchdarkly/js-client-sdk": "workspace:^",
72-
"@launchdarkly/js-server-sdk-common": "workspace:^"
71+
"@launchdarkly/js-client-sdk": "^4.4.0",
72+
"@launchdarkly/js-server-sdk-common": "^2.18.2"
7373
},
7474
"peerDependencies": {
7575
"react": ">=18.0.0",

release-please-config.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,10 @@
102102
"packages/telemetry/browser-telemetry": {},
103103
"packages/sdk/combined-browser": {
104104
"bump-minor-pre-major": true
105+
},
106+
"packages/sdk/react": {
107+
"bump-minor-pre-major": true,
108+
"bootstrap-sha": "9250766a9"
105109
}
106110
},
107111
"plugins": [

0 commit comments

Comments
 (0)