fix(sdk-client): executeAfterTrack ordering

Author: joker23

packages/sdk/browser/contract-tests/entity/src/ClientEntity.ts

@@ -190,9 +190,7 @@ function makeSdkConfig(options: SDKConfigParams, tag: string) {
   }
 
   if (options.hooks) {
-    cf.hooks = options.hooks.hooks.map(
-      (hook) => new TestHook(hook.name, hook.callbackUri, hook.data, hook.errors),
-    );
+    cf.hooks = TestHook.forClient(options.hooks.hooks);
   }
 
   cf.fetchGoals = false;

packages/sdk/browser/contract-tests/suppressions.txt

@@ -15,6 +15,4 @@ tags/stream requests/{"applicationId":"._-abcdefghijklmnopqrstuvwxyzABCDEFGHIJKL
 tags/stream requests/{"applicationId":"________________________________________________________________","applicationVersion":null}
 tags/stream requests/{"applicationId":"________________________________________________________________","applicationVersion":""}
 tags/stream requests/{"applicationId":"________________________________________________________________","applicationVersion":"._-abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ012345678"}
-tags/stream requests/{"applicationId":"________________________________________________________________","applicationVersion":"________________________________________________________________"}
-hooks/evaluation/executes beforeEvaluation hooks in registration order
-hooks/track/executes afterTrack hooks in registration order
+tags/stream requests/{"applicationId":"________________________________________________________________","applicationVersion":"________________________________________________________________"}

packages/sdk/electron/contract-tests/entity/src/ClientEntity.ts

@@ -87,9 +87,7 @@ function makeSdkConfig(options: SDKConfigParams, tag: string) {
   }
 
   if (options.hooks) {
-    cf.hooks = options.hooks.hooks.map(
-      (hook) => new TestHook(hook.name, hook.callbackUri, hook.data, hook.errors),
-    );
+    cf.hooks = TestHook.forClient(options.hooks.hooks);
   }
 
   if (options.tls) {

packages/sdk/electron/contract-tests/suppressions.txt

@@ -1,2 +0,0 @@
-hooks/evaluation/executes beforeEvaluation hooks in registration order
-hooks/track/executes afterTrack hooks in registration order

packages/sdk/react-native/contract-tests/entity/src/ClientEntity.ts

@@ -77,9 +77,7 @@ function makeSdkConfig(options: SDKConfigParams, tag: string) {
   }
 
   if (options.hooks) {
-    cf.hooks = options.hooks.hooks.map(
-      (hook) => new TestHook(hook.name, hook.callbackUri, hook.data, hook.errors),
-    );
+    cf.hooks = TestHook.forClient(options.hooks.hooks);
   }
 
   return cf;

packages/sdk/react/contract-tests/app/ClientEntity.ts

@@ -70,9 +70,7 @@ export function makeSdkConfig(options: SDKConfigParams, tag: string): LDOptions
   }
 
   if (options.hooks) {
-    cf.hooks = options.hooks.hooks.map(
-      (hook) => new TestHook(hook.name, hook.callbackUri, hook.data, hook.errors),
-    );
+    cf.hooks = TestHook.forClient(options.hooks.hooks);
   }
 
   cf.fetchGoals = false;

packages/sdk/react/contract-tests/suppressions.txt

@@ -16,5 +16,3 @@ tags/stream requests/{"applicationId":"_________________________________________
 tags/stream requests/{"applicationId":"________________________________________________________________","applicationVersion":""}
 tags/stream requests/{"applicationId":"________________________________________________________________","applicationVersion":"._-abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ012345678"}
 tags/stream requests/{"applicationId":"________________________________________________________________","applicationVersion":"________________________________________________________________"}
-hooks/evaluation/executes beforeEvaluation hooks in registration order
-hooks/track/executes afterTrack hooks in registration order

packages/sdk/server-node/contract-tests/testharness-suppressions-fdv2.txt

@@ -11,5 +11,3 @@ streaming/fdv2/reconnection state management/replaces previously known state
 streaming/fdv2/reconnection state management/updates previously known state
 streaming/fdv2/ignores model version
 streaming/fdv2/can discard partial events on errors
-hooks/evaluation/executes beforeEvaluation hooks in registration order
-hooks/track/executes afterTrack hooks in registration order

packages/sdk/server-node/contract-tests/testharness-suppressions.txt

@@ -3,6 +3,4 @@ streaming/validation/drop and reconnect if stream event has well-formed JSON not
 streaming/requests/URL path is computed correctly/environment_filter_key="encoding_not_necessary"/base URI has no trailing slash/GET
 streaming/requests/URL path is computed correctly/environment_filter_key="encoding_not_necessary"/base URI has a trailing slash/GET
 polling/requests/URL path is computed correctly/environment_filter_key="encoding_not_necessary"/base URI has no trailing slash/GET
-polling/requests/URL path is computed correctly/environment_filter_key="encoding_not_necessary"/base URI has a trailing slash/GET
-hooks/evaluation/executes beforeEvaluation hooks in registration order
-hooks/track/executes afterTrack hooks in registration order
+polling/requests/URL path is computed correctly/environment_filter_key="encoding_not_necessary"/base URI has a trailing slash/GET

packages/shared/sdk-client/__tests__/hooks/HookRunner.test.ts

@@ -421,6 +421,6 @@ describe('given a hook runner and test hook', () => {
     expect(afterIdentifyOrder).toEqual(['c', 'b', 'a']);
 
     // Verify track hooks order
-    expect(afterTrackOrder).toEqual(['c', 'b', 'a']);
+    expect(afterTrackOrder).toEqual(['a', 'b', 'c']);
   });
 });