refactor: split types into shared/client/server modules for proper SDK dependency isolation

- src/types/ now contains only SDK-independent types (no LDContext/LDEvaluationReason)
- src/client-side/types/ has client-specific types importing from js-client-sdk-common
- src/server-side/types/ has server-specific types importing from js-server-sdk-common
- server.ts barrel re-exports shared + server types (bigSegments, dataSystem, migrations)
- client.ts barrel re-exports shared + client types (SDKConfigClientSideParams)
- index.ts exports only universal types with no SDK dependency
- server-node contract tests now import CommandParams, CreateInstanceParams, SDKConfigParams from shared package
- Added @launchdarkly/js-server-sdk-common as optional peer dependency

Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>

Author: devin-ai-integration[bot]

packages/sdk/server-node/contract-tests/src/sdkClientEntity.ts

@@ -1,16 +1,19 @@
 import got from 'got';
 
-import { ServerSideTestHook as TestHook } from '@launchdarkly/js-contract-test-utils/server';
+import {
+  CommandParams,
+  CreateInstanceParams,
+  SDKConfigParams,
+  ServerSideTestHook as TestHook,
+} from '@launchdarkly/js-contract-test-utils/server';
 import ld, {
   createMigration,
   DataSourceOptions,
   LDClient,
   LDConcurrentExecution,
   LDContext,
   LDExecutionOrdering,
-  LDFlagValue,
   LDMigrationError,
-  LDMigrationStage,
   LDMigrationSuccess,
   LDOptions,
   LDSerialExecution,
@@ -25,152 +28,7 @@ import { Log, sdkLogger } from './log.js';
 const badCommandError = new Error('unsupported command');
 export { badCommandError };
 
-interface SdkConfigOptions {
-  credential: string;
-  startWaitTimeMs?: number;
-  initCanFail?: boolean;
-  serviceEndpoints?: {
-    streaming?: string;
-    polling?: string;
-    events?: string;
-  };
-  tls?: {
-    skipVerifyPeer?: boolean;
-    customCAFile?: string;
-  };
-  streaming?: {
-    baseUri?: string;
-    initialRetryDelayMs?: number;
-    filter?: string;
-  };
-  polling?: {
-    baseUri?: string;
-    pollIntervalMs?: number;
-    filter?: string;
-  };
-  events?: {
-    baseUri?: string;
-    capacity?: number;
-    enableDiagnostics: boolean;
-    allAttributesPrivate?: boolean;
-    globalPrivateAttributes?: string[];
-    flushIntervalMs?: number;
-    omitAnonymousContexts?: boolean;
-    enableGzip?: boolean;
-  };
-  tags?: {
-    applicationId?: string;
-    applicationVersion?: string;
-  };
-  bigSegments?: {
-    callbackUri: string;
-    userCacheSize?: number;
-    userCacheTimeMs?: number;
-    statusPollIntervalMs?: number;
-    staleAfterMs?: number;
-  };
-  hooks?: {
-    hooks: {
-      name: string;
-      callbackUri: string;
-      data?: Record<string, Record<string, unknown>>;
-      errors?: Record<string, string>;
-    }[];
-  };
-  wrapper?: {
-    name: string;
-    version: string;
-  };
-  proxy?: {
-    httpProxy?: string;
-  };
-  dataSystem?: {
-    initializers?: SDKDataSystemInitializerParams[];
-    synchronizers?: SDKDataSystemSynchronizerParams[];
-    payloadFilter?: string;
-  };
-}
-
-interface CreateInstanceParams {
-  configuration: SdkConfigOptions;
-  tag: string;
-}
-
-export interface SDKDataSystemSynchronizerParams {
-  streaming?: SDKDataSourceStreamingParams;
-  polling?: SDKDataSourcePollingParams;
-}
-
-export interface SDKDataSystemInitializerParams {
-  polling?: SDKDataSourcePollingParams;
-}
-
-export interface SDKDataSourceStreamingParams {
-  baseUri?: string;
-  initialRetryDelayMs?: number;
-}
-
-export interface SDKDataSourcePollingParams {
-  baseUri?: string;
-  pollIntervalMs?: number;
-}
-
-interface CommandParams {
-  command: string;
-  evaluate?: {
-    flagKey: string;
-    context?: LDContext;
-    user?: LDUser;
-    defaultValue: LDFlagValue;
-    detail?: boolean;
-    valueType?: string;
-  };
-  evaluateAll?: {
-    context?: LDContext;
-    user?: LDUser;
-    clientSideOnly?: boolean;
-    detailsOnlyForTrackedFlags?: boolean;
-    withReasons?: boolean;
-  };
-  identifyEvent?: {
-    context?: LDContext;
-    user?: LDUser;
-  };
-  customEvent?: {
-    eventKey: string;
-    context?: LDContext;
-    user?: LDUser;
-    data?: any;
-    metricValue?: number;
-  };
-  migrationVariation?: {
-    key: string;
-    context: LDContext;
-    defaultStage: LDMigrationStage;
-  };
-  migrationOperation?: {
-    operation: string;
-    key: string;
-    context: LDContext;
-    defaultStage: LDMigrationStage;
-    payload: any;
-    readExecutionOrder: string;
-    trackLatency?: boolean;
-    trackErrors?: boolean;
-    trackConsistency?: boolean;
-    newEndpoint: string;
-    oldEndpoint: string;
-  };
-  registerFlagChangeListener?: {
-    listenerId: string;
-    callbackUri: string;
-  };
-  unregisterListener?: {
-    listenerId: string;
-  };
-}
-
-export function makeSdkConfig(options: SdkConfigOptions, tag: string): LDOptions {
+export function makeSdkConfig(options: SDKConfigParams, tag: string): LDOptions {
   const cf: LDOptions = {
     logger: sdkLogger(tag),
     diagnosticOptOut: true,

packages/tooling/contract-test-utils/package.json

@@ -41,10 +41,14 @@
     "@launchdarkly/js-client-sdk-common": "workspace:^"
   },
   "peerDependencies": {
+    "@launchdarkly/js-server-sdk-common": "workspace:^",
     "@launchdarkly/node-server-sdk": "workspace:^",
     "got": "14.4.7"
   },
   "peerDependenciesMeta": {
+    "@launchdarkly/js-server-sdk-common": {
+      "optional": true
+    },
     "@launchdarkly/node-server-sdk": {
       "optional": true
     },

packages/tooling/contract-test-utils/src/client-side/types/CommandParams.ts

@@ -0,0 +1,96 @@
+import { LDContext, LDEvaluationReason } from '@launchdarkly/js-client-sdk-common';
+
+import {
+  CommandType,
+  ContextBuildParams,
+  ContextComparisonPairParams,
+  ContextConvertParams,
+  HookStage,
+  ValueType,
+} from '../../types/CommandParams';
+
+// Re-export shared types for convenience
+export { CommandType, ValueType } from '../../types/CommandParams';
+export type {
+  EvaluateAllFlagsResponse,
+  ContextBuildParams,
+  ContextBuildSingleParams,
+  ContextBuildResponse,
+  ContextConvertParams,
+  ContextComparisonPairParams,
+  ContextComparisonParams,
+  ContextComparisonSingleParams,
+  AttributeDefinition,
+  PrivateAttribute,
+  ContextComparisonResponse,
+  SecureModeHashResponse,
+} from '../../types/CommandParams';
+export { HookStage } from '../../types/CommandParams';
+
+export interface CommandParams {
+  command: CommandType;
+  evaluate?: EvaluateFlagParams;
+  evaluateAll?: EvaluateAllFlagsParams;
+  customEvent?: CustomEventParams;
+  identifyEvent?: IdentifyEventParams;
+  contextBuild?: ContextBuildParams;
+  contextConvert?: ContextConvertParams;
+  contextComparison?: ContextComparisonPairParams;
+  secureModeHash?: SecureModeHashParams;
+}
+
+export interface EvaluateFlagParams {
+  flagKey: string;
+  context?: LDContext;
+  user?: any;
+  valueType: ValueType;
+  defaultValue: unknown;
+  detail: boolean;
+}
+
+export interface EvaluateFlagResponse {
+  value: unknown;
+  variationIndex?: number;
+  reason?: LDEvaluationReason;
+}
+
+export interface EvaluateAllFlagsParams {
+  context?: LDContext;
+  user?: any;
+  withReasons: boolean;
+  clientSideOnly: boolean;
+  detailsOnlyForTrackedFlags: boolean;
+}
+
+export interface CustomEventParams {
+  eventKey: string;
+  context?: LDContext;
+  user?: any;
+  data?: unknown;
+  omitNullData: boolean;
+  metricValue?: number;
+}
+
+export interface IdentifyEventParams {
+  context?: LDContext;
+  user?: any;
+}
+
+export interface SecureModeHashParams {
+  context?: LDContext;
+  user?: any;
+}
+
+export interface EvaluationSeriesContext {
+  flagKey: string;
+  context: LDContext;
+  defaultValue: unknown;
+  method: string;
+}
+
+export interface HookExecutionPayload {
+  evaluationSeriesContext?: EvaluationSeriesContext;
+  evaluationSeriesData?: Record<string, unknown>;
+  evaluationDetail?: EvaluateFlagResponse;
+  stage?: HookStage;
+}

packages/tooling/contract-test-utils/src/client-side/types/ConfigParams.ts

@@ -0,0 +1,57 @@
+import { LDContext } from '@launchdarkly/js-client-sdk-common';
+
+import {
+  SDKConfigEventParams,
+  SDKConfigHooksParams,
+  SDKConfigPollingParams,
+  SDKConfigProxyParams,
+  SDKConfigServiceEndpointsParams,
+  SDKConfigStreamingParams,
+  SDKConfigTagsParams,
+  SDKConfigTLSParams,
+  SDKConfigWrapper,
+} from '../../types/ConfigParams';
+
+// Re-export shared config types for convenience
+export type {
+  SDKConfigTLSParams,
+  SDKConfigServiceEndpointsParams,
+  SDKConfigStreamingParams,
+  SDKConfigPollingParams,
+  SDKConfigEventParams,
+  SDKConfigTagsParams,
+  SDKConfigEvaluationHookData,
+  SDKConfigHookInstance,
+  SDKConfigHooksParams,
+  SDKConfigProxyParams,
+  SDKConfigWrapper,
+} from '../../types/ConfigParams';
+
+export interface SDKConfigClientSideParams {
+  initialContext?: LDContext;
+  initialUser?: any;
+  evaluationReasons?: boolean;
+  useReport?: boolean;
+  includeEnvironmentAttributes?: boolean;
+}
+
+export interface SDKConfigParams {
+  credential: string;
+  startWaitTimeMs?: number; // UnixMillisecondTime
+  initCanFail?: boolean;
+  serviceEndpoints?: SDKConfigServiceEndpointsParams;
+  tls?: SDKConfigTLSParams;
+  streaming?: SDKConfigStreamingParams;
+  polling?: SDKConfigPollingParams;
+  events?: SDKConfigEventParams;
+  tags?: SDKConfigTagsParams;
+  clientSide?: SDKConfigClientSideParams;
+  hooks?: SDKConfigHooksParams;
+  wrapper?: SDKConfigWrapper;
+  proxy?: SDKConfigProxyParams;
+}
+
+export interface CreateInstanceParams {
+  configuration: SDKConfigParams;
+  tag: string;
+}

packages/tooling/contract-test-utils/src/client.ts

@@ -1,5 +1,14 @@
-// Re-export universal exports
-export * from './index';
+// Re-export shared base types (no SDK dependency)
+export * from './types/CommandParams';
+export * from './types/ConfigParams';
+
+// Re-export client-specific types (uses @launchdarkly/js-client-sdk-common)
+export * from './client-side/types/CommandParams';
+export * from './client-side/types/ConfigParams';
+
+// Re-export shared utilities
+export { makeLogger } from './logging/makeLogger';
+export { ClientPool } from './server-side/ClientPool';
 
 // Client-side exports
 export { default as ClientSideTestHook } from './client-side/TestHook';

packages/tooling/contract-test-utils/src/index.ts

@@ -1,20 +1,7 @@
 // Universal exports (no SDK dependency)
+// These types have no references to LDContext or LDEvaluationReason.
+// SDK-specific types are exported from ./client and ./server subpaths.
 export * from './types/CommandParams';
-export {
-  type CreateInstanceParams,
-  type SDKConfigParams,
-  type SDKConfigTLSParams,
-  type SDKConfigServiceEndpointsParams,
-  type SDKConfigStreamingParams,
-  type SDKConfigPollingParams,
-  type SDKConfigEventParams,
-  type SDKConfigTagsParams,
-  type SDKConfigClientSideParams,
-  type SDKConfigEvaluationHookData,
-  type SDKConfigHookInstance,
-  type SDKConfigHooksParams,
-  type SDKConfigProxyParams,
-  type SDKConfigWrapper,
-} from './types/ConfigParams';
+export * from './types/ConfigParams';
 export { makeLogger } from './logging/makeLogger';
 export { ClientPool } from './server-side/ClientPool';