Skip to content

Commit 6e54b30

Browse files
authored
Apply suggestions from code review
Co-authored-by: Jason Bailey <accounts@sidewaysgravity.com>
1 parent 47966f6 commit 6e54b30

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

packages/sdk/server-ai/src/api/judge/Judge.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export class Judge {
5757
* @param input The input prompt or question that was provided to the AI
5858
* @param output The AI-generated response to be evaluated
5959
* @param samplingRate Sampling rate (0-1) to determine if evaluation should be processed (defaults to 1)
60-
* @returns Promise that resolves to evaluation results; always returns a result, never undefined
60+
* @returns Promise that resolves to evaluation results
6161
*/
6262
async evaluate(input: string, output: string, samplingRate: number = 1): Promise<LDJudgeResult> {
6363
const result = defaultJudgeResult();
@@ -126,7 +126,7 @@ export class Judge {
126126
* @param messages Array of messages representing the conversation history
127127
* @param response The AI response to be evaluated
128128
* @param samplingRatio Sampling ratio (0-1) to determine if evaluation should be processed (defaults to 1)
129-
* @returns Promise that resolves to evaluation results; always returns a result, never undefined
129+
* @returns Promise that resolves to evaluation results
130130
*/
131131
async evaluateMessages(
132132
messages: LDMessage[],

packages/sdk/server-ai/src/api/judge/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export interface StructuredResponse {
1717
}
1818

1919
/**
20-
* Flat result from a judge evaluation containing score, reasoning, and metadata.
20+
* Result from a judge evaluation containing score, reasoning, and metadata.
2121
*/
2222
export interface LDJudgeResult {
2323
/** The key of the judge configuration that was used to generate this result */

0 commit comments

Comments
 (0)