Commit 73aee9c
authored
ci: fixing flaky CI (#1302)
This PR will apply the same fix as we did for
`.github/workflows/react.yml` to stablize the CI jobs.
The underlying issue is that electron binary installation is expensive
and would some times flake out. The fix here is to skip the binary setup
for workflows that do not need it.
The reason this is a problem is that we need to do a `workspace ...
install` on contract test installations (as `workspaces focus` does some
funny things to non-prod dependencies that may interfere with building
the contract tests). Unfortunately, in `yarn`, `workspace... install`
does the same thing as `yarn install` (installs all deps).
<!-- devin-review-badge-begin -->
---
<a href="https://app.devin.ai/review/launchdarkly/js-core/pull/1302"
target="_blank">
<picture>
<source media="(prefers-color-scheme: dark)"
srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1">
<img
src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1"
alt="Open in Devin Review">
</picture>
</a>
<!-- devin-review-badge-end -->
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Low risk CI-only change that alters dependency install environment for
contract-test services; main risk is an unexpected package needing
Electron in these jobs.
>
> **Overview**
> Reduces flakiness in the `server-node` and `shopify-oxygen` GitHub
Actions workflows by setting `ELECTRON_SKIP_BINARY_DOWNLOAD=1` for the
contract-test service `yarn workspace ... install` step.
>
> This avoids unnecessary Electron binary downloads during CI installs
while keeping the rest of the contract-test build and execution flow
unchanged.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
c320ff7. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent dbb2762 commit 73aee9c
2 files changed
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| 35 | + | |
| 36 | + | |
35 | 37 | | |
36 | 38 | | |
37 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
| 31 | + | |
30 | 32 | | |
31 | 33 | | |
32 | 34 | | |
| |||
0 commit comments