feat!: Remove deprecated LDAIClient method aliases (#1370)

feat!: Remove `LDAIClient.config` — use `LDAIClient.completionConfig` instead
feat!: Remove `LDAIClient.agent` — use `LDAIClient.agentConfig` instead
feat!: Remove `LDAIClient.agents` — use `LDAIClient.agentConfigs` instead
feat!: Remove `LDAIClient.createChat` — use `LDAIClient.createModel` instead
feat!: Remove `LDAIClient.initChat` — use `LDAIClient.createModel` instead
feat!: Remove `ChatResponse` type and the `api/chat` module — use `RunnerResult` from `api/model` instead
feat!: Change `Judge.evaluateMessages` parameter type from `ChatResponse` to `RunnerResult`
feat!: Remove `evaluationMetricKeys` (plural) field from `LDAIJudgeConfig` and `LDAIJudgeConfigDefault` — use `evaluationMetricKey` (singular) instead; the wire-read fallback still accepts the plural in flag variations for backward compatibility
feat!: Remove `LDAIConfigTracker.trackOpenAIMetrics` — use `tracker.trackMetricsOf(getAIMetricsFromResponse, fn)` from `@launchdarkly/server-sdk-ai-openai` instead
feat!: Remove `LDAIConfigTracker.trackVercelAISDKGenerateTextMetrics` —
use `tracker.trackMetricsOf(getAIMetricsFromResponse, fn)` from `@launchdarkly/server-sdk-ai-vercel` instead
feat!: Remove `createOpenAiUsage` helper — no longer needed; `trackMetricsOf` extracts usage
feat!: Remove `createVercelAISDKTokenUsage` helper — no longer needed; `trackMetricsOf` extracts usage

Author: jsonbailey

packages/sdk/server-ai/__tests__/Judge.test.ts

@@ -318,11 +318,10 @@ describe('Judge', () => {
       Math.random = originalRandom;
     });
 
-    it('returns error result when evaluationMetricKey and evaluationMetricKeys are both missing', async () => {
+    it('returns error result when evaluationMetricKey is missing', async () => {
       const configWithoutMetrics: LDAIJudgeConfig = {
         ...judgeConfig,
         evaluationMetricKey: undefined,
-        evaluationMetricKeys: [],
       };
       const judgeWithoutMetrics = new Judge(configWithoutMetrics, mockRunner, 1.0, mockLogger);
 
@@ -344,7 +343,6 @@ describe('Judge', () => {
       const configWithSingleKey: LDAIJudgeConfig = {
         ...judgeConfig,
         evaluationMetricKey: 'relevance',
-        evaluationMetricKeys: undefined,
       };
       const judgeWithSingleKey = new Judge(configWithSingleKey, mockRunner, 1.0, mockLogger);
 
@@ -375,112 +373,6 @@ describe('Judge', () => {
       });
     });
 
-    it('falls back to first value in evaluationMetricKeys when evaluationMetricKey is not provided', async () => {
-      const configWithLegacyKeys: LDAIJudgeConfig = {
-        ...judgeConfig,
-        evaluationMetricKey: undefined,
-        evaluationMetricKeys: ['relevance', 'accuracy'],
-      };
-      const judgeWithLegacyKeys = new Judge(configWithLegacyKeys, mockRunner, 1.0, mockLogger);
-
-      const mockRunnerResult: RunnerResult = {
-        content: '',
-        parsed: {
-          score: 0.8,
-          reasoning: 'The response is relevant',
-        },
-        metrics: {
-          success: true,
-          tokens: { total: 100, input: 50, output: 50 },
-        },
-      };
-
-      mockTracker.trackMetricsOf.mockImplementation(async (extractor, func) => func());
-      mockRunner.run.mockResolvedValue(mockRunnerResult);
-
-      const result = await judgeWithLegacyKeys.evaluate('test input', 'test output');
-
-      expect(result).toEqual({
-        score: 0.8,
-        reasoning: 'The response is relevant',
-        metricKey: 'relevance',
-        success: true,
-        sampled: true,
-        judgeConfigKey: 'test-judge',
-      });
-    });
-
-    it('skips empty and whitespace-only strings in evaluationMetricKeys array', async () => {
-      const configWithInvalidKeys: LDAIJudgeConfig = {
-        ...judgeConfig,
-        evaluationMetricKey: undefined,
-        evaluationMetricKeys: ['', '   ', 'relevance', 'accuracy'],
-      };
-      const judgeWithInvalidKeys = new Judge(configWithInvalidKeys, mockRunner, 1.0, mockLogger);
-
-      const mockRunnerResult: RunnerResult = {
-        content: '',
-        parsed: {
-          score: 0.8,
-          reasoning: 'The response is relevant',
-        },
-        metrics: {
-          success: true,
-          tokens: { total: 100, input: 50, output: 50 },
-        },
-      };
-
-      mockTracker.trackMetricsOf.mockImplementation(async (extractor, func) => func());
-      mockRunner.run.mockResolvedValue(mockRunnerResult);
-
-      const result = await judgeWithInvalidKeys.evaluate('test input', 'test output');
-
-      // Should skip empty and whitespace strings, use first valid value
-      expect(result).toEqual({
-        score: 0.8,
-        reasoning: 'The response is relevant',
-        metricKey: 'relevance',
-        success: true,
-        sampled: true,
-        judgeConfigKey: 'test-judge',
-      });
-    });
-
-    it('prioritizes evaluationMetricKey over evaluationMetricKeys when both are provided', async () => {
-      const configWithBoth: LDAIJudgeConfig = {
-        ...judgeConfig,
-        evaluationMetricKey: 'helpfulness',
-        evaluationMetricKeys: ['relevance', 'accuracy'],
-      };
-      const judgeWithBoth = new Judge(configWithBoth, mockRunner, 1.0, mockLogger);
-
-      const mockRunnerResult: RunnerResult = {
-        content: '',
-        parsed: {
-          score: 0.7,
-          reasoning: 'The response is helpful',
-        },
-        metrics: {
-          success: true,
-          tokens: { total: 100, input: 50, output: 50 },
-        },
-      };
-
-      mockTracker.trackMetricsOf.mockImplementation(async (extractor, func) => func());
-      mockRunner.run.mockResolvedValue(mockRunnerResult);
-
-      const result = await judgeWithBoth.evaluate('test input', 'test output');
-
-      expect(result).toEqual({
-        score: 0.7,
-        reasoning: 'The response is helpful',
-        metricKey: 'helpfulness',
-        success: true,
-        sampled: true,
-        judgeConfigKey: 'test-judge',
-      });
-    });
-
     it('proceeds (does not error early) when messages is undefined', async () => {
       const configWithoutMessages: LDAIJudgeConfig = {
         ...judgeConfig,
@@ -629,8 +521,8 @@ describe('Judge', () => {
         { role: 'user', content: 'What is the capital of France?' },
         { role: 'assistant', content: 'Paris is the capital of France.' },
       ];
-      const response = {
-        message: { role: 'assistant' as const, content: 'Paris is the capital of France.' },
+      const response: RunnerResult = {
+        content: 'Paris is the capital of France.',
         metrics: { success: true },
       };
 
@@ -668,8 +560,8 @@ describe('Judge', () => {
 
     it('handles sampling rate correctly', async () => {
       const messages: LDMessage[] = [{ role: 'user', content: 'test' }];
-      const response = {
-        message: { role: 'assistant' as const, content: 'test response' },
+      const response: RunnerResult = {
+        content: 'test response',
         metrics: { success: true },
       };
 
@@ -774,26 +666,5 @@ describe('Judge', () => {
       expect(result).toBeUndefined();
     });
 
-    it('handles empty evaluationMetricKeys array fallback', async () => {
-      const configWithEmptyKeys: LDAIJudgeConfig = {
-        ...judgeConfig,
-        evaluationMetricKey: undefined,
-        evaluationMetricKeys: [],
-      };
-      const judgeWithEmptyKeys = new Judge(configWithEmptyKeys, mockRunner, 1.0, mockLogger);
-
-      const result = await judgeWithEmptyKeys.evaluate('test input', 'test output');
-
-      expect(result).toEqual({
-        success: false,
-        sampled: true,
-        errorMessage: 'Judge configuration is missing required evaluation metric key',
-        judgeConfigKey: 'test-judge',
-      });
-      expect(mockLogger.warn).toHaveBeenCalledWith(
-        'Judge configuration is missing required evaluation metric key',
-        mockTrackData,
-      );
-    });
   });
 });

packages/sdk/server-ai/__tests__/LDAIClientImpl.test.ts

@@ -627,7 +627,7 @@ describe('judgeConfig method', () => {
       enabled: true,
       model: { name: 'gpt-4' },
       provider: { name: 'openai' },
-      evaluationMetricKeys: ['relevance'],
+      evaluationMetricKey: 'relevance',
       messages: [{ role: 'system' as const, content: 'You are a judge for {{metric}}.' }],
       createTracker: () => ({}) as any,
       toVercelAISDK: jest.fn(),
@@ -720,7 +720,7 @@ describe('createJudge method', () => {
       enabled: true,
       model: { name: 'gpt-4' },
       provider: { name: 'openai' },
-      evaluationMetricKeys: ['relevance', 'accuracy'],
+      evaluationMetricKey: 'relevance',
       messages: [{ role: 'system' as const, content: 'You are a judge.' }],
       createTracker: () => mockTrackerInstance,
       toVercelAISDK: jest.fn(),
@@ -754,7 +754,6 @@ describe('createJudge method', () => {
     const mockJudgeConfig = {
       key: 'test-judge',
       enabled: false,
-      evaluationMetricKeys: [],
     };
 
     const judgeConfigSpy = jest.spyOn(client as any, '_judgeConfig');
@@ -780,7 +779,7 @@ describe('createJudge method', () => {
       enabled: true,
       model: { name: 'gpt-4' },
       provider: { name: 'openai' },
-      evaluationMetricKeys: ['relevance'],
+      evaluationMetricKey: 'relevance',
       messages: [{ role: 'system' as const, content: 'You are a judge.' }],
       createTracker: () => ({}) as any,
       toVercelAISDK: jest.fn(),