chore: remove trackJudgeResult from graph tracker and fix judgeConfigKey spread (#1296)

Author: jsonbailey

packages/sdk/server-ai/__tests__/LDGraphTrackerImpl.test.ts

@@ -241,71 +241,6 @@ it('drops second trackPath call and warns', () => {
   expect(mockWarn).toHaveBeenCalled();
 });
 
-// ---------------------------------------------------------------------------
-// trackJudgeResult – NOT at-most-once
-// ---------------------------------------------------------------------------
-
-it('trackJudgeResult emits an event for a sampled, successful result', () => {
-  const tracker = makeTracker('r');
-  tracker.trackJudgeResult({
-    judgeConfigKey: 'judge-1',
-    metricKey: 'relevance-score',
-    score: 0.9,
-    reasoning: 'good',
-    success: true,
-    sampled: true,
-  });
-  expect(mockTrack).toHaveBeenCalledTimes(1);
-  expect(mockTrack).toHaveBeenCalledWith(
-    'relevance-score',
-    testContext,
-    { ...tracker.getTrackData(), judgeConfigKey: 'judge-1' },
-    0.9,
-  );
-});
-
-it('trackJudgeResult emits event without judgeConfigKey', () => {
-  const tracker = makeTracker('r');
-  tracker.trackJudgeResult({
-    metricKey: 'relevance-score',
-    score: 0.7,
-    success: true,
-    sampled: true,
-  });
-  expect(mockTrack).toHaveBeenCalledWith(
-    'relevance-score',
-    testContext,
-    tracker.getTrackData(),
-    0.7,
-  );
-});
-
-it('trackJudgeResult can fire multiple times', () => {
-  const tracker = makeTracker('r');
-  tracker.trackJudgeResult({ metricKey: 'relevance', score: 0.5, success: true, sampled: true });
-  tracker.trackJudgeResult({ metricKey: 'relevance', score: 0.7, success: true, sampled: true });
-  expect(mockTrack).toHaveBeenCalledTimes(2);
-  expect(mockWarn).not.toHaveBeenCalled();
-});
-
-it('trackJudgeResult does not emit when not sampled', () => {
-  const tracker = makeTracker('r');
-  tracker.trackJudgeResult({ judgeConfigKey: 'j', success: false, sampled: false });
-  expect(mockTrack).not.toHaveBeenCalled();
-});
-
-it('trackJudgeResult does not emit when success is false', () => {
-  const tracker = makeTracker('r');
-  tracker.trackJudgeResult({
-    judgeConfigKey: 'j',
-    metricKey: 'relevance',
-    score: 0.9,
-    success: false,
-    sampled: true,
-  });
-  expect(mockTrack).not.toHaveBeenCalled();
-});
-
 // ---------------------------------------------------------------------------
 // Edge-level methods – multi-fire, NOT at-most-once
 // ---------------------------------------------------------------------------

packages/sdk/server-ai/src/LDAIConfigTrackerImpl.ts

@@ -124,12 +124,10 @@ export class LDAIConfigTrackerImpl implements LDAIConfigTracker {
       return;
     }
     if (result.metricKey !== undefined && result.score !== undefined) {
-      this._ldClient.track(
-        result.metricKey,
-        this._context,
-        { ...this.getTrackData(), judgeConfigKey: result.judgeConfigKey },
-        result.score,
-      );
+      const trackData = result.judgeConfigKey
+        ? { ...this.getTrackData(), judgeConfigKey: result.judgeConfigKey }
+        : this.getTrackData();
+      this._ldClient.track(result.metricKey, this._context, trackData, result.score);
     }
   }
 

packages/sdk/server-ai/src/LDGraphTrackerImpl.ts

@@ -2,7 +2,6 @@ import type { LDContext } from '@launchdarkly/js-server-sdk-common';
 
 import type { LDGraphTracker } from './api/graph/LDGraphTracker';
 import type { LDGraphMetricSummary, LDGraphTrackData } from './api/graph/types';
-import type { LDJudgeResult } from './api/judge/types';
 import type { LDTokenUsage } from './api/metrics';
 import type { LDClientMin } from './LDClientMin';
 
@@ -143,19 +142,6 @@ export class LDGraphTrackerImpl implements LDGraphTracker {
     this._ldClient.track('$ld:ai:graph:path', this._context, { ...this.getTrackData(), path }, 1);
   }
 
-  trackJudgeResult(result: LDJudgeResult): void {
-    if (!result.sampled || !result.success) {
-      return;
-    }
-    if (result.metricKey !== undefined && result.score !== undefined) {
-      const trackData = result.judgeConfigKey
-        ? { ...this.getTrackData(), judgeConfigKey: result.judgeConfigKey }
-        : this.getTrackData();
-
-      this._ldClient.track(result.metricKey, this._context, trackData, result.score);
-    }
-  }
-
   trackRedirect(sourceKey: string, redirectedTarget: string): void {
     this._ldClient.track(
       '$ld:ai:graph:redirect',

packages/sdk/server-ai/src/api/graph/LDGraphTracker.ts

@@ -1,4 +1,3 @@
-import type { LDJudgeResult } from '../judge/types';
 import type { LDTokenUsage } from '../metrics';
 import type { LDGraphMetricSummary, LDGraphTrackData } from './types';
 
@@ -90,15 +89,6 @@ export interface LDGraphTracker {
    */
   trackPath(path: string[]): void;
 
-  /**
-   * Tracks a judge evaluation result for the final graph output.
-   * Emits one LDClient.track call when the result was sampled and successful.
-   * Not subject to at-most-once constraints.
-   *
-   * @param result Judge result containing score, reasoning, and metadata.
-   */
-  trackJudgeResult(result: LDJudgeResult): void;
-
   // -------------------------------------------------------------------------
   // Edge-level tracking methods (multi-fire, not at-most-once)
   // -------------------------------------------------------------------------