fix: explicit return types and TS6 source compatibility fixes

Author: joker23

packages/sdk/fastly/src/api/createOptions.ts

@@ -8,7 +8,7 @@ export const defaultOptions: LDOptions = {
   logger: BasicLogger.get(),
 };
 
-const createOptions = (options: LDOptions) => {
+const createOptions = (options: LDOptions): LDOptions => {
   const finalOptions = { ...defaultOptions, ...options };
 
   // The Fastly SDK does not poll LaunchDarkly for updates, so a custom baseUri does not make sense. However, we need

packages/sdk/react/tsconfig.build.json

@@ -0,0 +1,6 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "ignoreDeprecations": "6.0"
+  }
+}

packages/sdk/react/tsup.config.js

@@ -12,6 +12,7 @@ const sharedOptions = {
     '@launchdarkly/js-server-sdk',
   ],
   dts: true,
+  tsconfig: 'tsconfig.build.json',
   metafile: true,
 };
 

packages/sdk/shopify-oxygen/src/utils/createOptions.ts

@@ -26,7 +26,7 @@ export const defaultOptions: LDOptions & OxygenLDOptions = {
   },
 };
 
-export const createOptions = (options: LDOptions & OxygenLDOptions = {}) => {
+export const createOptions = (options: LDOptions & OxygenLDOptions = {}): LDOptions & OxygenLDOptions => {
   const finalOptions = {
     ...defaultOptions,
     ...options,

packages/shared/akamai-edgeworker-sdk/src/utils/createOptions.ts

@@ -8,7 +8,7 @@ export const defaultOptions: LDOptions = {
   logger: BasicLogger.get(),
 };
 
-export const createOptions = (options: LDOptions) => {
+export const createOptions = (options: LDOptions): LDOptions => {
   const finalOptions = { ...defaultOptions, ...options };
   finalOptions.logger?.debug(`Using LD options: ${JSON.stringify(finalOptions)}`);
   return finalOptions;

packages/shared/common/__tests__/internal/events/EventProcessor.test.ts

@@ -50,6 +50,7 @@ const mockSendEventData = jest.fn();
 jest.useFakeTimers();
 
 jest.mock('../../../src/internal/events/EventSender', () => ({
+  __esModule: true,
   default: jest.fn(() => ({
     sendEventData: mockSendEventData,
   })),

packages/shared/sdk-server-edge/src/api/createOptions.ts

@@ -8,6 +8,6 @@ export const defaultOptions: LDOptions = {
   logger: BasicLogger.get(),
 };
 
-const createOptions = (options: LDOptions) => ({ ...defaultOptions, ...options });
+const createOptions = (options: LDOptions): LDOptions => ({ ...defaultOptions, ...options });
 
 export default createOptions;

packages/shared/sdk-server/src/store/sortDataSet.ts

@@ -51,7 +51,7 @@ function topologicalSort(
 
   while (unvisitedItems.size > 0) {
     // Visit the next item, the order we visit doesn't matter.
-    const key = unvisitedItems.values().next().value;
+    const key = unvisitedItems.values().next().value!;
     visit(key);
   }
   return sortedItems;