refactor: simplify type deduplication using compat.ts pattern from PR #1151

- Add src/types/compat.ts with minimal LDContext and LDEvaluationReason types
  compatible with both client and server SDKs (no SDK imports needed)
- Merge all types back into unified CommandParams.ts and ConfigParams.ts
  (includes both client-specific and server-specific fields)
- Delete src/client-side/types/ and src/server-side/types/ directories
  (no longer needed with compat types approach)
- Simplify barrel exports: client.ts re-exports from index, server.ts
  re-exports from types/ directly
- Remove @launchdarkly/js-server-sdk-common peer dependency
- Add necessary casts in server-node consumer for SDK-specific types

Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>

Author: devin-ai-integration[bot]

packages/sdk/server-node/contract-tests/src/sdkClientEntity.ts

@@ -14,6 +14,7 @@ import ld, {
   LDContext,
   LDExecutionOrdering,
   LDMigrationError,
+  LDMigrationStage,
   LDMigrationSuccess,
   LDOptions,
   LDSerialExecution,
@@ -251,12 +252,12 @@ export async function newSdkClientEntity(options: CreateInstanceParams): Promise
         if (pe.detail) {
           switch (pe.valueType) {
             case 'bool':
-              return client.boolVariationDetail(pe.flagKey, context, pe.defaultValue);
+              return client.boolVariationDetail(pe.flagKey, context, pe.defaultValue as boolean);
             case 'int': // Intentional fallthrough.
             case 'double':
-              return client.numberVariationDetail(pe.flagKey, context, pe.defaultValue);
+              return client.numberVariationDetail(pe.flagKey, context, pe.defaultValue as number);
             case 'string':
-              return client.stringVariationDetail(pe.flagKey, context, pe.defaultValue);
+              return client.stringVariationDetail(pe.flagKey, context, pe.defaultValue as string);
             default:
               return client.variationDetail(
                 pe.flagKey,
@@ -268,16 +269,16 @@ export async function newSdkClientEntity(options: CreateInstanceParams): Promise
           switch (pe.valueType) {
             case 'bool':
               return {
-                value: await client.boolVariation(pe.flagKey, context, pe.defaultValue),
+                value: await client.boolVariation(pe.flagKey, context, pe.defaultValue as boolean),
               };
             case 'int': // Intentional fallthrough.
             case 'double':
               return {
-                value: await client.numberVariation(pe.flagKey, context, pe.defaultValue),
+                value: await client.numberVariation(pe.flagKey, context, pe.defaultValue as number),
               };
             case 'string':
               return {
-                value: await client.stringVariation(pe.flagKey, context, pe.defaultValue),
+                value: await client.stringVariation(pe.flagKey, context, pe.defaultValue as string),
               };
             default:
               return {
@@ -319,7 +320,7 @@ export async function newSdkClientEntity(options: CreateInstanceParams): Promise
         const res = await client.migrationVariation(
           migrationVariation.key,
           migrationVariation.context,
-          migrationVariation.defaultStage,
+          migrationVariation.defaultStage as LDMigrationStage,
         );
         return { result: res.value };
       }
@@ -384,7 +385,7 @@ export async function newSdkClientEntity(options: CreateInstanceParams): Promise
             const res = await migration.read(
               migrationOperation.key,
               migrationOperation.context,
-              migrationOperation.defaultStage,
+              migrationOperation.defaultStage as LDMigrationStage,
               migrationOperation.payload,
             );
             if (res.success) {
@@ -396,7 +397,7 @@ export async function newSdkClientEntity(options: CreateInstanceParams): Promise
             const res = await migration.write(
               migrationOperation.key,
               migrationOperation.context,
-              migrationOperation.defaultStage,
+              migrationOperation.defaultStage as LDMigrationStage,
               migrationOperation.payload,
             );
 

packages/tooling/contract-test-utils/package.json

@@ -41,14 +41,10 @@
     "@launchdarkly/js-client-sdk-common": "workspace:^"
   },
   "peerDependencies": {
-    "@launchdarkly/js-server-sdk-common": "workspace:^",
     "@launchdarkly/node-server-sdk": "workspace:^",
     "got": "14.4.7"
   },
   "peerDependenciesMeta": {
-    "@launchdarkly/js-server-sdk-common": {
-      "optional": true
-    },
     "@launchdarkly/node-server-sdk": {
       "optional": true
     },

packages/tooling/contract-test-utils/src/client-side/types/CommandParams.ts

@@ -1,14 +1,5 @@
-// Re-export shared base types (no SDK dependency)
-export * from './types/CommandParams';
-export * from './types/ConfigParams';
-
-// Re-export client-specific types (uses @launchdarkly/js-client-sdk-common)
-export * from './client-side/types/CommandParams';
-export * from './client-side/types/ConfigParams';
-
-// Re-export shared utilities
-export { makeLogger } from './logging/makeLogger';
-export { ClientPool } from './server-side/ClientPool';
+// Re-export universal exports
+export * from './index';
 
 // Client-side exports
 export { default as ClientSideTestHook } from './client-side/TestHook';

packages/tooling/contract-test-utils/src/client-side/types/ConfigParams.ts

@@ -1,6 +1,4 @@
-// Universal exports (no SDK dependency)
-// These types have no references to LDContext or LDEvaluationReason.
-// SDK-specific types are exported from ./client and ./server subpaths.
+// Universal exports (types use minimal compat types, no SDK dependency)
 export * from './types/CommandParams';
 export * from './types/ConfigParams';
 export { makeLogger } from './logging/makeLogger';