Skip to content

Commit cead374

Browse files
committed
chore: fixed up some comments
1 parent 7665e4f commit cead374

3 files changed

Lines changed: 3 additions & 12 deletions

File tree

packages/sdk/react/contract-tests/app/ClientEntity.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,8 @@ import { useLDClient } from '@launchdarkly/react-sdk';
1111

1212
export type CommandHandler = (params: CommandParams) => Promise<unknown>;
1313

14-
/**
15-
* Creates an IClientEntity wrapper for a React-managed client.
16-
* The entity's doCommand delegates to the command handler registered
17-
* by ClientInstance once the React component mounts.
18-
*/
14+
// We are creating this wrapper because we have a custom commandHandler implementation to work well
15+
// with React rendering.
1916
export function createReactClientEntity(
2017
clientId: string,
2118
commandHandlers: Map<string, CommandHandler>,

packages/tooling/contract-test-utils/src/client-side/ClientEntity.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,7 @@ import { IClientEntity } from './TestHarnessWebSocket.js';
77

88
/**
99
* Base client entity that wraps an SDK client and dispatches test harness
10-
* commands. Suitable for browser, react-native, and electron entities.
11-
*
12-
* Subclass and override `doCommand` to customize command handling for
13-
* platform-specific behavior.
10+
* commands.
1411
*/
1512
export class ClientEntity implements IClientEntity {
1613
protected readonly logger: LDLogger;

packages/tooling/contract-test-utils/src/client-side/capabilities.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
/**
22
* Known capability strings from the SDK test harness service spec.
33
* See: https://github.com/launchdarkly/sdk-test-harness/blob/v2/docs/service_spec.md
4-
*
5-
* Each entity should define its own capabilities array typed against this union,
6-
* since different SDKs advertise different capabilities.
74
*/
85
export type Capability =
96
| 'server-side'

0 commit comments

Comments
 (0)