Commit d7ed722
fix(cloudflare): bundle tslib with esm module (#1292)
**Related issues**
#1291
**Describe the solution you've provided**
Ensure that tslib is excluded from the bundling exclusion list.
**Additional context**
I've recreated and ensured that this fix is working when done against a
module tgz generated by `npm pack`. This _should_ prove efficacy, but
wouldn't know for sure until we publish the fix.
I also checked to see if any other modules are referenced in this way
and tslib is the only once, which makes sense because it was probably
hoisted to root node_modules.
<!-- devin-review-badge-begin -->
---
<a href="https://app.devin.ai/review/launchdarkly/js-core/pull/1292"
target="_blank">
<picture>
<source media="(prefers-color-scheme: dark)"
srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1">
<img
src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1"
alt="Open in Devin Review">
</picture>
</a>
<!-- devin-review-badge-end -->
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Build configuration-only change limited to Rollup externals; risk is
mainly altered bundle contents/size or unexpected dependency inclusion.
>
> **Overview**
> Updates the Cloudflare SDK Rollup config to **bundle `tslib`** by
excluding it from the generic `/node_modules/` externalization rule,
while still keeping other `node_modules` packages external and
continuing to inline `js-core` dependencies.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
70c9f87. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
---------
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>1 parent 7625cb9 commit d7ed722
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
15 | 19 | | |
16 | 20 | | |
17 | 21 | | |
| |||
0 commit comments