Commit d96b46b
authored
fix: Improve error handling for FDv2 streaming (#1184)
BEGIN_COMMIT_OVERRIDE
fix: Improve error handling for FDv2 streaming
fix: Allow 0 status code to be handled by the streaming error filter.
END_COMMIT_OVERRIDE
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Changes reconnection/error classification logic in the streaming data
source, which could affect when clients retry vs surface interruptions.
Risk is moderate because it impacts core connectivity behavior but is
localized and guarded by existing error filters.
>
> **Overview**
> Improves streaming error handling so *any numeric* `err.status`
(including `0`) is routed through the EventSource `errorFilter` rather
than being treated as a missing-status/network error.
>
> Reduces noise and false failures by (1) not warning when FDv2
`'error'` events arrive without a body, and (2) only queuing a network
interruption on `es.onerror` when no numeric HTTP status is present
(letting the filter handle status-bearing errors).
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
28ac8cf. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent cd4b119 commit d96b46b
2 files changed
Lines changed: 17 additions & 4 deletions
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
| 100 | + | |
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| |||
Lines changed: 16 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
188 | 188 | | |
189 | 189 | | |
190 | 190 | | |
191 | | - | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
192 | 195 | | |
193 | 196 | | |
194 | 197 | | |
| |||
277 | 280 | | |
278 | 281 | | |
279 | 282 | | |
280 | | - | |
281 | | - | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
282 | 295 | | |
283 | 296 | | |
284 | 297 | | |
| |||
0 commit comments