chore: bot comments

Author: joker23

packages/sdk/browser/contract-tests/entity/src/ClientEntity.ts

@@ -76,8 +76,7 @@ export async function newSdkClientEntity(
   const config = new ConfigBuilder(options).set({ fetchGoals: false });
 
   if (options.configuration.dataSystem) {
-    // FDv2: skip legacy streaming — data system handles connection modes
-    config.skip('streaming');
+    config.skip('streaming', 'polling');
 
     const isSet = (x?: unknown) => x !== null && x !== undefined;
     const maybeTime = (seconds?: number) => (isSet(seconds) ? seconds! / 1000 : undefined);

packages/sdk/react-native/contract-tests/entity/src/ClientEntity.ts

@@ -15,7 +15,7 @@ export async function newSdkClientEntity(
   _id: string,
   options: CreateInstanceParams,
 ): Promise<IClientEntity> {
-  const config = new ConfigBuilder(options).skip('streaming').set({
+  const config = new ConfigBuilder(options).omit('streaming').set({
     automaticNetworkHandling: false,
     automaticBackgroundHandling: false,
     ...(options.configuration.polling && { initialConnectionMode: 'polling' }),

packages/sdk/react/contract-tests/app/ClientRoot.tsx

@@ -1,6 +1,6 @@
 'use client';
 
-import React, { useEffect, useRef, useState } from 'react';
+import React, { useEffect, useState } from 'react';
 
 import {
   Capability,
@@ -37,16 +37,18 @@ const CAPABILITIES: Capability[] = [
   'track-hooks',
 ];
 
-export default function ClientRoot({ children }: { children: React.ReactNode }) {
-  const [clients, setClients] = useState<ClientRecord[]>([]);
-  const commandHandlers = useRef(new Map<string, CommandHandler>());
-  const handlerReadyMap = useRef(new Map<string, () => void>());
-  const clientsRef = useRef<ClientRecord[]>([]);
-  const entityMap = useRef(new Map<string, IClientEntity>());
+const commandHandlers = new Map<string, CommandHandler>();
+const handlerReadyMap = new Map<string, () => void>();
+const entityMap = new Map<string, IClientEntity>();
+let clientRecords: ClientRecord[] = [];
+
+function onReady(readyId: string) {
+  handlerReadyMap.get(readyId)?.();
+}
 
-  const onReady = (readyId: string) => {
-    handlerReadyMap.current.get(readyId)?.();
-  };
+export default function ClientRoot({ children }: { children: React.ReactNode }) {
+  const [, setRenderTick] = useState(0);
+  const rerender = () => setRenderTick((n) => n + 1);
 
   useEffect(() => {
     const ws = new TestHarnessWebSocketBuilder()
@@ -70,25 +72,25 @@ export default function ClientRoot({ children }: { children: React.ReactNode })
         const Provider = createLDReactProviderWithClient(client);
 
         const handlerReady = new Promise<void>((resolve) => {
-          handlerReadyMap.current.set(id, resolve);
+          handlerReadyMap.set(id, resolve);
         });
 
-        clientsRef.current = [...clientsRef.current, { id, client, Provider }];
-        setClients([...clientsRef.current]);
+        clientRecords = [...clientRecords, { id, client, Provider }];
+        rerender();
 
         await handlerReady;
-        handlerReadyMap.current.delete(id);
+        handlerReadyMap.delete(id);
 
-        const entity = createReactClientEntity(id, commandHandlers.current, () => client.close());
-        entityMap.current.set(id, entity);
+        const entity = createReactClientEntity(id, commandHandlers, () => client.close());
+        entityMap.set(id, entity);
         return entity;
       })
-      .onGetClient((id) => entityMap.current.get(id))
+      .onGetClient((id) => entityMap.get(id))
       .onDeleteClient((id) => {
-        entityMap.current.delete(id);
-        clientsRef.current.find((r) => r.id === id)?.client.close();
-        clientsRef.current = clientsRef.current.filter((r) => r.id !== id);
-        setClients((prev) => prev.filter((r) => r.id !== id));
+        entityMap.delete(id);
+        clientRecords.find((r) => r.id === id)?.client.close();
+        clientRecords = clientRecords.filter((r) => r.id !== id);
+        rerender();
       })
       .build();
 
@@ -99,9 +101,9 @@ export default function ClientRoot({ children }: { children: React.ReactNode })
   return (
     <>
       {children}
-      {clients.map(({ id, Provider }) => (
+      {clientRecords.map(({ id, Provider }) => (
         <Provider key={id}>
-          <ClientInstance clientId={id} handlers={commandHandlers.current} onReady={onReady} />
+          <ClientInstance clientId={id} handlers={commandHandlers} onReady={onReady} />
         </Provider>
       ))}
     </>

packages/tooling/contract-test-utils/src/client-side/ConfigBuilder.ts

@@ -55,6 +55,7 @@ export class ConfigBuilder {
   private _configuration: SDKConfigParams;
   private _tag: string;
   private _skippedSections: Set<ConfigSection> = new Set();
+  private _omittedKeys: Set<string> = new Set();
   private _overrides: Record<string, unknown> = {};
 
   constructor(options: CreateInstanceParams) {
@@ -98,6 +99,13 @@ export class ConfigBuilder {
     return this;
   }
 
+  /** Remove specific keys from the built output. Unlike skip(), the section
+   *  still runs — only the named keys are deleted from the result. */
+  omit(...keys: string[]): this {
+    keys.forEach((k) => this._omittedKeys.add(k));
+    return this;
+  }
+
   /** Add or override fields on the final config object. Applied last. */
   set(values: Record<string, unknown>): this {
     Object.assign(this._overrides, values);
@@ -166,7 +174,9 @@ export class ConfigBuilder {
       );
     }
 
-    return { ...cf, ...this._overrides };
+    const result: ClientSideSdkConfig = { ...cf, ...this._overrides };
+    this._omittedKeys.forEach((key) => delete result[key]);
+    return result;
   }
 
   private _maybeTime(ms?: number): number | undefined {