Commit df7fa9e
authored
feat: support waitForNetworkResults in FDv2 data manager (#1280)
The FDv2 data manager now respects the waitForNetworkResults identify
option. When false (the default for mobile), identify resolves as soon
as cached data is delivered rather than waiting for network.
**Requirements**
- [ ] I have added test coverage for new or changed functionality
- [ ] I have followed the repository's [pull request submission
guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests)
- [ ] I have validated my changes against all supported platform
versions
**Related issues**
Provide links to any issues in this repository or elsewhere relating to
this pull request.
**Describe the solution you've provided**
Provide a clear and concise description of what you expect to happen.
**Describe alternatives you've considered**
Provide a clear and concise description of any alternative solutions or
features you've considered.
**Additional context**
Add any other context about the pull request here.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Changes when the `identify` promise resolves (cached-first vs
network-fresh), which can alter initialization timing and app control
flow across platforms.
>
> **Overview**
> `FDv2DataManagerBase` now respects
`LDIdentifyOptions.waitForNetworkResults` by tracking a
`minimumDataAvailability` threshold for `identify` completion.
>
> When configured to not wait for network results, `identify` can
resolve as soon as any initial data (e.g. cache) is delivered via
`dataCallback`, while the data source continues initializing and
applying subsequent updates as they arrive.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
a2244e6. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 9a2b25a commit df7fa9e
1 file changed
Lines changed: 21 additions & 1 deletion
File tree
Lines changed: 21 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
157 | 157 | | |
158 | 158 | | |
159 | 159 | | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
160 | 168 | | |
161 | 169 | | |
162 | 170 | | |
| |||
331 | 339 | | |
332 | 340 | | |
333 | 341 | | |
334 | | - | |
| 342 | + | |
335 | 343 | | |
336 | 344 | | |
337 | 345 | | |
338 | 346 | | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
339 | 358 | | |
340 | 359 | | |
341 | 360 | | |
| |||
472 | 491 | | |
473 | 492 | | |
474 | 493 | | |
| 494 | + | |
475 | 495 | | |
476 | 496 | | |
477 | 497 | | |
| |||
0 commit comments