Skip to content

Commit ef1d648

Browse files
jsonbaileyclaude
andcommitted
chore: fix lint errors in OpenAI and LangChain provider packages
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 288ac65 commit ef1d648

6 files changed

Lines changed: 11 additions & 11 deletions

File tree

packages/ai-providers/server-ai-langchain/src/LangChainHelper.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ export function getAIMetricsFromResponse(response: AIMessage): LDAIMetrics {
8888
* Extract JSON Schema from an LD tool definition's parameters.
8989
* Falls back to an open object schema when no parameters are defined.
9090
*/
91-
function _getInputSchema(toolDef: Record<string, any>): Record<string, unknown> {
91+
function getInputSchema(toolDef: Record<string, any>): Record<string, unknown> {
9292
const params = toolDef.function?.parameters ?? toolDef.parameters;
9393
if (params && typeof params === 'object' && params.properties) {
9494
return params;
@@ -150,7 +150,7 @@ export function buildStructuredTools(
150150
{
151151
name,
152152
description,
153-
schema: _getInputSchema(td) as any,
153+
schema: getInputSchema(td) as any,
154154
},
155155
),
156156
);

packages/ai-providers/server-ai-langchain/src/LangChainRunnerFactory.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ let instrumentPromise: Promise<void> | undefined;
2020
export class LangChainRunnerFactory extends AIProvider {
2121
constructor(logger?: LDLogger) {
2222
super(logger);
23+
// eslint-disable-next-line no-underscore-dangle
2324
LangChainRunnerFactory._ensureInstrumented(logger).catch(() => {});
2425
}
2526

packages/ai-providers/server-ai-openai/__tests__/OpenAIAgentRunner.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import type { LDAIAgentConfig } from '@launchdarkly/server-sdk-ai';
2-
31
import { OpenAIAgentRunner } from '../src/OpenAIAgentRunner';
42

53
const mockRun = jest.fn();

packages/ai-providers/server-ai-openai/__tests__/OpenAIHelper.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ it('returns true for non-callable objects passed to isAgentToolInstance', () =>
116116
});
117117

118118
describe('given a shared fakeTool mock', () => {
119-
const fakeTool = jest.fn((opts: any) => ({ ...opts, _wrapped: true }));
119+
const fakeTool = jest.fn((opts: any) => ({ ...opts, wrapped: true }));
120120

121121
it('passes through non-callable values without wrapping', () => {
122122
const hostedTool = { name: 'web_search', type: 'hosted' };
@@ -141,7 +141,7 @@ describe('given a shared fakeTool mock', () => {
141141
strict: false,
142142
}),
143143
);
144-
expect(wrapped._wrapped).toBe(true);
144+
expect(wrapped.wrapped).toBe(true);
145145
});
146146

147147
it('serializes non-string tool results to JSON', async () => {

packages/ai-providers/server-ai-openai/src/OpenAIHelper.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,17 +49,17 @@ export function getAIMetricsFromResponse(response: any): LDAIMetrics {
4949
/**
5050
* Convert a snake_case string to camelCase.
5151
*/
52-
function _snakeToCamel(key: string): string {
52+
function snakeToCamel(key: string): string {
5353
return key.replace(/_([a-z])/g, (_, c) => c.toUpperCase());
5454
}
5555

5656
/**
5757
* Convert all snake_case keys in a record to camelCase.
5858
*/
59-
export function _mapParameterKeys(parameters: Record<string, unknown>): Record<string, unknown> {
59+
export function mapParameterKeys(parameters: Record<string, unknown>): Record<string, unknown> {
6060
const result: Record<string, unknown> = {};
6161
for (const [key, value] of Object.entries(parameters)) {
62-
result[_snakeToCamel(key)] = value;
62+
result[snakeToCamel(key)] = value;
6363
}
6464
return result;
6565
}

packages/ai-providers/server-ai-openai/src/OpenAIRunnerFactory.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { AIProvider } from '@launchdarkly/server-sdk-ai';
44
import type { LDAIAgentConfig, LDAICompletionConfig, LDLogger } from '@launchdarkly/server-sdk-ai';
55

66
import { OpenAIAgentRunner, ToolRegistry } from './OpenAIAgentRunner';
7-
import { _mapParameterKeys, buildAgentTools } from './OpenAIHelper';
7+
import { mapParameterKeys, buildAgentTools } from './OpenAIHelper';
88
import { OpenAIModelRunner } from './OpenAIModelRunner';
99

1010
let instrumentPromise: Promise<void> | undefined;
@@ -22,6 +22,7 @@ export class OpenAIRunnerFactory extends AIProvider {
2222
super(logger);
2323
this._client = new OpenAI({ apiKey: process.env.OPENAI_API_KEY });
2424
// Fire-and-forget: OTel instrumentation is optional and must not block construction.
25+
// eslint-disable-next-line no-underscore-dangle
2526
OpenAIRunnerFactory._ensureInstrumented(logger).catch(() => {});
2627
}
2728

@@ -63,7 +64,7 @@ export class OpenAIRunnerFactory extends AIProvider {
6364

6465
const registry = tools ?? {};
6566
const configTools = config.tools ?? {};
66-
const parameters = _mapParameterKeys({ ...(config.model?.parameters ?? {}) });
67+
const parameters = mapParameterKeys({ ...(config.model?.parameters ?? {}) });
6768
delete parameters.tools;
6869

6970
const { agentTools, toolNameMap } = buildAgentTools(toolHelper, configTools, registry, this.logger);

0 commit comments

Comments
 (0)