Skip to content

Commit f3d48c4

Browse files
authored
chore: removing old react universal sdk (#1192)
<!-- CURSOR_SUMMARY --> > [!NOTE] > **Low Risk** > Low risk: this PR is primarily deleting the `react-universal` package and its CI/release wiring, with minimal impact outside build/release configuration. > > **Overview** > Removes the deprecated `packages/sdk/react-universal` SDK entirely (source, tests, configs, and the Next.js example app). > > Cleans up repo tooling to stop referencing this workspace: drops the React Universal GitHub Actions workflow and `release-please` publish hooks, removes it from Yarn workspaces and TS project references, and updates docs/metadata (including mapping the SDK entry to `react` in `.sdk_metadata.json`). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 464a967. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> <!-- devin-review-badge-begin --> --- <a href="https://app.devin.ai/review/launchdarkly/js-core/pull/1192" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open with Devin"> </picture> </a> <!-- devin-review-badge-end -->
1 parent cb9d158 commit f3d48c4

61 files changed

Lines changed: 6 additions & 1170 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.eslintrc.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ module.exports = {
1313
'**/dist/**',
1414
'**/vercel/examples/**',
1515
'**/react-native/example/**',
16-
'**/react-universal/example/**',
1716
'**/fromExternal/**',
1817
],
1918
rules: {

.github/workflows/react-universal.yml

Lines changed: 0 additions & 24 deletions
This file was deleted.

.github/workflows/release-please.yml

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ on:
4646
- packages/sdk/fastly
4747
- packages/sdk/react-native
4848
- packages/sdk/server-node
49-
- packages/sdk/react-universal
5049
- packages/sdk/vercel
5150
- packages/sdk/akamai-base
5251
- packages/sdk/akamai-edgekv
@@ -95,7 +94,6 @@ jobs:
9594
package-node-server-sdk-dynamodb-release: ${{ steps.release.outputs['packages/store/node-server-sdk-dynamodb--release_created'] }}
9695
package-node-server-sdk-otel-release: ${{ steps.release.outputs['packages/telemetry/node-server-sdk-otel--release_created'] }}
9796
package-tooling-jest-release: ${{ steps.release.outputs['packages/tooling/jest--release_created'] }}
98-
package-react-universal-release: ${{ steps.release.outputs['packages/sdk/react-universal--release_created'] }}
9997
package-browser-released: ${{ steps.release.outputs['packages/sdk/browser--release_created'] }}
10098
package-server-ai-released: ${{ steps.release.outputs['packages/sdk/server-ai--release_created'] }}
10199
package-server-ai-langchain-released: ${{ steps.release.outputs['packages/ai-providers/server-ai-langchain--release_created'] }}
@@ -390,22 +388,6 @@ jobs:
390388
workspace_path: packages/tooling/jest
391389
aws_assume_role: ${{ vars.AWS_ROLE_ARN }}
392390

393-
release-tooling-react-universal:
394-
runs-on: ubuntu-latest
395-
needs: ['release-please', 'release-server-node', 'release-sdk-client']
396-
permissions:
397-
id-token: write
398-
contents: write
399-
if: false #${{ always() && !failure() && !cancelled() && needs.release-please.outputs.package-react-universal-release == 'true' }}
400-
steps:
401-
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
402-
- id: release-react-universal-sdk
403-
name: Full release of packages/sdk/react-universal
404-
uses: ./actions/full-release
405-
with:
406-
workspace_path: packages/sdk/react-universal
407-
aws_assume_role: ${{ vars.AWS_ROLE_ARN }}
408-
409391
release-server-ai:
410392
runs-on: ubuntu-latest
411393
needs: ['release-please', 'release-sdk-server']

.sdk_metadata.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -196,15 +196,15 @@
196196
"webProxy": { "introduced": "1.0" }
197197
}
198198
},
199-
"react-universal": {
200-
"name": "React Universal SDK",
199+
"react": {
200+
"name": "React SDK",
201201
"type": "client-side",
202-
"path": "packages/sdk/react-universal",
202+
"path": "packages/sdk/react",
203203
"languages": ["JavaScript", "TypeScript"],
204204
"releases": {
205-
"tag-prefix": "react-universal-sdk-"
205+
"tag-prefix": "react-sdk-"
206206
},
207-
"userAgents": ["ReactUniversalClient"],
207+
"wrapperNames": ["react-client-sdk"],
208208
"features": {
209209
"contexts": { "introduced": "0.0.1" }
210210
}

CONTRIBUTING.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,6 @@ flowchart LR
165165
akamai-base[sdk/akamai-base]
166166
akamai-edgekv[sdk/akamai-edgekv]
167167
server-ai[sdk/server-ai]
168-
react-universal[sdk/react-universal]
169168
svelte[sdk/svelte]
170169
shopify-oxygen[sdk/shopify-oxygen]
171170

@@ -190,7 +189,6 @@ flowchart LR
190189
%% Dependencies for SDK packages
191190
sdk-client --> browser
192191
sdk-client --> react-native
193-
sdk-client --> react-universal
194192
sdk-client --> svelte
195193

196194
sdk-server --> server-node
@@ -216,7 +214,7 @@ flowchart LR
216214
react-native -.-> jest
217215

218216
class common,sdk-client,sdk-server,sdk-server-edge,akamai-edgeworker shared
219-
class server-node,cloudflare,fastly,react-native,browser,vercel,akamai-base,akamai-edgekv,server-ai,react-universal,svelte sdk
217+
class server-node,cloudflare,fastly,react-native,browser,vercel,akamai-base,akamai-edgekv,server-ai,svelte sdk
220218
class redis,dynamodb store
221219
class node-otel,browser-telemetry telemetry
222220
class jest tooling

package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@
2525
"packages/sdk/react-native/example",
2626
"packages/sdk/react-native/contract-tests/adapter",
2727
"packages/sdk/react-native/contract-tests/entity",
28-
"packages/sdk/react-universal",
29-
"packages/sdk/react-universal/example",
3028
"packages/sdk/vercel",
3129
"packages/sdk/svelte",
3230
"packages/sdk/svelte/example",

packages/sdk/react-universal/.eslintignore

Lines changed: 0 additions & 1 deletion
This file was deleted.

packages/sdk/react-universal/CHANGELOG.md

Lines changed: 0 additions & 3 deletions
This file was deleted.

packages/sdk/react-universal/LICENSE

Lines changed: 0 additions & 13 deletions
This file was deleted.

packages/sdk/react-universal/README.md

Lines changed: 0 additions & 140 deletions
This file was deleted.

0 commit comments

Comments
 (0)