Skip to content

Commit f48bc8f

Browse files
committed
ci: fixing electron ci breaking
1 parent af6e513 commit f48bc8f

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

.github/workflows/electron.yaml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,11 @@ jobs:
1919
runs-on: ubuntu-latest
2020
strategy:
2121
matrix:
22-
# Node versions to run on.
23-
version: [24]
22+
# NOTE: we need to pin this particular version for electron because
23+
# 24.16 introduce some breaking changes affecting electron installation.
24+
# We should monitor if NodeJS patches anything on that minor version before
25+
# putting this back to latest LTS.
26+
version: [24.15]
2427
steps:
2528
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
2629
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
@@ -80,7 +83,7 @@ jobs:
8083
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
8184
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
8285
with:
83-
node-version: 24
86+
node-version: 24.15
8487
- uses: ./actions/run-example
8588
with:
8689
workspace_name: '@launchdarkly/electron-example'

0 commit comments

Comments
 (0)