Skip to content

Commit f74ead6

Browse files
chore: replace workspace:^ with static versions in example apps (#1261)
**Requirements** - [x] I have added test coverage for new or changed functionality - [x] I have followed the repository's [pull request submission guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests) - [x] I have validated my changes against all supported platform versions No test changes needed — this only affects example app dependency declarations and release-please configuration. **Related issues** [SDK-2157](https://launchdarkly.atlassian.net/browse/SDK-2157) **Describe the solution you've provided** Replaces all `workspace:^` references for `@launchdarkly/*` dependencies in example app `package.json` files with their current static versions from `.release-please-manifest.json` (or the package's own `package.json` for electron/svelte which are not yet in the manifest). Adds `extra-files` entries to `release-please-config.json` so these versions are automatically bumped on future releases. **Affected example apps (12 files):** - `packages/sdk/browser/example` and `example-fdv2` → `@launchdarkly/js-client-sdk` 4.4.1 - `packages/sdk/electron/example` → `@launchdarkly/electron-client-sdk` 0.0.1 - `packages/sdk/react-native/example` → `@launchdarkly/react-native-client-sdk` 10.15.1 - `packages/sdk/svelte/example` → `@launchdarkly/svelte-client-sdk` 0.1.0 - 7 server-ai examples (openai, bedrock, vercel-ai, tracked-chat, chat-judge, direct-judge, chat-observability) → static versions for `node-server-sdk`, `server-sdk-ai`, and the relevant AI provider packages **release-please-config.json changes:** - Added extra-files to existing entries: `browser`, `react-native`, `server-node`, `server-ai`, `server-ai-openai`, `server-ai-vercel`, `server-ai-langchain` - Added new entries for `packages/sdk/electron` and `packages/sdk/svelte` (not yet in the release-please manifest — entries will take effect once those packages join the release pipeline) - Cross-package references (e.g., server-ai examples depending on `node-server-sdk`) use absolute paths from repo root, following the existing `server-node` → `react-server-example` pattern **Describe alternatives you've considered** N/A — this follows the established pattern already used by cloudflare, fastly, akamai-base, akamai-edgekv, and react example apps. **Additional context** ### Human review checklist - [ ] Verify the static versions match current published versions (sourced from `.release-please-manifest.json`) - [ ] Confirm `extra-files` jsonpath expressions match the actual dependency key names in each example's `package.json` - [ ] Confirm that adding `packages/sdk/electron` and `packages/sdk/svelte` to `release-please-config.json` won't cause issues before those packages are added to the manifest - [ ] Verify cross-package extra-files use absolute paths (`/packages/...`) while same-package entries use relative paths Link to Devin session: https://app.devin.ai/sessions/c56e3cf1d5e84389a79b9e3f818605c4 Requested by: @joker23 [SDK-2157]: https://launchdarkly.atlassian.net/browse/SDK-2157?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk since changes are limited to example-app dependency version pinning and `release-please` config updates; main risk is misconfigured `jsonpath`/paths causing future automated bumps to miss or update the wrong fields. > > **Overview** > Pins previously `workspace:^` LaunchDarkly dependencies in multiple example apps (browser, Electron, React Native, Svelte, and several `server-ai` examples) to specific published versions. > > Updates `release-please-config.json` to add `extra-files` entries (and new package sections for `packages/sdk/electron` and `packages/sdk/svelte`) so future releases automatically bump the corresponding dependency versions in these example `package.json` files, including cross-package references like `@launchdarkly/node-server-sdk` used by the `server-ai` examples. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit dfac6c5. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> <!-- devin-review-badge-begin --> --- <a href="https://app.devin.ai/review/launchdarkly/js-core/pull/1261" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open with Devin"> </picture> </a> <!-- devin-review-badge-end --> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
1 parent 2f470aa commit f74ead6

13 files changed

Lines changed: 207 additions & 37 deletions

File tree

packages/sdk/browser/example-fdv2/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"test": "playwright test"
1919
},
2020
"dependencies": {
21-
"@launchdarkly/js-client-sdk": "workspace:^"
21+
"@launchdarkly/js-client-sdk": "4.4.1"
2222
},
2323
"devDependencies": {
2424
"@playwright/test": "^1.49.1",

packages/sdk/browser/example/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"test": "playwright test"
1919
},
2020
"dependencies": {
21-
"@launchdarkly/js-client-sdk": "workspace:^"
21+
"@launchdarkly/js-client-sdk": "4.4.1"
2222
},
2323
"devDependencies": {
2424
"@playwright/test": "^1.49.1",

packages/sdk/electron/example/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"vite": "^5.4.21"
3636
},
3737
"dependencies": {
38-
"@launchdarkly/electron-client-sdk": "workspace:^",
38+
"@launchdarkly/electron-client-sdk": "0.0.1",
3939
"electron-squirrel-startup": "^1.0.1"
4040
}
4141
}

packages/sdk/react-native/example/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"test": "./build-run-detox.sh"
2323
},
2424
"dependencies": {
25-
"@launchdarkly/react-native-client-sdk": "workspace:^",
25+
"@launchdarkly/react-native-client-sdk": "10.15.1",
2626
"@react-native-async-storage/async-storage": "^2.0.0",
2727
"expo": "52.0.14",
2828
"expo-status-bar": "~1.11.1",

packages/sdk/server-ai/examples/bedrock/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323
"license": "Apache-2.0",
2424
"dependencies": {
2525
"@aws-sdk/client-bedrock-runtime": "^3.679.0",
26-
"@launchdarkly/node-server-sdk": "workspace:^",
27-
"@launchdarkly/server-sdk-ai": "workspace:^"
26+
"@launchdarkly/node-server-sdk": "9.10.10",
27+
"@launchdarkly/server-sdk-ai": "0.16.7"
2828
},
2929
"devDependencies": {
3030
"@trivago/prettier-plugin-sort-imports": "^4.1.1",

packages/sdk/server-ai/examples/chat-judge/package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@
1010
"start": "yarn build && node ./dist/index.js"
1111
},
1212
"dependencies": {
13-
"@launchdarkly/node-server-sdk": "workspace:^",
14-
"@launchdarkly/server-sdk-ai": "workspace:^",
15-
"@launchdarkly/server-sdk-ai-langchain": "workspace:^",
16-
"@launchdarkly/server-sdk-ai-openai": "workspace:^",
17-
"@launchdarkly/server-sdk-ai-vercel": "workspace:^",
13+
"@launchdarkly/node-server-sdk": "9.10.10",
14+
"@launchdarkly/server-sdk-ai": "0.16.7",
15+
"@launchdarkly/server-sdk-ai-langchain": "0.5.3",
16+
"@launchdarkly/server-sdk-ai-openai": "0.5.3",
17+
"@launchdarkly/server-sdk-ai-vercel": "0.5.3",
1818
"dotenv": "^16.0.0"
1919
},
2020
"devDependencies": {

packages/sdk/server-ai/examples/chat-observability/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@
88
"start": "yarn build && node ./dist/index.js"
99
},
1010
"dependencies": {
11-
"@launchdarkly/node-server-sdk": "workspace:^",
11+
"@launchdarkly/node-server-sdk": "9.10.10",
1212
"@launchdarkly/observability-node": "^1.0.0",
13-
"@launchdarkly/server-sdk-ai": "workspace:^",
14-
"@launchdarkly/server-sdk-ai-openai": "workspace:^",
13+
"@launchdarkly/server-sdk-ai": "0.16.7",
14+
"@launchdarkly/server-sdk-ai-openai": "0.5.3",
1515
"dotenv": "^16.0.0",
1616
"openai": "^5.12.2"
1717
},

packages/sdk/server-ai/examples/direct-judge/package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@
1010
"start": "yarn build && node ./dist/index.js"
1111
},
1212
"dependencies": {
13-
"@launchdarkly/node-server-sdk": "workspace:^",
14-
"@launchdarkly/server-sdk-ai": "workspace:^",
15-
"@launchdarkly/server-sdk-ai-langchain": "workspace:^",
16-
"@launchdarkly/server-sdk-ai-openai": "workspace:^",
17-
"@launchdarkly/server-sdk-ai-vercel": "workspace:^",
13+
"@launchdarkly/node-server-sdk": "9.10.10",
14+
"@launchdarkly/server-sdk-ai": "0.16.7",
15+
"@launchdarkly/server-sdk-ai-langchain": "0.5.3",
16+
"@launchdarkly/server-sdk-ai-openai": "0.5.3",
17+
"@launchdarkly/server-sdk-ai-vercel": "0.5.3",
1818
"dotenv": "^16.0.0"
1919
},
2020
"devDependencies": {

packages/sdk/server-ai/examples/openai/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@
2121
"author": "LaunchDarkly",
2222
"license": "Apache-2.0",
2323
"dependencies": {
24-
"@launchdarkly/node-server-sdk": "workspace:^",
25-
"@launchdarkly/server-sdk-ai": "workspace:^",
26-
"@launchdarkly/server-sdk-ai-openai": "workspace:^",
24+
"@launchdarkly/node-server-sdk": "9.10.10",
25+
"@launchdarkly/server-sdk-ai": "0.16.7",
26+
"@launchdarkly/server-sdk-ai-openai": "0.5.3",
2727
"openai": "^4.58.1"
2828
},
2929
"devDependencies": {

packages/sdk/server-ai/examples/tracked-chat/package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@
1212
"@ai-sdk/google": "^2.0.20",
1313
"@langchain/core": "^0.3.78",
1414
"@langchain/google-genai": "^0.2.18",
15-
"@launchdarkly/node-server-sdk": "workspace:^",
16-
"@launchdarkly/server-sdk-ai": "workspace:^",
17-
"@launchdarkly/server-sdk-ai-langchain": "workspace:^",
18-
"@launchdarkly/server-sdk-ai-openai": "workspace:^",
19-
"@launchdarkly/server-sdk-ai-vercel": "workspace:^",
15+
"@launchdarkly/node-server-sdk": "9.10.10",
16+
"@launchdarkly/server-sdk-ai": "0.16.7",
17+
"@launchdarkly/server-sdk-ai-langchain": "0.5.3",
18+
"@launchdarkly/server-sdk-ai-openai": "0.5.3",
19+
"@launchdarkly/server-sdk-ai-vercel": "0.5.3",
2020
"dotenv": "^16.0.0",
2121
"langchain": "^0.1.0"
2222
},

0 commit comments

Comments
 (0)