fix(common): remove non-spec fields from FDv2 GoodbyeObject (#1341)

Author: keelerm84

packages/shared/common/src/internal/fdv2/proto.ts

@@ -66,8 +66,6 @@ export interface DeleteObject {
 
 export interface GoodbyeObject {
   reason: string;
-  silent: boolean;
-  catastrophe: boolean;
 }
 
 export interface ErrorObject {

packages/shared/sdk-client/__tests__/datasource/fdv2/PollingBase.test.ts

@@ -286,7 +286,7 @@ describe('given a goodbye event in the response', () => {
       },
       {
         event: 'goodbye',
-        data: { reason: 'server-shutdown', silent: false, catastrophe: false },
+        data: { reason: 'server-shutdown' },
       },
     ]);
     const requestor = makeRequestor({

packages/shared/sdk-client/__tests__/datasource/fdv2/PollingInitializer.test.ts

@@ -174,7 +174,7 @@ it('does not retry on goodbye result', async () => {
     },
     {
       event: 'goodbye',
-      data: { reason: 'server-shutdown', silent: false, catastrophe: false },
+      data: { reason: 'server-shutdown' },
     },
   ]);
   const requestor: FDv2Requestor = {

packages/shared/sdk-client/__tests__/datasource/fdv2/StreamingFDv2Base.test.ts

@@ -125,8 +125,6 @@ it('produces a goodbye status result', async () => {
 
   simulateEvent(mockEventSource, 'goodbye', {
     reason: 'server restarting',
-    silent: false,
-    catastrophe: false,
   });
 
   const result = await base.takeResult();
@@ -416,8 +414,6 @@ it('produces results in order', async () => {
 
   simulateEvent(mockEventSource, 'goodbye', {
     reason: 'bye',
-    silent: false,
-    catastrophe: false,
   });
 
   const r1 = await base.takeResult();