Skip to content

feat: FDv2 Cache Initializer #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kinyoklion merged 14 commits into from
Mar 5, 2026
Merged

feat: FDv2 Cache Initializer #1147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
00c25df
feat: FDv2 Cache Initializer
kinyoklion Mar 3, 2026
2e0a662
Freshness record evictions.
kinyoklion Mar 3, 2026
35a20b7
Freshness accounts for all attributes of contexts.
kinyoklion Mar 3, 2026
e990e55
Integrated into persistence.
kinyoklion Mar 4, 2026
13cf993
Refine compatibility story.
kinyoklion Mar 4, 2026
5a16d8d
Handle errors hashing context.
kinyoklion Mar 4, 2026
0915817
Plumb cache freshness.
kinyoklion Mar 4, 2026
30c365a
Common cache loading
kinyoklion Mar 4, 2026
41e6d18
Merge branch 'main' into rlamb/sdk-1922/cache-initializer
kinyoklion Mar 4, 2026
417412d
Protect from clock drift.
kinyoklion Mar 4, 2026
72ed8d8
Restore logging.
kinyoklion Mar 5, 2026
cd405a4
PR feedback
kinyoklion Mar 5, 2026
e044703
PR feedback
kinyoklion Mar 5, 2026
ccae06f
Re-order freshness write.
kinyoklion Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 33 additions & 23 deletions packages/shared/sdk-client/__tests__/LDClientImpl.storage.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ describe('sdk-client storage', () => {
await jest.runAllTimersAsync();

expect(ldc.allFlags()).not.toHaveProperty('dev-test-flag');
expect(mockPlatform.storage.set).toHaveBeenCalledTimes(2);
expect(mockPlatform.storage.set).toHaveBeenCalledTimes(3);
expect(mockPlatform.storage.set).toHaveBeenNthCalledWith(
1,
indexStorageKey,
Expand Down Expand Up @@ -291,7 +291,7 @@ describe('sdk-client storage', () => {
await jest.runAllTimersAsync();

expect(ldc.allFlags()).toMatchObject({ 'another-dev-test-flag': false });
expect(mockPlatform.storage.set).toHaveBeenCalledTimes(2);
expect(mockPlatform.storage.set).toHaveBeenCalledTimes(3);
expect(mockPlatform.storage.set).toHaveBeenNthCalledWith(
1,
indexStorageKey,
Expand Down Expand Up @@ -373,7 +373,7 @@ describe('sdk-client storage', () => {
await ldc.identify(context);
await jest.runAllTimersAsync();

expect(mockPlatform.storage.set).toHaveBeenCalledTimes(2);
expect(mockPlatform.storage.set).toHaveBeenCalledTimes(3);
expect(mockPlatform.storage.set).toHaveBeenNthCalledWith(
1,
indexStorageKey,
Expand Down Expand Up @@ -421,7 +421,11 @@ describe('sdk-client storage', () => {
await changePromise;
await jest.runAllTimersAsync();

const flagsInStorage = JSON.parse(mockPlatform.storage.set.mock.lastCall[1]) as Flags;
const flagsInStorage = JSON.parse(
mockPlatform.storage.set.mock.calls
.filter(([key]: [string]) => key === flagStorageKey)
.pop()![1],
) as Flags;
expect(ldc.allFlags()).toMatchObject({ 'dev-test-flag': true });
expect(flagsInStorage['dev-test-flag'].reason).toEqual({
kind: 'RULE_MATCH',
Expand Down Expand Up @@ -455,9 +459,13 @@ describe('sdk-client storage', () => {
await changePromise;
await jest.runAllTimersAsync();

const flagsInStorage = JSON.parse(mockPlatform.storage.set.mock.lastCall[1]) as Flags;
const flagsInStorage = JSON.parse(
mockPlatform.storage.set.mock.calls
.filter(([key]: [string]) => key === flagStorageKey)
.pop()![1],
) as Flags;
expect(ldc.allFlags()).toMatchObject({ 'dev-test-flag': false });
expect(mockPlatform.storage.set).toHaveBeenCalledTimes(4);
expect(mockPlatform.storage.set).toHaveBeenCalledTimes(6);
expect(flagsInStorage['dev-test-flag'].version).toEqual(patchResponse.version);
expect(emitter.emit).toHaveBeenCalledWith('change', context, ['dev-test-flag']);
});
Expand All @@ -482,13 +490,12 @@ describe('sdk-client storage', () => {
await changePromise;
await jest.runAllTimersAsync();

const flagsInStorage = JSON.parse(mockPlatform.storage.set.mock.lastCall[1]) as Flags;
const flagsInStorage = JSON.parse(
mockPlatform.storage.set.mock.calls
.filter(([key]: [string]) => key === flagStorageKey)
.pop()![1],
) as Flags;
expect(ldc.allFlags()).toHaveProperty('another-dev-test-flag');
expect(mockPlatform.storage.set).toHaveBeenNthCalledWith(
4,
flagStorageKey,
expect.stringContaining(JSON.stringify(patchResponse)),
);
expect(flagsInStorage).toHaveProperty('another-dev-test-flag');
expect(emitter.emit).toHaveBeenCalledWith('change', context, ['another-dev-test-flag']);
});
Expand Down Expand Up @@ -516,7 +523,7 @@ describe('sdk-client storage', () => {
await jest.runAllTimersAsync();

// the initial put is resulting in two sets, one for the index and one for the flag data
expect(mockPlatform.storage.set).toHaveBeenCalledTimes(2);
expect(mockPlatform.storage.set).toHaveBeenCalledTimes(3);
expect(emitter.emit).not.toHaveBeenCalledWith('change');

// this is defaultPutResponse
Expand Down Expand Up @@ -556,13 +563,12 @@ describe('sdk-client storage', () => {
await changePromise;
await jest.runAllTimersAsync();

const flagsInStorage = JSON.parse(mockPlatform.storage.set.mock.lastCall[1]) as Flags;
const flagsInStorage = JSON.parse(
mockPlatform.storage.set.mock.calls
.filter(([key]: [string]) => key === flagStorageKey)
.pop()![1],
) as Flags;
expect(ldc.allFlags()).not.toHaveProperty('dev-test-flag');
expect(mockPlatform.storage.set).toHaveBeenNthCalledWith(
4,
flagStorageKey,
expect.stringContaining('dev-test-flag'),
);
expect(flagsInStorage['dev-test-flag']).toMatchObject({ ...deleteResponse, deleted: true });
expect(emitter.emit).toHaveBeenCalledWith('change', context, ['dev-test-flag']);
});
Expand Down Expand Up @@ -591,7 +597,7 @@ describe('sdk-client storage', () => {

expect(ldc.allFlags()).toHaveProperty('dev-test-flag');
// the initial put is resulting in two sets, one for the index and one for the flag data
expect(mockPlatform.storage.set).toHaveBeenCalledTimes(2);
expect(mockPlatform.storage.set).toHaveBeenCalledTimes(3);
expect(emitter.emit).not.toHaveBeenCalledWith('change');
});

Expand Down Expand Up @@ -619,7 +625,7 @@ describe('sdk-client storage', () => {

expect(ldc.allFlags()).toHaveProperty('dev-test-flag');
// the initial put is resulting in two sets, one for the index and one for the flag data
expect(mockPlatform.storage.set).toHaveBeenCalledTimes(2);
expect(mockPlatform.storage.set).toHaveBeenCalledTimes(3);
expect(emitter.emit).not.toHaveBeenCalledWith('change');
});

Expand All @@ -645,9 +651,13 @@ describe('sdk-client storage', () => {
await changePromise;
await jest.runAllTimersAsync();

const flagsInStorage = JSON.parse(mockPlatform.storage.set.mock.lastCall[1]) as Flags;
const flagsInStorage = JSON.parse(
mockPlatform.storage.set.mock.calls
.filter(([key]: [string]) => key === flagStorageKey)
.pop()![1],
) as Flags;

expect(mockPlatform.storage.set).toHaveBeenCalledTimes(4); // two index saves and two flag saves
expect(mockPlatform.storage.set).toHaveBeenCalledTimes(6); // two index saves and two flag saves
expect(flagsInStorage['does-not-exist']).toMatchObject({ ...deleteResponse, deleted: true });
expect(emitter.emit).toHaveBeenCalledWith('change', context, ['does-not-exist']);
});
Expand Down
Loading