Skip to content

feat: Add DataSourceUpdateSink for client-side FDv2#1157

Closed
kinyoklion wants to merge 2 commits into
mainfrom
rlamb/sdk-1921/data-source-update-sink
Closed

feat: Add DataSourceUpdateSink for client-side FDv2#1157
kinyoklion wants to merge 2 commits into
mainfrom
rlamb/sdk-1921/data-source-update-sink

Conversation

@kinyoklion

Copy link
Copy Markdown
Member

No description provided.

Implements SDK-1921 (FDCS-06): the update sink that processes FDv2
ChangeSetResult payloads from the orchestrator and applies them to
FlagManager. Handles full payloads (init), partial payloads (upsert
per flag), and none payloads. Manages the selector (basis state) in
memory only (Req 6.2.1) and tracks environmentId from response headers.
@github-actions

github-actions Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25566 bytes
Compressed size limit: 26000
Uncompressed size: 125383 bytes

@github-actions

github-actions Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 23845 bytes
Compressed size limit: 25000
Uncompressed size: 82750 bytes

@github-actions

github-actions Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 171694 bytes
Compressed size limit: 200000
Uncompressed size: 799867 bytes

@github-actions

github-actions Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 20569 bytes
Compressed size limit: 24000
Uncompressed size: 107197 bytes

Moves selector and environmentId management into FlagManager, following
the server SDK's LDTransactionalFeatureStore.applyChanges pattern.
FlagManager.applyChanges accepts pre-converted ItemDescriptors with
basis flag, selector, and environmentId. DataSourceUpdateSink simplified
to a thin adapter that converts FDv2 protocol types and delegates.
@kinyoklion kinyoklion closed this Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant