feat: SourceFactoryProvider for declarative data source creation by kinyoklion · Pull Request #1209 · launchdarkly/js-core

kinyoklion · 2026-03-19T22:30:22Z

Summary

Converts: {polling: {initializers: ['cache', 'polling'], synchronizers: ['streaming']}} into real factories.

Add SourceFactoryProvider interface and createDefaultSourceFactoryProvider implementation
Converts declarative InitializerEntry/SynchronizerEntry config into concrete factories and synchronizer slots
Supports per-entry endpoint overrides (custom polling/streaming URIs) and interval overrides
Handles cache, polling, and streaming entry types

Stacked on #1207. Independent of #1208 (FlagManager.applyChanges).

Note

Medium Risk
Introduces a new factory layer that determines how polling/streaming/cache sources are instantiated (including endpoint/interval overrides), which can affect connection behavior if integrated incorrectly. Changes are well-covered by unit tests and are otherwise additive.

Overview
Adds a new SourceFactoryProvider abstraction (with createDefaultSourceFactoryProvider) that converts declarative InitializerEntry/SynchronizerEntry configs into concrete FDv2 initializer factories and synchronizer slots, supporting cache, polling, and streaming entries.

Implements per-entry overrides for endpoints and timing (poll interval and streaming reconnect delay), including ensuring the streaming ping handler always uses the latest selector and any endpoint-overridden polling requestor.

Exports the new provider/types from sdk-client public entrypoint and updates CI package-size thresholds for js-sdk-common and js-client-sdk-common to accommodate the added code/tests.

^{Written by Cursor Bugbot for commit de39213. This will update automatically on new commits. Configure here.}

…xtensions Add InitializerEntry/SynchronizerEntry types for type-safe mode definitions, refine protocolHandler validation to use isNullish for version/target fields, add connectionModes config option, split validator arrays for initializers vs synchronizers, and extend DataManager with optional streaming/flush methods.

Add SourceFactoryProvider that converts declarative InitializerEntry and SynchronizerEntry config into concrete initializer factories and synchronizer slots, with support for per-entry endpoint and interval overrides.

github-actions · 2026-03-20T15:59:13Z

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25661 bytes
Compressed size limit: 29000
Uncompressed size: 126143 bytes

- Fix ping handler to use per-entry endpoint-overridden requestor and the factory's selector getter (sg) for fresh selectors on each ping - Extract duplicated streaming base config into shared buildStreamingBase helper - Restructure SourceFactoryContext to group polling/streaming config into nested objects (polling.paths, polling.intervalSeconds, streaming.paths, streaming.initialReconnectDelaySeconds) - Resolve merge conflict in FDv2DataSource (warn -> debug)

github-actions · 2026-03-20T16:49:43Z

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 24981 bytes
Compressed size limit: 25000
Uncompressed size: 86916 bytes

github-actions · 2026-03-20T16:49:45Z

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 172978 bytes
Compressed size limit: 200000
Uncompressed size: 804043 bytes

github-actions · 2026-03-20T16:49:57Z

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 29156 bytes
Compressed size limit: 38000
Uncompressed size: 156220 bytes

Account for new FDv2 SourceFactoryProvider and related code paths.

joker23 · 2026-03-20T19:55:00Z

          package_name: '@launchdarkly/js-client-sdk-common'
          pr_number: ${{ github.event.number }}
-          size_limit: 24000
+          size_limit: 38000


The things we do for FDv2...

No action

Yeah, thankfully that doesn't directly translate to package size, but it is quite a bit.

joker23 · 2026-03-20T20:02:36Z

+    ): SynchronizerSlot | undefined {
+      switch (entry.type) {
+        case 'polling': {
+          const intervalMs = (entry.pollInterval ?? ctx.polling.intervalSeconds) * 1000;


nit: do we guard against invalid numbers? eg negative pollIntervals?

const pollingEntryValidators = { type: dataSourceTypeValidator, pollInterval: TypeValidators.numberWithMin(30), endpoints: validatorOf(endpointValidators), };

Global one is validated the same.

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

🤖 I have created a release *beep* *boop* --- <details><summary>akamai-edgeworker-sdk-common: 2.0.17</summary> ## [2.0.17](akamai-edgeworker-sdk-common-v2.0.16...akamai-edgeworker-sdk-common-v2.0.17) (2026-03-23) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from ^2.18.2 to ^2.18.3 </details> <details><summary>akamai-server-base-sdk: 3.0.18</summary> ## [3.0.18](akamai-server-base-sdk-v3.0.17...akamai-server-base-sdk-v3.0.18) (2026-03-23) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/akamai-edgeworker-sdk-common bumped from ^2.0.16 to ^2.0.17 * @launchdarkly/js-server-sdk-common bumped from ^2.18.2 to ^2.18.3 </details> <details><summary>akamai-server-edgekv-sdk: 1.4.20</summary> ## [1.4.20](akamai-server-edgekv-sdk-v1.4.19...akamai-server-edgekv-sdk-v1.4.20) (2026-03-23) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/akamai-edgeworker-sdk-common bumped from ^2.0.16 to ^2.0.17 * @launchdarkly/js-server-sdk-common bumped from ^2.18.2 to ^2.18.3 </details> <details><summary>browser: 0.1.13</summary> ## [0.1.13](browser-v0.1.12...browser-v0.1.13) (2026-03-23) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk bumped from 4.4.0 to 4.4.1 </details> <details><summary>browser-telemetry: 1.0.29</summary> ## [1.0.29](browser-telemetry-v1.0.28...browser-telemetry-v1.0.29) (2026-03-23) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/js-client-sdk bumped from 4.4.0 to 4.4.1 </details> <details><summary>cloudflare-server-sdk: 2.7.17</summary> ## [2.7.17](cloudflare-server-sdk-v2.7.16...cloudflare-server-sdk-v2.7.17) (2026-03-23) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common-edge bumped from 2.6.15 to 2.6.16 </details> <details><summary>fastly-server-sdk: 0.2.9</summary> ## [0.2.9](fastly-server-sdk-v0.2.8...fastly-server-sdk-v0.2.9) (2026-03-23) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from 2.18.2 to 2.18.3 </details> <details><summary>jest: 1.0.8</summary> ## [1.0.8](jest-v1.0.7...jest-v1.0.8) (2026-03-23) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/react-native-client-sdk bumped from ~10.15.0 to ~10.15.1 </details> <details><summary>js-client-sdk: 4.4.1</summary> ## [4.4.1](js-client-sdk-v4.4.0...js-client-sdk-v4.4.1) (2026-03-23) ### Bug Fixes * Report data source state as valid after bootstrap ([#1203](#1203)) ([b00889f](b00889f)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk-common bumped from 1.22.0 to 1.23.0 </details> <details><summary>js-client-sdk-common: 1.23.0</summary> ## [1.23.0](js-client-sdk-common-v1.22.0...js-client-sdk-common-v1.23.0) (2026-03-23) ### Features * FDv2 types, refined validators, and DataManager interface ([#1207](#1207)) ([d7ccfc1](d7ccfc1)) * FlagManager.applyChanges for FDv2 full/partial/none semantics ([#1208](#1208)) ([d9a1bd7](d9a1bd7)) * SourceFactoryProvider for declarative data source creation ([#1209](#1209)) ([e254f77](e254f77)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-sdk-common bumped from 2.23.0 to 2.24.0 </details> <details><summary>js-sdk-common: 2.24.0</summary> ## [2.24.0](js-sdk-common-v2.23.0...js-sdk-common-v2.24.0) (2026-03-23) ### Features * FDv2 types, refined validators, and DataManager interface ([#1207](#1207)) ([d7ccfc1](d7ccfc1)) </details> <details><summary>js-server-sdk-common: 2.18.3</summary> ## [2.18.3](js-server-sdk-common-v2.18.2...js-server-sdk-common-v2.18.3) (2026-03-23) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-sdk-common bumped from 2.23.0 to 2.24.0 </details> <details><summary>js-server-sdk-common-edge: 2.6.16</summary> ## [2.6.16](js-server-sdk-common-edge-v2.6.15...js-server-sdk-common-edge-v2.6.16) (2026-03-23) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from 2.18.2 to 2.18.3 </details> <details><summary>node-server-sdk: 9.10.10</summary> ## [9.10.10](node-server-sdk-v9.10.9...node-server-sdk-v9.10.10) (2026-03-23) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from 2.18.2 to 2.18.3 </details> <details><summary>node-server-sdk-dynamodb: 6.2.22</summary> ## [6.2.22](node-server-sdk-dynamodb-v6.2.21...node-server-sdk-dynamodb-v6.2.22) (2026-03-23) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.10.9 to 9.10.10 * peerDependencies * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.10.10 </details> <details><summary>node-server-sdk-otel: 1.3.10</summary> ## [1.3.10](node-server-sdk-otel-v1.3.9...node-server-sdk-otel-v1.3.10) (2026-03-23) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.10.9 to 9.10.10 * peerDependencies * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.10.10 </details> <details><summary>node-server-sdk-redis: 4.2.22</summary> ## [4.2.22](node-server-sdk-redis-v4.2.21...node-server-sdk-redis-v4.2.22) (2026-03-23) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/node-server-sdk bumped from 9.10.9 to 9.10.10 * peerDependencies * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.10.10 </details> <details><summary>react-native-client-sdk: 10.15.1</summary> ## [10.15.1](react-native-client-sdk-v10.15.0...react-native-client-sdk-v10.15.1) (2026-03-23) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk-common bumped from 1.22.0 to 1.23.0 </details> <details><summary>react-sdk: 0.1.0</summary> ## [0.1.0](react-sdk-v0.0.1...react-sdk-v0.1.0) (2026-03-23) ### Features * pre-release of `@launchdarkly/react-sdk` ([#1201](#1201)) ([69f4790](69f4790)) ### Bug Fixes * **deps:** update dependency next to v16.1.5 [security] ([#1164](#1164)) ([929a385](929a385)) * **deps:** update dependency next to v16.1.7 [security] ([#1196](#1196)) ([1572be1](1572be1)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk bumped from ^4.4.0 to ^4.4.1 * @launchdarkly/js-server-sdk-common bumped from ^2.18.2 to ^2.18.3 </details> <details><summary>server-sdk-ai: 0.16.7</summary> ## [0.16.7](server-sdk-ai-v0.16.6...server-sdk-ai-v0.16.7) (2026-03-23) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/js-server-sdk-common bumped from 2.18.2 to 2.18.3 * peerDependencies * @launchdarkly/js-server-sdk-common bumped from 2.x to 2.18.3 </details> <details><summary>server-sdk-ai-langchain: 0.5.3</summary> ## [0.5.3](server-sdk-ai-langchain-v0.5.2...server-sdk-ai-langchain-v0.5.3) (2026-03-23) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/server-sdk-ai bumped from ^0.16.6 to ^0.16.7 * peerDependencies * @launchdarkly/server-sdk-ai bumped from ^0.15.0 || ^0.16.0 to ^0.16.7 </details> <details><summary>server-sdk-ai-openai: 0.5.3</summary> ## [0.5.3](server-sdk-ai-openai-v0.5.2...server-sdk-ai-openai-v0.5.3) (2026-03-23) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/js-server-sdk-common bumped from 2.18.2 to 2.18.3 * @launchdarkly/server-sdk-ai bumped from ^0.16.6 to ^0.16.7 * peerDependencies * @launchdarkly/server-sdk-ai bumped from ^0.15.0 || ^0.16.0 to ^0.16.7 </details> <details><summary>server-sdk-ai-vercel: 0.5.3</summary> ## [0.5.3](server-sdk-ai-vercel-v0.5.2...server-sdk-ai-vercel-v0.5.3) (2026-03-23) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/server-sdk-ai bumped from ^0.16.6 to ^0.16.7 * peerDependencies * @launchdarkly/server-sdk-ai bumped from ^0.15.0 || ^0.16.0 to ^0.16.7 </details> <details><summary>shopify-oxygen-sdk: 0.1.7</summary> ## [0.1.7](shopify-oxygen-sdk-v0.1.6...shopify-oxygen-sdk-v0.1.7) (2026-03-23) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common bumped from 2.18.2 to 2.18.3 </details> <details><summary>vercel-server-sdk: 1.3.42</summary> ## [1.3.42](vercel-server-sdk-v1.3.41...vercel-server-sdk-v1.3.42) (2026-03-23) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-server-sdk-common-edge bumped from 2.6.15 to 2.6.16 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).  --- > [!NOTE] > **Low Risk** > Primarily metadata-only release changes (version constants, `package.json` deps, and `CHANGELOG.md` updates) with minimal functional code impact. Risk is limited to ensuring version strings and dependency bumps are consistent across packages. > > **Overview** > **Automated release PR** that bumps versions across many packages via release-please and updates `.release-please-manifest.json` accordingly. > > Updates each package’s `package.json` (and a few embedded `sdkVersion`/`version` constants used for user-agent/platform info) plus `CHANGELOG.md` entries, and rolls forward internal dependency pins (notably `@launchdarkly/js-sdk-common` → `2.24.0`, `@launchdarkly/js-client-sdk-common` → `1.23.0`, `@launchdarkly/js-server-sdk-common` → `2.18.3`, and the leaf SDKs that depend on them). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 46e1356. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup>  Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

#1210) ## Summary - Add `FDv2DataManagerBase` — shared data manager orchestrating FDv2 connection mode switching, state debouncing, and data source lifecycle - Implements `DataManager` interface with foreground/background mode support, forced/automatic streaming control, and flush callbacks - Includes `FlagManager.applyChanges` from #1208 for full/partial/none flag update semantics Stacked on #1209 and #1208.  --- > [!NOTE] > **Medium Risk** > Adds a new shared FDv2 data manager that controls connection-mode resolution and data source lifecycle, plus updates public `dataSystem` option shapes; mistakes here could affect SDK initialization, reconnection behavior, and flag freshness across platforms. > > **Overview** > Introduces `createFDv2DataManagerBase` (and exported types) as a shared FDv2 orchestration layer that performs mode resolution/debouncing, manages `FDv2DataSource` creation/teardown across identifies and mode changes, tracks selector state, triggers a background flush callback, and optionally appends a blocked FDv1 polling fallback synchronizer. > > Updates the public `dataSystem` configuration model by renaming `initialConnectionMode` to `foregroundConnectionMode` in platform defaults and by making `automaticModeSwitching` a discriminated union (`{type:'automatic'}` vs `{type:'manual', initialConnectionMode}`), with validator support via `validatorOf(..., { is })`; tests are updated and expanded accordingly, including a large new test suite for `FDv2DataManagerBase`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 0786b64. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup>   --- <a href="https://app.devin.ai/review/launchdarkly/js-core/pull/1210" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open with Devin"> </picture> </a>

kinyoklion added 2 commits March 19, 2026 15:11

feat: add SourceFactoryProvider for declarative data source creation

cb9d6b6

Add SourceFactoryProvider that converts declarative InitializerEntry and SynchronizerEntry config into concrete initializer factories and synchronizer slots, with support for per-entry endpoint and interval overrides.

kinyoklion marked this pull request as ready for review March 19, 2026 22:33

kinyoklion requested a review from a team as a code owner March 19, 2026 22:33

kinyoklion mentioned this pull request Mar 19, 2026

feat: FDv2DataManagerBase for mode switching and data source lifecycle #1210

Merged

This comment was marked as resolved.

Sign in to view

tanderson-ld reviewed Mar 20, 2026

View reviewed changes

Comment thread packages/shared/sdk-client/src/datasource/SourceFactoryProvider.ts Outdated

Base automatically changed from rlamb/fdv2-types-and-validators to main March 20, 2026 15:56

Merge branch 'main' into rlamb/fdv2-source-factory-provider

20f3d28

This comment was marked as resolved.

Sign in to view

fix: increase bundle size limits for common and sdk-client packages

de39213

Account for new FDv2 SourceFactoryProvider and related code paths.

joker23 reviewed Mar 20, 2026

View reviewed changes

Merge branch 'main' into rlamb/fdv2-source-factory-provider

5bddf51

kinyoklion requested review from joker23 and tanderson-ld March 20, 2026 20:43

devin-ai-integration Bot reviewed Mar 20, 2026

View reviewed changes

joker23 approved these changes Mar 20, 2026

View reviewed changes

kinyoklion merged commit e254f77 into main Mar 20, 2026
46 checks passed

kinyoklion deleted the rlamb/fdv2-source-factory-provider branch March 20, 2026 20:56

github-actions Bot mentioned this pull request Mar 20, 2026

chore: release main #1204

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: SourceFactoryProvider for declarative data source creation#1209

feat: SourceFactoryProvider for declarative data source creation#1209
kinyoklion merged 6 commits into
mainfrom
rlamb/fdv2-source-factory-provider

kinyoklion commented Mar 19, 2026 •

edited by devin-ai-integration Bot

Loading

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

github-actions Bot commented Mar 20, 2026 •

edited

Loading

Uh oh!

This comment was marked as resolved.

Uh oh!

github-actions Bot commented Mar 20, 2026

Uh oh!

github-actions Bot commented Mar 20, 2026

Uh oh!

github-actions Bot commented Mar 20, 2026 •

edited

Loading

Uh oh!

joker23 Mar 20, 2026

Uh oh!

kinyoklion Mar 20, 2026

Uh oh!

joker23 Mar 20, 2026

Uh oh!

kinyoklion Mar 20, 2026

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

kinyoklion commented Mar 19, 2026 • edited by devin-ai-integration Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

github-actions Bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

github-actions Bot commented Mar 20, 2026

Uh oh!

github-actions Bot commented Mar 20, 2026

Uh oh!

github-actions Bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joker23 Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

kinyoklion Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

joker23 Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

kinyoklion Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kinyoklion commented Mar 19, 2026 •

edited by devin-ai-integration Bot

Loading

github-actions Bot commented Mar 20, 2026 •

edited

Loading

github-actions Bot commented Mar 20, 2026 •

edited

Loading