ci: consolidate test harness adapter server#1217
Merged
Merged
Conversation
acc2504 to
ed57661
Compare
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
Contributor
Author
|
@cursor review |
kinyoklion
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will implement the SDK testharness adapter server to the shared utils.
This should also stabilize some of the flaky ci tests since we not longer depend on a full repo build to ensure all contract test dependencies are built
Note
Medium Risk
Medium risk because it changes how contract-test infrastructure is built and launched in CI/local scripts, which can break contract test pipelines despite not affecting production runtime.
Overview
Consolidates the browser and React Native contract-test adapter servers into
@launchdarkly/js-contract-test-utils, adding an exportedstartAdapter()API plus a newsdk-testharness-server/stsCLI with configurable ports.Removes the standalone
browser-contract-test-adapterandreact-native-contract-test-adapterworkspaces, updates contract-test entity packages to start the adapter viastart:adapter, and simplifies GitHub Actions workflows to focus/build only the needed workspaces (including updated cleanup process matching the new CLI).Adjusts TypeScript build config in
contract-test-utilsto compile the new adapter/CLI entrypoints, and fixes contract-test ESLint configs by settingtsconfigRootDirfor React and server-node.Written by Cursor Bugbot for commit ebef965. This will update automatically on new commits. Configure here.